fix: approve-tx/approve-sign error divs consistency with confirm-tx #92

clawbot · 2026-02-28T22:13:32+01:00

clawbot commented

2026-02-28 22:13:32 +01:00

Add min-h-[1.25rem] and border styling to approve-tx-error and approve-sign-error divs to prevent layout shift, matching the pattern used by modal-password-error in the confirm-tx view.

Replace direct DOM classList manipulation with showError()/hideError() helpers from helpers.js for consistency.

docker build . passes.

Closes #84

Add `min-h-[1.25rem]` and border styling to `approve-tx-error` and `approve-sign-error` divs to prevent layout shift, matching the pattern used by `modal-password-error` in the confirm-tx view. Replace direct DOM `classList` manipulation with `showError()`/`hideError()` helpers from `helpers.js` for consistency. `docker build .` passes. Closes #84

clawbot added 1 commit 2026-02-28 22:13:33 +01:00

fix: approve-tx/approve-sign error divs consistency with confirm-tx

check / check (push) Successful in 22s

Details

20ced62e1a

Add min-h-[1.25rem] and border styling to approve-tx-error and
approve-sign-error divs to prevent layout shift, matching the pattern
used by modal-password-error in confirm-tx view.

Replace direct DOM classList manipulation with showError()/hideError()
helpers from helpers.js for consistency.

Closes #84

clawbot added the

bot

needs-review

labels 2026-02-28 22:13:48 +01:00

clawbot self-assigned this 2026-02-28 22:20:45 +01:00

clawbot added

merge-ready

and removed

needs-review

bot

labels 2026-02-28 22:21:59 +01:00

clawbot removed their assignment 2026-02-28 22:22:03 +01:00

sneak was assigned by clawbot

2026-02-28 22:22:03 +01:00

clawbot commented

2026-02-28 22:22:12 +01:00

✅ Review: merge-ready

Changes reviewed:

src/popup/index.html: Added min-h-[1.25rem], border border-border border-dashed p-1 to #approve-tx-error and #approve-sign-error divs — prevents layout shift on error show/hide.
src/popup/views/approval.js: Replaced direct classList.add/remove("hidden") and textContent manipulation with showError()/hideError() helpers from helpers.js — consistent with the rest of the codebase.

Verified:

docker build . passes ✅
showError/hideError are properly exported from helpers.js ✅
Addresses all items in #84 ✅
No linter/config changes ✅

Minor note: The modal-password-error div in confirm-tx doesn't have min-h-[1.25rem] on main, so this PR actually improves on that pattern. Could be worth a follow-up to add it there too for full consistency.

Assigned to @sneak for merge.

## ✅ Review: merge-ready **Changes reviewed:** - `src/popup/index.html`: Added `min-h-[1.25rem]`, `border border-border border-dashed p-1` to `#approve-tx-error` and `#approve-sign-error` divs — prevents layout shift on error show/hide. - `src/popup/views/approval.js`: Replaced direct `classList.add/remove("hidden")` and `textContent` manipulation with `showError()`/`hideError()` helpers from `helpers.js` — consistent with the rest of the codebase. **Verified:** - `docker build .` passes ✅ - `showError`/`hideError` are properly exported from helpers.js ✅ - Addresses all items in #84 ✅ - No linter/config changes ✅ **Minor note:** The `modal-password-error` div in confirm-tx doesn't have `min-h-[1.25rem]` on main, so this PR actually improves on that pattern. Could be worth a follow-up to add it there too for full consistency. Assigned to @sneak for merge.

clawbot referenced this pull request

2026-02-28 22:22:28 +01:00

fix: standardize error display to use showError/hideError helpers #88

sneak added 1 commit 2026-02-28 22:25:22 +01:00

Merge branch 'main' into fix/84-approve-error-div-consistency

check / check (push) Successful in 8s

Details

ad2ce3d8ff

sneak merged commit 6a214f1c58 into main

2026-02-28 22:25:38 +01:00

sneak deleted branch fix/84-approve-error-div-consistency

2026-02-28 22:25:38 +01:00