fix: standardize error display to use showError/hideError helpers (closes #87) #96

clawbot · 2026-02-28T22:42:25+01:00

clawbot commented

2026-02-28 22:42:25 +01:00

Standardizes all password/validation error displays to use the showError()/hideError() helper pattern with min-h-[1.25rem] error divs.

Changes

HTML (index.html):

Added add-wallet-error div with min-h-[1.25rem] to add-wallet view
Added import-key-error div with min-h-[1.25rem] to import-key view
Renamed export-privkey-flash → export-privkey-error with min-h-[1.25rem]
Renamed delete-wallet-flash → delete-wallet-error with min-h-[1.25rem], removed text-red-500

JS:

addWallet.js: validation errors use showError("add-wallet-error", ...) instead of showFlash(); success/status messages remain as showFlash()
importKey.js: all validation errors use showError("import-key-error", ...) instead of showFlash()
addressDetail.js: export-privkey errors use showError()/hideError() instead of direct DOM
deleteWallet.js: errors use showError()/hideError() instead of direct DOM; "Wallet deleted" success remains as showFlash()

docker build . passes (tests + lint + build).

Closes #87

Standardizes all password/validation error displays to use the `showError()`/`hideError()` helper pattern with `min-h-[1.25rem]` error divs. ## Changes **HTML (`index.html`):** - Added `add-wallet-error` div with `min-h-[1.25rem]` to add-wallet view - Added `import-key-error` div with `min-h-[1.25rem]` to import-key view - Renamed `export-privkey-flash` → `export-privkey-error` with `min-h-[1.25rem]` - Renamed `delete-wallet-flash` → `delete-wallet-error` with `min-h-[1.25rem]`, removed `text-red-500` **JS:** - `addWallet.js`: validation errors use `showError("add-wallet-error", ...)` instead of `showFlash()`; success/status messages remain as `showFlash()` - `importKey.js`: all validation errors use `showError("import-key-error", ...)` instead of `showFlash()` - `addressDetail.js`: export-privkey errors use `showError()/hideError()` instead of direct DOM - `deleteWallet.js`: errors use `showError()/hideError()` instead of direct DOM; "Wallet deleted" success remains as `showFlash()` `docker build .` passes (tests + lint + build). Closes #87

clawbot added the

bot

label 2026-02-28 22:42:25 +01:00

clawbot added 1 commit 2026-02-28 22:42:26 +01:00

fix: standardize error display to use showError/hideError helpers

check / check (push) Successful in 22s

Details

db1b5c1c69

Replace inconsistent error display patterns across views:

- addWallet.js: replace showFlash() with showError('add-wallet-error', ...)
- importKey.js: replace showFlash() with showError('import-key-error', ...)
- addressDetail.js: replace direct DOM manipulation of export-privkey-flash
  with showError/hideError('export-privkey-error', ...)
- deleteWallet.js: replace direct DOM manipulation of delete-wallet-flash
  with showError/hideError('delete-wallet-error', ...)
- index.html: add dedicated error divs with min-h-[1.25rem] for add-wallet,
  import-key views; rename flash divs to error divs for export-privkey and
  delete-wallet views with consistent styling

All password/validation errors now use the showError()/hideError() helper
pattern with min-h-[1.25rem] error divs to prevent layout shift.
Status/success messages (scanning, wallet deleted) remain as showFlash().

Closes #87

clawbot closed this pull request

2026-02-28 22:42:36 +01:00

clawbot commented

2026-02-28 22:42:37 +01:00

Closing — issue #87 is already closed (covered by merged PR #92).

clawbot added the

needs-review

label 2026-02-28 22:42:40 +01:00

check / check (push) Successful in 22s

Required

Details