consistency: approve-tx and approve-sign password error divs missing min-height (layout shift) #84

New Issue

2026-02-28T21:29:41+01:00

clawbot commented

2026-02-28 21:29:41 +01:00

Problem

The approve-tx and approve-sign views use hidden class toggling on their error divs (#approve-tx-error, #approve-sign-error), which causes layout shift when an error appears or disappears. The error divs have no min-height.

Expected behavior

Password error areas should use min-h-[1.25rem] (like the confirm-tx view does after #78) so that showing/hiding errors does not shift the layout.

Files affected

src/popup/index.html (lines near approve-tx-error and approve-sign-error)
src/popup/views/approval.js (error display logic)

Suggested fix

Replace the hidden class toggling pattern with a permanent min-h-[1.25rem] div, and use showError()/hideError() helpers from helpers.js instead of direct DOM manipulation.

Found during consistency audit for #78.

## Problem The `approve-tx` and `approve-sign` views use `hidden` class toggling on their error divs (`#approve-tx-error`, `#approve-sign-error`), which causes layout shift when an error appears or disappears. The error divs have no `min-height`. ## Expected behavior Password error areas should use `min-h-[1.25rem]` (like the `confirm-tx` view does after #78) so that showing/hiding errors does not shift the layout. ## Files affected - `src/popup/index.html` (lines near `approve-tx-error` and `approve-sign-error`) - `src/popup/views/approval.js` (error display logic) ## Suggested fix Replace the `hidden` class toggling pattern with a permanent `min-h-[1.25rem]` div, and use `showError()`/`hideError()` helpers from `helpers.js` instead of direct DOM manipulation. Found during consistency audit for #78.

clawbot referenced this issue

2026-02-28 21:30:24 +01:00

fix: replace confirm-tx password modal with inline field (closes #78) #83

clawbot referenced this issue

2026-02-28 21:42:51 +01:00

fix: replace confirm-tx password modal with inline field (closes #78) #83

clawbot self-assigned this 2026-02-28 22:11:56 +01:00

clawbot referenced this issue from a commit

2026-02-28 22:13:26 +01:00

fix: approve-tx/approve-sign error divs consistency with confirm-tx

clawbot referenced a pull request that will close this issue

2026-02-28 22:13:32 +01:00