fix: password errors are still shown three different ways #493

New Issue

2026-10-07T06:59:53+02:00

clawbot commented

2026-10-07 06:59:53 +02:00

#87 asked for one way of showing a password error on every screen, the showError()/hideError() helpers in src/popup/views/helpers.js with a fixed-height error line, so a message never shifts the layout. It was closed as covered by #92, which changed only the site approval screens. On next the rest still differ:

the private key export screen uses its own export-privkey-flash line;
the delete wallet screen uses its own delete-wallet-flash line;
the add-wallet screen (recovery phrase and private key) reports a wrong or missing password through the page-wide showFlash().

Three unmerged branches (fix/consistent-error-display, fix/87-consistent-error-display, fix/87-consistent-error-display-v2) hold versions of this change written against February's code; read them for intent, not to merge. Found while pruning branches for #167.

Definition of done

Every password error in the popup is shown with showError()/hideError() in a fixed-height error line next to the field; no screen keeps its own flash line for it.
Messages that are not password errors (for example the address scan progress) are unchanged.
Tests show each changed screen's error appearing and clearing.
make check passes; TODO.md updated in the same commit.

Model: opus-5-5

https://git.eeqj.de/sneak/AutistMask/issues/87 asked for one way of showing a password error on every screen, the `showError()`/`hideError()` helpers in `src/popup/views/helpers.js` with a fixed-height error line, so a message never shifts the layout. It was closed as covered by https://git.eeqj.de/sneak/AutistMask/pulls/92, which changed only the site approval screens. On `next` the rest still differ: - the private key export screen uses its own `export-privkey-flash` line; - the delete wallet screen uses its own `delete-wallet-flash` line; - the add-wallet screen (recovery phrase and private key) reports a wrong or missing password through the page-wide `showFlash()`. Three unmerged branches (`fix/consistent-error-display`, `fix/87-consistent-error-display`, `fix/87-consistent-error-display-v2`) hold versions of this change written against February's code; read them for intent, not to merge. Found while pruning branches for https://git.eeqj.de/sneak/AutistMask/issues/167. ## Definition of done - [ ] Every password error in the popup is shown with `showError()`/`hideError()` in a fixed-height error line next to the field; no screen keeps its own flash line for it. - [ ] Messages that are not password errors (for example the address scan progress) are unchanged. - [ ] Tests show each changed screen's error appearing and clearing. - [ ] `make check` passes; `TODO.md` updated in the same commit. Model: opus-5-5

clawbot referenced this issue

2026-10-07 07:09:22 +02:00

chore: prune landed remote branches (closes #167) #491

clawbot commented

2026-10-07 08:09:35 +02:00

Plan: the add-wallet, private key export and delete wallet screens show password errors with the existing showError()/hideError() in a fixed-height line next to the field, as the approval and confirm screens do; their flash lines go. Other messages stay. Jest tests per screen; e2e steps follow.

Model: opus-5-5

Plan: the add-wallet, private key export and delete wallet screens show password errors with the existing `showError()`/`hideError()` in a fixed-height line next to the field, as the approval and confirm screens do; their flash lines go. Other messages stay. Jest tests per screen; e2e steps follow. Model: opus-5-5

clawbot referenced this issue from a commit

2026-10-07 08:21:22 +02:00

fix: show every password error in its own line below the field (closes #493)

clawbot referenced a pull request that will close this issue

2026-10-07 08:49:04 +02:00

fix: show every password error in its own line below the field #496

clawbot commented

2026-10-07 08:49:09 +02:00

Built in #496: the add wallet, private key export, recovery phrase and delete wallet screens show a password error in an error line below the password field; other messages are unchanged. The recovery phrase screen is included because the definition of done covers every password error.

Model: opus-5-5

Built in https://git.eeqj.de/sneak/AutistMask/pulls/496: the add wallet, private key export, recovery phrase and delete wallet screens show a password error in an error line below the password field; other messages are unchanged. The recovery phrase screen is included because the definition of done covers every password error. Model: opus-5-5

clawbot referenced this issue from a commit

2026-10-07 10:13:14 +02:00

fix: show every password error in its own line below the field (closes #493)

clawbot closed this issue

2026-10-07 10:59:17 +02:00

clawbot referenced this issue from a commit

2026-10-07 10:59:18 +02:00

fix: show every password error in its own fixed-height line (closes #493)

Sign in to join this conversation.