Add min-h-[1.25rem] and border styling to approve-tx-error and approve-sign-error divs to prevent layout shift, matching the pattern used by modal-password-error in the confirm-tx view.
Replace direct DOM classList manipulation with showError()/hideError() helpers from helpers.js for consistency.
Add `min-h-[1.25rem]` and border styling to `approve-tx-error` and `approve-sign-error` divs to prevent layout shift, matching the pattern used by `modal-password-error` in the confirm-tx view.
Replace direct DOM `classList` manipulation with `showError()`/`hideError()` helpers from `helpers.js` for consistency.
`docker build .` passes.
Closes #84
Add min-h-[1.25rem] and border styling to approve-tx-error and
approve-sign-error divs to prevent layout shift, matching the pattern
used by modal-password-error in confirm-tx view.
Replace direct DOM classList manipulation with showError()/hideError()
helpers from helpers.js for consistency.
Closes#84
src/popup/index.html: Added min-h-[1.25rem], border border-border border-dashed p-1 to #approve-tx-error and #approve-sign-error divs — prevents layout shift on error show/hide.
src/popup/views/approval.js: Replaced direct classList.add/remove("hidden") and textContent manipulation with showError()/hideError() helpers from helpers.js — consistent with the rest of the codebase.
Verified:
docker build . passes ✅
showError/hideError are properly exported from helpers.js ✅
Minor note: The modal-password-error div in confirm-tx doesn't have min-h-[1.25rem] on main, so this PR actually improves on that pattern. Could be worth a follow-up to add it there too for full consistency.
## ✅ Review: merge-ready
**Changes reviewed:**
- `src/popup/index.html`: Added `min-h-[1.25rem]`, `border border-border border-dashed p-1` to `#approve-tx-error` and `#approve-sign-error` divs — prevents layout shift on error show/hide.
- `src/popup/views/approval.js`: Replaced direct `classList.add/remove("hidden")` and `textContent` manipulation with `showError()`/`hideError()` helpers from `helpers.js` — consistent with the rest of the codebase.
**Verified:**
- `docker build .` passes ✅
- `showError`/`hideError` are properly exported from helpers.js ✅
- Addresses all items in #84 ✅
- No linter/config changes ✅
**Minor note:** The `modal-password-error` div in confirm-tx doesn't have `min-h-[1.25rem]` on main, so this PR actually improves on that pattern. Could be worth a follow-up to add it there too for full consistency.
Assigned to @sneak for merge.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Add
min-h-[1.25rem]and border styling toapprove-tx-errorandapprove-sign-errordivs to prevent layout shift, matching the pattern used bymodal-password-errorin the confirm-tx view.Replace direct DOM
classListmanipulation withshowError()/hideError()helpers fromhelpers.jsfor consistency.docker build .passes.Closes #84
✅ Review: merge-ready
Changes reviewed:
src/popup/index.html: Addedmin-h-[1.25rem],border border-border border-dashed p-1to#approve-tx-errorand#approve-sign-errordivs — prevents layout shift on error show/hide.src/popup/views/approval.js: Replaced directclassList.add/remove("hidden")andtextContentmanipulation withshowError()/hideError()helpers fromhelpers.js— consistent with the rest of the codebase.Verified:
docker build .passes ✅showError/hideErrorare properly exported from helpers.js ✅Minor note: The
modal-password-errordiv in confirm-tx doesn't havemin-h-[1.25rem]on main, so this PR actually improves on that pattern. Could be worth a follow-up to add it there too for full consistency.Assigned to @sneak for merge.