• Joined on 2026-02-08
clawbot commented on pull request sneak/pixa#328 2026-10-26 10:13:06 +01:00
Count hits, misses, fetches and transforms as Prometheus counters (closes #311)

Reworked per sneak/pixa#328 (comment), now at 018c12a:

  1. The counters are fields of the cache, made in NewCache and registered on the registry it is…
clawbot pushed to issue-311-prometheus-counters at sneak/pixa 2026-10-26 10:12:41 +01:00
018c12a8d2 Count hits, misses, fetches and transforms as Prometheus counters (closes #311)
clawbot commented on pull request sneak/pixa#328 2026-10-26 10:00:30 +01:00
Count hits, misses, fetches and transforms as Prometheus counters (closes #311)

FAIL: needs-rework

  1. internal/imgcache/counters.go, and the seven tests marked //nolint:paralleltest. The counters are package-level variables. That needs one gochecknoglobals…
clawbot pushed to issue-668-explorer-lookups-opt-in at sneak/AutistMask 2026-10-26 09:58:11 +01:00
e66aac60e2 fix: Blockscout and Etherscan lookups are off until the user turns them on (closes #668)
clawbot commented on pull request sneak/quak#226 2026-10-26 09:56:51 +01:00
quak get and get-thumb on an empty cache stop fetching collections once they find the file (closes #222)

Rework of the review in sneak/quak#226 (comment), against the revised sneak/quak#222:

  1. README.md, "CLI surface": now says they…
clawbot pushed to issue-222-get-stops-at-file at sneak/quak 2026-10-26 09:56:18 +01:00
fde6f19c86 quak get and get-thumb on an empty cache stop fetching collections once they find the file (closes #222)
clawbot commented on pull request sneak/sfdupes#141 2026-10-26 09:54:42 +01:00
Rewrite TODO.md sentence by sentence (closes #135)

FAIL: needs-rework. Line numbers refer to TODO.md at the PR head.

  1. L138-141: "the content phase's checks and reads lines were too wide for those words. That held at most elapsed times…
clawbot commented on pull request sneak/sfdupes#140 2026-10-26 09:54:42 +01:00
Rewrite README.md sentence by sentence for a newcomer

FAIL: needs-rework. Line numbers refer to README.md at the PR head.

False statements

  1. L122-123 and L524: "a line for each path the walk leaves out on purpose". L377-382 counts a…
clawbot commented on issue sneak/pixa#311 2026-10-26 09:51:01 +01:00
Count hits, misses, fetches and transforms as Prometheus counters instead of the cache_stats table

Built in sneak/pixa#328. The five counts are Prometheus counters in memory, in internal/imgcache/counters.go, on the registry /metrics serves. cache_stats,…

clawbot created pull request sneak/pixa#328 2026-10-26 09:50:53 +01:00
Count hits, misses, fetches and transforms as Prometheus counters (closes #311)
clawbot pushed to issue-311-prometheus-counters at sneak/pixa 2026-10-26 09:50:44 +01:00
c3a6799763 Count hits, misses, fetches and transforms as Prometheus counters (closes #311)
clawbot created branch issue-311-prometheus-counters in sneak/pixa 2026-10-26 09:50:44 +01:00
clawbot commented on pull request sneak/quak#226 2026-10-26 09:46:15 +01:00
quak get and get-thumb on an empty cache stop fetching collections once they find the file (closes #222)

Review: FAIL, needs rework.

  1. README.md, "CLI surface": "They store nothing they read. The original or thumbnail they fetch is kept in the cache." The first sentence is false as written,…
clawbot commented on pull request sneak/AutistMask#671 2026-10-26 09:37:29 +01:00
fix: Blockscout and Etherscan lookups are off until the user turns them on (closes #668)

Review: FAIL (needs-rework)

  1. The dApp approval screens still rely on Blockscout for a token the user holds but has not tracked, and they do not say so while "Use Blockscout" is off.…
clawbot opened issue sneak/sfdupes#142 2026-10-26 09:33:07 +01:00
scan drops an operand inside a .zfs directory when another operand lies above it
clawbot commented on issue sneak/pixa#311 2026-10-26 09:29:39 +01:00
Count hits, misses, fetches and transforms as Prometheus counters instead of the cache_stats table

Plan: the five counters become in-memory Prometheus counters in internal/imgcache, registered on the registry /metrics serves; cache_stats, Stats, CacheStats and the pending counts go…

clawbot deleted branch issue-310-schema-only-what-pixa-uses from sneak/pixa 2026-10-26 09:29:29 +01:00
clawbot pushed to next at sneak/pixa 2026-10-26 09:29:29 +01:00
6b19e4c96c Declare only the tables and columns pixa writes and reads (closes #310)
clawbot merged pull request sneak/pixa#326 2026-10-26 09:29:27 +01:00
Declare only the tables and columns pixa writes and reads (closes #310)
clawbot closed issue sneak/pixa#310 2026-10-26 09:29:27 +01:00
Make the schema file describe only the tables and columns pixa uses