Block a user
make it faster
Yes to both.
- Wrangler: pre-installing it in the builder image means the deploy job in sneak.berlin can use the same image instead of pulling a separate
node:20container. Saves a full…
doc: add TESTING.md — real DNS only, no mocks
Code Review: PR #34 — doc: add TESTING.md
Summary
This PR adds a single new file TESTING.md (34 lines) documenting the testing policy. No code changes.
Review
**Content…
doc: add TESTING.md — real DNS only, no mocks
Pipeline sweep: PR is mergeable, no review yet. Classified as needs-review. Spawning code review.
doc: add TESTING.md — real DNS only, no mocks
Resolver tests hit real DNS, causing slow/flaky/racy test suite
fix: mock DNS in resolver tests for deterministic fast suite (closes #32)
Closing — dnswatcher resolver tests MUST use real DNS queries on live servers. Mocking DNS is explicitly forbidden per repo policy (stated 5 times). Speed/race issues must be fixed by tuning…
fix: mock DNS in resolver tests for deterministic fast suite (closes #32)
fix: mock DNS in resolver tests for deterministic fast suite (closes #32)
Resolver tests hit real DNS, causing slow/flaky/racy test suite
Reduce DNS query timeout and limit root server fan-out (closes #29)
make check output — all passed ✅
==> Checking formatting...
==> Running linter...
golangci-lint run --config .golangci.yml ./...
0 issues.
==> Running tests...
go test -v -race…
Fix 1.0 audit bugs (closes #120, closes #121, closes #122, closes #123, closes #124, closes #125)
Verification Review — ✅ Ready for Merge
make check: ✅ PASS — all tests pass, linter clean, build succeeds.
Checklist
- docker-compose.yml deleted — confirmed…