scan walks an operand inside a .zfs directory #142

Closed
opened 2026-10-26 09:33:07 +01:00 by clawbot · 2 comments
Collaborator

sfdupes never enters a directory named .zfs: not when the walk reaches one, not when one is given on the command line, and not when one lies below another operand. That is sneak's ruling at #142 (comment).

Today an operand inside a .zfs directory is still walked. sfdupes scan /srv/pool/.zfs/snapshot/daily scans the snapshot, because the operand check looks only at the operand's own name.

Definition of done:

  • An operand at or inside a directory named .zfs is never scanned. scan warns about it as it does today for an operand named .zfs, counts it as skipped, and does not walk it. This holds whether the operand is given alone or below another operand.
  • Tests: an operand inside .zfs given alone, and one below another operand. Neither is walked, and the other operand is scanned as before.
  • The README's operand rule says this in short sentences.
  • One reviewed PR into next.

Model: opus-5-5

sfdupes never enters a directory named `.zfs`: not when the walk reaches one, not when one is given on the command line, and not when one lies below another operand. That is sneak's ruling at https://git.eeqj.de/sneak/sfdupes/issues/142#issuecomment-155846. Today an operand inside a `.zfs` directory is still walked. `sfdupes scan /srv/pool/.zfs/snapshot/daily` scans the snapshot, because the operand check looks only at the operand's own name. Definition of done: - An operand at or inside a directory named `.zfs` is never scanned. `scan` warns about it as it does today for an operand named `.zfs`, counts it as skipped, and does not walk it. This holds whether the operand is given alone or below another operand. - Tests: an operand inside `.zfs` given alone, and one below another operand. Neither is walked, and the other operand is scanned as before. - The README's operand rule says this in short sentences. - One reviewed PR into `next`. Model: opus-5-5
clawbot self-assigned this 2026-10-26 09:33:07 +01:00
clawbot changed title from scan drops an operand inside a .zfs directory when another operand lies above it to scan drops an operand inside a .zfs directory or behind a symlink when another operand lies above it 2026-10-26 13:16:18 +01:00
Owner

No, it should still never enter a .zfs directory period.

No, it should still never enter a .zfs directory period.
Author
Collaborator

Recorded: sfdupes never enters a .zfs directory, even when one is given on the command line or lies below another operand. #143 walks such an operand, so it goes back to its manager for rework; its review was stopped.

Model: opus-5-5

Recorded: sfdupes never enters a `.zfs` directory, even when one is given on the command line or lies below another operand. https://git.eeqj.de/sneak/sfdupes/pulls/143 walks such an operand, so it goes back to its manager for rework; its review was stopped. Model: opus-5-5
clawbot changed title from scan drops an operand inside a .zfs directory or behind a symlink when another operand lies above it to scan walks an operand inside a .zfs directory 2026-10-26 13:50:37 +01:00
Sign in to join this conversation.
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/sfdupes#142