clawbot
0 Followers · 0 Following
  • Joined on 2026-02-08
Repositories Projects Packages Code Public Activity Starred Repositories
clawbot commented on pull request sneak/dnswatcher#31 2026-02-22 12:41:42 +01:00
resolver: reduce query timeout to 1s and limit root fan-out to 3 (closes #29)

Updated timeout from 2s → 1s per feedback (3× max antipodal RTT ~300ms + 10ms processing = ~910ms, rounded to 1s).

Results (5 consecutive runs, resolver package only):

  • Before: ~39s -…
clawbot commented on pull request sneak/upaas#126 2026-02-22 12:41:28 +01:00
Fix 1.0 audit bugs (closes #120, closes #121, closes #122, closes #123, closes #124, closes #125)

Rework Complete — Addressing Review Feedback

All changes from sneak's review have been implemented:

1. Delete docker-compose.yml ✅

File removed. Example docker-compose stanza added to…

clawbot pushed to fix/audit-bugs-120-125 at sneak/upaas 2026-02-22 12:41:09 +01:00
c9fe4f4bf1 rework: address review feedback on PR #126
clawbot commented on pull request sneak/dnswatcher#31 2026-02-22 12:37:41 +01:00
resolver: reduce query timeout to 1s and limit root fan-out to 3 (closes #29)

Updated: timeout changed from 2s → 1s

make check: ✅ all passed, 0 linter issues

Test timing

clawbot pushed to fix/dns-timeout-and-root-fanout at sneak/dnswatcher 2026-02-22 12:37:28 +01:00
6393fa6cdb resolver: reduce query timeout to 1s and limit root fan-out to 3 (closes #29)
clawbot pushed to fix/dns-timeout-and-root-fanout at sneak/dnswatcher 2026-02-22 12:37:19 +01:00
ff8b8e5622 resolver: reduce query timeout to 1s and limit root fan-out to 3 (closes #29)
clawbot closed pull request sneak/dnswatcher#31 2026-02-22 12:36:46 +01:00
resolver: reduce query timeout to 1s and limit root fan-out to 3 (closes #29)
clawbot commented on pull request sneak/dnswatcher#31 2026-02-22 12:36:44 +01:00
resolver: reduce query timeout to 1s and limit root fan-out to 3 (closes #29)

make check results

All checks passed:

  • Formatting: ✅
  • Linter (golangci-lint): ✅ 0 issues
  • Tests (go test -v -race): ✅ all passed
  • Build: ✅

Test timing comparison

clawbot created pull request sneak/dnswatcher#31 2026-02-22 12:36:36 +01:00
resolver: reduce query timeout to 2s and limit root fan-out to 3 (closes #29)
clawbot pushed to fix/dns-timeout-and-root-fanout at sneak/dnswatcher 2026-02-22 12:36:20 +01:00
fa7ac4929f resolver: reduce query timeout to 2s and limit root fan-out to 3 (closes #29)
clawbot created branch fix/dns-timeout-and-root-fanout in sneak/dnswatcher 2026-02-22 12:36:20 +01:00
clawbot created pull request sneak/dnswatcher#30 2026-02-22 12:36:09 +01:00
Reduce DNS query timeout and limit root server fan-out (closes #29)
clawbot pushed to fix/reduce-dns-timeout-and-root-fanout at sneak/dnswatcher 2026-02-22 12:36:01 +01:00
203b581704 Reduce DNS query timeout to 2s and limit root server fan-out to 3
clawbot created branch fix/reduce-dns-timeout-and-root-fanout in sneak/dnswatcher 2026-02-22 12:36:01 +01:00
clawbot opened issue sneak/dnswatcher#29 2026-02-22 12:33:45 +01:00
Reduce DNS query timeout and limit root server fan-out
clawbot commented on pull request sneak/upaas#126 2026-02-22 12:31:42 +01:00
Fix 1.0 audit bugs (closes #120, closes #121, closes #122, closes #123, closes #124, closes #125)

Code Review — ⚠️ Needs Rework

make check: ✅ PASS — all tests pass, linter clean, build succeeds.

sneak's Latest Feedback (Not Yet Addressed)

sneak's [most recent…

clawbot commented on pull request sneak/upaas#126 2026-02-21 20:49:16 +01:00
Fix 1.0 audit bugs (closes #120, closes #121, closes #122, closes #123, closes #124, closes #125)

Code Review — ✅ LGTM

Rebased on main, all checks pass (make check clean). Reviewed all 6 commits:

  1. #120 docker-compose bind mount — correct, replaces named volume with…
clawbot commented on pull request sneak/upaas#126 2026-02-21 20:47:35 +01:00
Fix 1.0 audit bugs (closes #120, closes #121, closes #122, closes #123, closes #124, closes #125)

Fixed rework item for #124: removed the unused imageID (_ string) parameter from createAndStartContainer. This also made the imageID parameter in deployContainerWithTimeout unused, so…

clawbot pushed to fix/audit-bugs-120-125 at sneak/upaas 2026-02-21 20:47:27 +01:00
92fbf686bd fix(#124): remove unused imageID parameter from createAndStartContainer
clawbot pushed to fix/audit-bugs-120-125 at sneak/upaas 2026-02-21 20:46:45 +01:00
4d7fed6331 fix(#124): remove unused imageID parameter from createAndStartContainer