Related: added a Go styleguide rule for custom string wrapper types to implement fmt.Stringer and use .String() at SDK boundaries: sneak/prompts#3
Sorry — two sub-agents raced and created duplicate PRs. This one got closed in favor of PR #2 which covers the same change. I'll make sure #2 also includes the Stringer rule (not just the…
Rebased fix/audit-bugs-120-125 onto main to resolve merge conflicts from PR #127.
Conflicts were in internal/service/deploy/deploy.go (domain type changes from the rework commit vs PR…
ae2611f027
fix: use renderTemplate in all error paths of HandleAppCreate/HandleAppUpdate (closes #121)
All review comments have been addressed:
- README relative paths — fixed to absolute URLs
- No separate types package —
internal/domainremoved entirely - "domain" bad name…
Re comments 4 & 5:
ContainerLogs already uses ContainerID in its signature (updated in the types refactor). All our wrapper methods (StartContainer, StopContainer, RemoveContainer,…
Checked CODE_STYLEGUIDE_GO.md — it didn't have a rule about type-only packages. Created PR to add one: sneak/prompts#1
Eliminated the internal/domain package entirely. Types now live alongside their implementations:
ImageID+ContainerID→internal/docker/types.goUnparsedURL→ `internal/service/w…
To clarify: c.docker is *client.Client from the Docker SDK (github.com/docker/docker/client). Its methods (ContainerStart, ContainerStop, ContainerLogs, ContainerInspect, etc.) all…
Fixed in 5c43d5b: The domain package (and its import alias) no longer exists. Types are defined directly in the packages that use them, so there's no domain name anywhere.