Item 6 of 15 of #168: "Remove the surface nothing uses". Starts when #311 is squash-merged to next.
Today (next at 989da78)
These have no caller outside tests (checked by name at 989da78; some will be gone after the items before this one): Service.Warm (calls Get and discards the result), the imgcache.ImageCache interface, imgcache.ParseImageURL (test-only twin of ParseImagePath), signature.ParseParams (the handler parses exp itself), Service.GenerateSignedURL and Signer.GenerateSignedURL (README.md documents the algorithm for clients), encurl.FromImageRequest, magic.PeekAndValidate, magic.IsSupportedMIMEType, magic.MIMEToImageFormat, magic.ImageFormatToMIME, imageprocessor.SupportedInputFormats and SupportedOutputFormats, allowlist.IsEmpty and Count, httpfetcher.ssrfSafeDialer, Cache.GetSourceMetadataID, imgcache.CacheStale, ErrCacheMiss, ErrNegativeCache, ImageResponse.LastModified (never set; #83 adds it for real), LookupResult (only Hit and the key are read), ContentStorage.Store, VariantStorage.Load, and MetadataStorage.Load and Exists. Cache.CleanExpired is on the list in #168 but the eviction loop now calls it; check it again. Every unused method is a promise a newcomer has to check before trusting the model.
Definition of done
Each symbol above that still exists and has no caller outside tests when this starts is deleted. One still called from production code stays, and the PR body names it in one line.
A test that uses a removed test-only helper takes the helper into its own _test.go file, or is deleted when it tests nothing but the removed code.
LookupResult, if it still exists, becomes what its callers read.
README.md and TODO.md no longer name anything removed.
Approval and tests
sneak asked for each main recommendation of #168 to be its own issue, built before 1.0, one at a time in the order listed (#168 (comment)). That instruction is his approval of this item, including the deletion of the tests of the code it removes. Existing tests change only as this item needs: they follow code that moves or is renamed, and the tests of code this item removes go with it; no other assertion is weakened or dropped.
Model: opus-5-5
Item 6 of 15 of https://git.eeqj.de/sneak/pixa/issues/168: "Remove the surface nothing uses". Starts when https://git.eeqj.de/sneak/pixa/issues/311 is squash-merged to `next`.
## Today (`next` at `989da78`)
These have no caller outside tests (checked by name at `989da78`; some will be gone after the items before this one): `Service.Warm` (calls `Get` and discards the result), the `imgcache.ImageCache` interface, `imgcache.ParseImageURL` (test-only twin of `ParseImagePath`), `signature.ParseParams` (the handler parses `exp` itself), `Service.GenerateSignedURL` and `Signer.GenerateSignedURL` (`README.md` documents the algorithm for clients), `encurl.FromImageRequest`, `magic.PeekAndValidate`, `magic.IsSupportedMIMEType`, `magic.MIMEToImageFormat`, `magic.ImageFormatToMIME`, `imageprocessor.SupportedInputFormats` and `SupportedOutputFormats`, `allowlist.IsEmpty` and `Count`, `httpfetcher.ssrfSafeDialer`, `Cache.GetSourceMetadataID`, `imgcache.CacheStale`, `ErrCacheMiss`, `ErrNegativeCache`, `ImageResponse.LastModified` (never set; https://git.eeqj.de/sneak/pixa/issues/83 adds it for real), `LookupResult` (only `Hit` and the key are read), `ContentStorage.Store`, `VariantStorage.Load`, and `MetadataStorage.Load` and `Exists`. `Cache.CleanExpired` is on the list in https://git.eeqj.de/sneak/pixa/issues/168 but the eviction loop now calls it; check it again. Every unused method is a promise a newcomer has to check before trusting the model.
## Definition of done
- Each symbol above that still exists and has no caller outside tests when this starts is deleted. One still called from production code stays, and the PR body names it in one line.
- A test that uses a removed test-only helper takes the helper into its own `_test.go` file, or is deleted when it tests nothing but the removed code.
- `LookupResult`, if it still exists, becomes what its callers read.
- `README.md` and `TODO.md` no longer name anything removed.
## Approval and tests
sneak asked for each main recommendation of https://git.eeqj.de/sneak/pixa/issues/168 to be its own issue, built before 1.0, one at a time in the order listed (https://git.eeqj.de/sneak/pixa/issues/168#issuecomment-153513). That instruction is his approval of this item, including the deletion of the tests of the code it removes. Existing tests change only as this item needs: they follow code that moves or is renamed, and the tests of code this item removes go with it; no other assertion is weakened or dropped.
Model: opus-5-5
clawbot
added this to the 1.0.0 milestone 2026-10-21 12:50:16 +02:00
clawbot
self-assigned this 2026-10-21 12:50:16 +02:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Item 6 of 15 of #168: "Remove the surface nothing uses". Starts when #311 is squash-merged to
next.Today (
nextat989da78)These have no caller outside tests (checked by name at
989da78; some will be gone after the items before this one):Service.Warm(callsGetand discards the result), theimgcache.ImageCacheinterface,imgcache.ParseImageURL(test-only twin ofParseImagePath),signature.ParseParams(the handler parsesexpitself),Service.GenerateSignedURLandSigner.GenerateSignedURL(README.mddocuments the algorithm for clients),encurl.FromImageRequest,magic.PeekAndValidate,magic.IsSupportedMIMEType,magic.MIMEToImageFormat,magic.ImageFormatToMIME,imageprocessor.SupportedInputFormatsandSupportedOutputFormats,allowlist.IsEmptyandCount,httpfetcher.ssrfSafeDialer,Cache.GetSourceMetadataID,imgcache.CacheStale,ErrCacheMiss,ErrNegativeCache,ImageResponse.LastModified(never set; #83 adds it for real),LookupResult(onlyHitand the key are read),ContentStorage.Store,VariantStorage.Load, andMetadataStorage.LoadandExists.Cache.CleanExpiredis on the list in #168 but the eviction loop now calls it; check it again. Every unused method is a promise a newcomer has to check before trusting the model.Definition of done
_test.gofile, or is deleted when it tests nothing but the removed code.LookupResult, if it still exists, becomes what its callers read.README.mdandTODO.mdno longer name anything removed.Approval and tests
sneak asked for each main recommendation of #168 to be its own issue, built before 1.0, one at a time in the order listed (#168 (comment)). That instruction is his approval of this item, including the deletion of the tests of the code it removes. Existing tests change only as this item needs: they follow code that moves or is renamed, and the tests of code this item removes go with it; no other assertion is weakened or dropped.
Model: opus-5-5