clawbot
0 Followers · 0 Following
  • Joined on 2026-02-08
Repositories Projects Packages Code Public Activity Starred Repositories
clawbot commented on pull request sneak/upaas#126 2026-02-24 00:45:04 +01:00
Fix 1.0 audit bugs (closes #120, closes #121, closes #122, closes #123, closes #124, closes #125)

Code Review — ✅ Merge-Ready

Rebased on main (already up-to-date, no conflicts). make check passes cleanly.

==> All checks passed!

All tests pass, linter clean, build succeeds.…

clawbot commented on pull request sneak/upaas#129 2026-02-24 00:44:18 +01:00
Refactor: break up app.js into smaller modules

make check output

All tests passed:
- git.eeqj.de/sneak/upaas/internal/models: PASS (3.773s)
- git.eeqj.de/sneak/upaas/internal/service/app: PASS (2.880s)
- git.eeqj.de/sneak/upaas/intern…
clawbot commented on pull request sneak/upaas#126 2026-02-23 22:17:33 +01:00
Fix 1.0 audit bugs (closes #120, closes #121, closes #122, closes #123, closes #124, closes #125)

Pushed 5791d33: expanded the Important note to explain that HOST_DATA_DIR must be an absolute host path, why relative paths break, and added a usage example.

All previous commits already…

clawbot pushed to fix/audit-bugs-120-125 at sneak/upaas 2026-02-23 22:17:24 +01:00
5791d33720 docs: expand Important note — HOST_DATA_DIR must be absolute path
clawbot commented on pull request sneak/upaas#126 2026-02-23 22:16:17 +01:00
Fix 1.0 audit bugs (closes #120, closes #121, closes #122, closes #123, closes #124, closes #125)

Fixed the remaining relative path default in the README config table:

  1. HOST_DATA_DIR in docker-compose — already fixed in 4d53ee5 (no more :-./data fallback)
  2. UPAAS_DATA_DIR config…
clawbot pushed to fix/audit-bugs-120-125 at sneak/upaas 2026-02-23 22:16:09 +01:00
e115aa765a docs: clarify UPAAS_DATA_DIR default is for local dev only
clawbot commented on pull request sneak/upaas#126 2026-02-23 22:15:18 +01:00
Fix 1.0 audit bugs (closes #120, closes #121, closes #122, closes #123, closes #124, closes #125)

Removed relative path default (:-./data) for HOST_DATA_DIR in the README docker-compose example — both the volume mount and env var now require it to be explicitly set. Also updated the…

clawbot pushed to fix/audit-bugs-120-125 at sneak/upaas 2026-02-23 22:15:14 +01:00
4d53ee5b06 docs: remove relative path default for HOST_DATA_DIR in docker-compose example
clawbot commented on pull request sneak/upaas#126 2026-02-23 22:14:25 +01:00
Fix 1.0 audit bugs (closes #120, closes #121, closes #122, closes #123, closes #124, closes #125)

Removed internal/domain package entirely:

  • ImageID + ContainerID (with Stringer methods) → internal/docker/types.go
  • UnparsedURL (with Stringer method) → `internal/service/webhook/t…
clawbot pushed to fix/audit-bugs-120-125 at sneak/upaas 2026-02-23 22:14:19 +01:00
86528ad63e refactor: remove internal/domain package, move types to correct packages
clawbot commented on pull request sneak/simplelog#6 2026-02-23 21:00:02 +01:00
feat: add RELP handler for reliable log delivery to rsyslog (closes #5)

There are two Go RELP libraries:

  1. stith/gorelp — simple client+server, but server-only focus (no client Send method). Last commit ~10 years ago. 2.…
clawbot commented on pull request sneak/upaas#126 2026-02-23 20:58:07 +01:00
Fix 1.0 audit bugs (closes #120, closes #121, closes #122, closes #123, closes #124, closes #125)

Added String() methods (implementing fmt.Stringer) to ImageID, ContainerID, and UnparsedURL in internal/domain/types.go. Replaced all string(var) casts with var.String() calls…

clawbot pushed to fix/audit-bugs-120-125 at sneak/upaas 2026-02-23 20:58:03 +01:00
75cad7d2ad refactor: add String() methods to domain types, replace string() casts
clawbot closed pull request sneak/prompts#3 2026-02-23 20:56:46 +01:00
go styleguide: require Stringer for custom string wrapper types
clawbot commented on pull request sneak/prompts#3 2026-02-23 20:56:45 +01:00
go styleguide: require Stringer for custom string wrapper types

Closing as duplicate — the Stringer rule is already included in PR #2 alongside the no-type-only-packages rule.

clawbot commented on pull request sneak/prompts#2 2026-02-23 20:56:23 +01:00
style(go): add rule against type-only packages (per upaas #126 review)

Added the Stringer rule: custom string-based types must implement fmt.Stringer, and .String() should be used at SDK/library boundaries instead of string(v).

clawbot commented on pull request sneak/upaas#126 2026-02-23 20:56:17 +01:00
Fix 1.0 audit bugs (closes #120, closes #121, closes #122, closes #123, closes #124, closes #125)

Rebased onto latest main (includes merged PRs #119 and #127). All conflicts resolved, make check passes clean. Ready for re-review.

clawbot pushed to fix/1.0-audit-bugs at sneak/upaas 2026-02-23 20:56:13 +01:00
478746c356 rebase: apply audit bug fixes on latest main
28f014ce95 Merge pull request 'fix: use imageID in createAndStartContainer (closes #124)' (#127) from fix/use-image-id-in-container into main
dc638a07f1 Merge pull request 'fix: pin all external refs to cryptographic identity (closes #118)' (#119) from fix/pin-external-refs-crypto-identity into main
0e8efe1043 fix: use imageID in createAndStartContainer (closes #124)
0ed2d02dfe fix: pin all external refs to cryptographic identity (closes #118)
Compare 5 commits »
clawbot commented on pull request sneak/upaas#126 2026-02-23 20:55:35 +01:00
Fix 1.0 audit bugs (closes #120, closes #121, closes #122, closes #123, closes #124, closes #125)

Implemented String() methods on ImageID, ContainerID, and UnparsedURL. Replaced all string() casts with .String() calls. make check passes clean.

==> All checks passed!
clawbot pushed to fix/1.0-audit-bugs at sneak/upaas 2026-02-23 20:55:28 +01:00
8ec3ea461c feat: implement Stringer on custom string types