quak helper fix-missing-thumbnails --file used to wait for a refresh. On an empty cache, that refresh fetched the files of every collection. The command now finds the named files through the new freshFilesByID in src/cli-read.ts, by the rule freshFile follows since #226.
When the cache holds the account's collections, it refreshes as before and looks each file up in the cache.
On an empty cache, it reads the collection list, then one collection's files at a time, and stops once it has found every file. It stores none of the collections or file records it reads. The original fetched for a repair is kept in the content cache.
fixMissingThumbnails no longer walks the albums in the store. It takes the records the command found, and fetches each original through lib.originalOf(file). Without --file, the command scans as before, then looks the files up with cachedFilesByID.
What the diff does not show:
Unlike quak get, the search reads the most recently updated collection first. lib.albums.list() uses that order, so a file in several albums keeps the album name it was printed with.
The -q test on --file 999 has no refresh progress left to hide. The -q test on quak files still covers that.
The many-albums photos now record a thumbnail size, so the helper downloads an original before it skips one.
Disclosure:
Judgement call: the original is fetched with the file's record in the album it is named after. next used the library's own record of the file. Both are copies of one file.
Model: opus-5-5
Fixes https://git.eeqj.de/sneak/quak/issues/223.
`quak helper fix-missing-thumbnails --file` used to wait for a refresh. On an empty cache, that refresh fetched the files of every collection. The command now finds the named files through the new `freshFilesByID` in `src/cli-read.ts`, by the rule `freshFile` follows since https://git.eeqj.de/sneak/quak/pulls/226.
- When the cache holds the account's collections, it refreshes as before and looks each file up in the cache.
- On an empty cache, it reads the collection list, then one collection's files at a time, and stops once it has found every file. It stores none of the collections or file records it reads. The original fetched for a repair is kept in the content cache.
`fixMissingThumbnails` no longer walks the albums in the store. It takes the records the command found, and fetches each original through `lib.originalOf(file)`. Without `--file`, the command scans as before, then looks the files up with `cachedFilesByID`.
What the diff does not show:
- Unlike `quak get`, the search reads the most recently updated collection first. `lib.albums.list()` uses that order, so a file in several albums keeps the album name it was printed with.
- The `-q` test on `--file 999` has no refresh progress left to hide. The `-q` test on `quak files` still covers that.
- The many-albums photos now record a thumbnail size, so the helper downloads an original before it skips one.
Disclosure:
- Judgement call: the original is fetched with the file's record in the album it is named after. `next` used the library's own record of the file. Both are copies of one file.
Model: opus-5-5
test/cli/read.test.ts and test/cli/commands.test.ts: no test tells "the most recently updated collection first" from "the highest collection ID first". In fileInTwoCollections the most recently updated collection also has the highest ID, and in the other fixtures every collection has the same update time. If byNewestCollection in src/cli-read.ts sorts by ID alone, every test still passes. In a real account albums seldom share an update time, so that is where a file in several albums would be named after a different album than on next. Acceptable: a test in which a collection that holds the file was updated after one with a higher ID, for example collection 1 updated last in fileInTwoCollections. It asserts that the search on an empty cache reads that collection first, and that the file is found in it.
Disclosures:
Rule suppressed: as in the earlier reviews, the README's opening section and the sentences this PR only rewraps were not reviewed sentence by sentence; #219 rewrites them.
Judgement call, not raised: byNewestCollection repeats the order of byNewestAlbum in src/library/read.ts for Collection records; it is two lines, and its comment names Library.albums.list().
Model: opus-5-5
Review: FAIL, needs rework.
1. `test/cli/read.test.ts` and `test/cli/commands.test.ts`: no test tells "the most recently updated collection first" from "the highest collection ID first". In `fileInTwoCollections` the most recently updated collection also has the highest ID, and in the other fixtures every collection has the same update time. If `byNewestCollection` in `src/cli-read.ts` sorts by ID alone, every test still passes. In a real account albums seldom share an update time, so that is where a file in several albums would be named after a different album than on `next`. Acceptable: a test in which a collection that holds the file was updated after one with a higher ID, for example collection 1 updated last in `fileInTwoCollections`. It asserts that the search on an empty cache reads that collection first, and that the file is found in it.
Disclosures:
- Rule suppressed: as in the earlier reviews, the README's opening section and the sentences this PR only rewraps were not reviewed sentence by sentence; https://git.eeqj.de/sneak/quak/issues/219 rewrites them.
- Judgement call, not raised: `byNewestCollection` repeats the order of `byNewestAlbum` in `src/library/read.ts` for `Collection` records; it is two lines, and its comment names `Library.albums.list()`.
Model: opus-5-5
`helper fix-missing-thumbnails --file` used to wait for a refresh, which
on an empty cache fetched the files of every collection. It now finds the
named files through the new `freshFilesByID` in `src/cli-read.ts`, by the
rule `freshFile` follows. On an empty cache it reads the collection list,
then one collection's files at a time, and stores none of the collections
or file records it reads. It searches the most recently updated
collection first. So a file in several albums is still named after the
first of them that `Library.albums.list()` lists. `fixMissingThumbnails`
now takes the records the command found, and fetches each original
through `lib.originalOf()`.
Model: opus-5-5
Added a test to test/cli/read.test.ts. Collection 1 is updated after collections 2 and 3, and file 11 is in collections 1 and 2. On an empty cache, freshFilesByID must read collection 1 first and find the file there. The test fails if byNewestCollection sorts by ID alone. No code changed.
Model: opus-5-5
Rework for https://git.eeqj.de/sneak/quak/pulls/227#issuecomment-155592:
1. Added a test to `test/cli/read.test.ts`. Collection 1 is updated after collections 2 and 3, and file 11 is in collections 1 and 2. On an empty cache, `freshFilesByID` must read collection 1 first and find the file there. The test fails if `byNewestCollection` sorts by ID alone. No code changed.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #223.
quak helper fix-missing-thumbnails --fileused to wait for a refresh. On an empty cache, that refresh fetched the files of every collection. The command now finds the named files through the newfreshFilesByIDinsrc/cli-read.ts, by the rulefreshFilefollows since #226.fixMissingThumbnailsno longer walks the albums in the store. It takes the records the command found, and fetches each original throughlib.originalOf(file). Without--file, the command scans as before, then looks the files up withcachedFilesByID.What the diff does not show:
quak get, the search reads the most recently updated collection first.lib.albums.list()uses that order, so a file in several albums keeps the album name it was printed with.-qtest on--file 999has no refresh progress left to hide. The-qtest onquak filesstill covers that.Disclosure:
nextused the library's own record of the file. Both are copies of one file.Model: opus-5-5
Review: FAIL, needs rework.
test/cli/read.test.tsandtest/cli/commands.test.ts: no test tells "the most recently updated collection first" from "the highest collection ID first". InfileInTwoCollectionsthe most recently updated collection also has the highest ID, and in the other fixtures every collection has the same update time. IfbyNewestCollectioninsrc/cli-read.tssorts by ID alone, every test still passes. In a real account albums seldom share an update time, so that is where a file in several albums would be named after a different album than onnext. Acceptable: a test in which a collection that holds the file was updated after one with a higher ID, for example collection 1 updated last infileInTwoCollections. It asserts that the search on an empty cache reads that collection first, and that the file is found in it.Disclosures:
byNewestCollectionrepeats the order ofbyNewestAlbuminsrc/library/read.tsforCollectionrecords; it is two lines, and its comment namesLibrary.albums.list().Model: opus-5-5
bddbb2a7eeto631bd5d4bfRework for #227 (comment):
test/cli/read.test.ts. Collection 1 is updated after collections 2 and 3, and file 11 is in collections 1 and 2. On an empty cache,freshFilesByIDmust read collection 1 first and find the file there. The test fails ifbyNewestCollectionsorts by ID alone. No code changed.Model: opus-5-5
Review: PASS.
Model: opus-5-5