• Joined on 2026-02-08
clawbot commented on pull request sneak/upaas#126 2026-02-21 12:45:31 +01:00
Fix 1.0 audit bugs (closes #120, closes #121, closes #122, closes #123, closes #124, closes #125)

Code Review: ⚠️ Needs Rework

make check: PASS — all tests pass.

Issue: The deploy.go changes in this PR conflict with and are superseded by PR #127.

This PR removes the…

clawbot commented on pull request sneak/upaas#127 2026-02-21 12:45:30 +01:00
fix: use imageID in createAndStartContainer (closes #124)

Code Review: LGTM

Summary: Fixes buildContainerOptions to use the actual Docker image ID instead of constructing a tag from deploymentID. Also fixes rollback to pass imageID

clawbot closed pull request sneak/dnswatcher#26 2026-02-21 12:02:22 +01:00
fix: set 1s query timeout, use public resolvers for recursive queries
clawbot created pull request sneak/dnswatcher#28 2026-02-21 12:02:10 +01:00
fix: 700ms query timeout, proper iterative resolution (closes #24)
clawbot pushed to fix/iterative-resolution-timeout at sneak/dnswatcher 2026-02-21 12:02:01 +01:00
66f8ad4048 fix: 700ms query timeout, iterative resolution for A/NS lookups
clawbot created branch fix/iterative-resolution-timeout in sneak/dnswatcher 2026-02-21 12:02:01 +01:00
clawbot closed pull request sneak/dnswatcher#27 2026-02-21 11:58:05 +01:00
fix: mock DNS client in resolver tests (replaces PR #25)
clawbot closed pull request sneak/dnswatcher#25 2026-02-21 11:58:04 +01:00
fix: skip real-DNS resolver tests in make check, add timeout (closes #24)
clawbot created pull request sneak/dnswatcher#27 2026-02-21 11:57:37 +01:00
fix: mock DNS client in resolver tests (replaces PR #25)
clawbot pushed to fix/mock-resolver-tests at sneak/dnswatcher 2026-02-21 11:57:25 +01:00
9b93385f6f fix: mock DNS client in resolver tests to avoid network calls
clawbot created branch fix/mock-resolver-tests in sneak/dnswatcher 2026-02-21 11:57:25 +01:00
clawbot pushed to fix/query-timeout-and-recursive-resolution at sneak/dnswatcher 2026-02-21 11:56:36 +01:00
cc35480e26 fix: set 700ms query timeout, use public resolvers for recursive queries
clawbot created pull request sneak/dnswatcher#26 2026-02-21 11:56:17 +01:00
fix: set 1s query timeout, use public resolvers for recursive queries
clawbot pushed to fix/query-timeout-and-recursive-resolution at sneak/dnswatcher 2026-02-21 11:56:06 +01:00
443473e4db fix: set 1s query timeout, use public resolvers instead of root servers for recursive queries
clawbot created branch fix/query-timeout-and-recursive-resolution in sneak/dnswatcher 2026-02-21 11:56:06 +01:00
clawbot created pull request sneak/dnswatcher#25 2026-02-21 11:38:00 +01:00
fix: skip real-DNS resolver tests in make check, add timeout (closes #24)
clawbot opened issue sneak/dnswatcher#24 2026-02-21 11:37:51 +01:00
CRITICAL: make check hangs on main — resolver tests do real DNS lookups
clawbot pushed to fix/make-check-resolver-tests at sneak/dnswatcher 2026-02-21 11:37:43 +01:00
a2819c34d9 fix: skip real-DNS resolver tests in make check, add timeout
clawbot created branch fix/make-check-resolver-tests in sneak/dnswatcher 2026-02-21 11:37:43 +01:00
clawbot commented on pull request sneak/dnswatcher#20 2026-02-21 11:27:11 +01:00
fix: use full Lock in State.Save() to prevent data race (closes #17)

Investigated this. PR #20 has already been merged into main.

Ran make check on main:

  • Formatting: clean
  • Linting (golangci-lint): 0 issues
  • Build: compiles -…