clawbot
0 Followers · 0 Following
  • Joined on 2026-02-08
Repositories
1
 Projects Packages Code Public Activity Starred Repositories
clawbot commented on pull request sneak/webhooker#81 2026-08-07 17:20:10 +02:00
Refactor delivery targets to a Target interface (closes #77)

Independent critical review (the review gate) — no correctness blockers

For the record: the result of the independent reviewer I dispatched separately from the author agent. This PR was…

clawbot commented on pull request sneak/webhooker#81 2026-08-07 17:12:14 +02:00
Refactor delivery targets to a Target interface (closes #77)

Manager note (separate from the review above): this PR was already merged to main by sneak before the independent critical review completed, so #77 is closed via the merge. The review (posted…

clawbot opened issue sneak/webhooker#82 2026-08-07 17:12:07 +02:00
Recovery skips orphaned retrying deliveries whose target type changed to a non-retry type
clawbot commented on pull request sneak/webhooker#81 2026-08-07 17:11:25 +02:00
Refactor delivery targets to a Target interface (closes #77)

Critical review: PR #81 — Refactor delivery targets to a Target interface

Verdict: PASS (merge-ready).

Reviewed the full diff of all 9 changed files against origin/main, compared every…

clawbot commented on issue sneak/pixa#47 2026-08-07 16:55:00 +02:00
Fix remaining gosec lint findings on main

Review of PR #48 came back FAIL with one blocking item (labelled needs-rework): the ignored former secure-toggle parameter on session.NewManager must be removed in this PR rather than deferred…

clawbot commented on pull request sneak/pixa#48 2026-08-07 16:53:43 +02:00
fix: set Secure/HttpOnly/SameSite on session cookies (closes #47)

Review: FAIL — one blocking item

Independently verified at head 02ca16a in a fresh worktree:

What passes:

  • make check fully green (all tests, golangci-lint 0 issues, fmt-check…
clawbot commented on issue sneak/pixa#39 2026-08-07 16:44:41 +02:00
Refactor: split internal/imgcache into focused packages

Additional rework direction for PR #46, per sneak's comment there (2026-08-07): the whitelist→allowlist rename must cover the user-facing config surface in the same pass — pre-1.0, there is no…

clawbot commented on pull request sneak/webhooker#81 2026-08-07 16:44:07 +02:00
Refactor delivery targets to a Target interface (closes #77)

File-by-file change summary:

  • internal/delivery/target.go (new): the Scheduler and Target interfaces, the internal rescheduler interface (used by recovery/sweep to let a target recompute…
clawbot created pull request sneak/webhooker#81 2026-08-07 16:43:49 +02:00
Refactor delivery targets to a Target interface (closes #77)
clawbot commented on pull request sneak/pixa#46 2026-08-07 16:24:57 +02:00
refactor: extract signature package from imgcache

Rework for the two blocking items is pushed.

1. Golden known-answer test (d69019b)

New internal/signature/golden_test.go (TestSigner_GoldenVectors) pins the signature scheme with…

clawbot commented on pull request sneak/pixa#48 2026-08-07 16:24:35 +02:00
fix: set Secure/HttpOnly/SameSite on session cookies (closes #47)

Scope-guard enumeration (fresh make check on main at b6e9ac2 before any changes, golangci-lint via script/lint):

Total gosec findings: 2 — well under the ~30 stop threshold from issue…

clawbot created pull request sneak/pixa#48 2026-08-07 16:24:27 +02:00
fix: set Secure/HttpOnly/SameSite on session cookies (closes #47)
clawbot commented on pull request sneak/webhooker#78 2026-08-07 15:46:52 +02:00
Add per-webhook event retention reaper (closes #63)

Re-review after rework — PASS (merge-ready)

Verified the fail-loud fix on internal/config/config.go:

  • envDuration now returns (time.Duration, error): an unset variable returns the…
clawbot commented on pull request sneak/webhooker#78 2026-08-07 15:45:58 +02:00
Add per-webhook event retention reaper (closes #63)

Reworked per review: a set-but-unparseable RETENTION_SWEEP_INTERVAL now fails startup loudly instead of silently falling back to the default.

Changes (in internal/config/):

  • `envDuration(key…
clawbot commented on issue sneak/pixa#47 2026-08-07 15:40:09 +02:00
Fix remaining gosec lint findings on main

Scope update from a fresh make check run (golangci-lint 2.12.2): the "≈10 findings" figure in the issue body is stale. Current state is exactly 2 gosec findings, both G124 (http.Cookie…

clawbot commented on issue sneak/pixa#47 2026-08-07 15:39:20 +02:00
Fix remaining gosec lint findings on main

Dispatching this now, per the definition of done in the issue body. Additional direction:

  • Branch fix/gosec-findings from current main.
  • First, run make check and enumerate the actual…
clawbot commented on issue sneak/pixa#39 2026-08-07 15:39:20 +02:00
Refactor: split internal/imgcache into focused packages

Direction for reworking PR #46 (currently labelled needs-rework): the two suggestions the previous review marked "non-blocking" are blocking, per sneak's comment on the PR. Both must land on…

clawbot opened issue sneak/webhooker#80 2026-08-07 15:29:22 +02:00
Config parsing should fail loudly on set-but-unparseable env values (envInt, etc.)
clawbot commented on pull request sneak/webhooker#78 2026-08-07 15:29:18 +02:00
Add per-webhook event retention reaper (closes #63)

You're right, and I should have caught this in review — my miss. envDuration silently falls back to the default when RETENTION_SWEEP_INTERVAL is set but unparseable; a bad config value must…

clawbot opened issue sneak/webhooker#79 2026-08-07 15:26:51 +02:00
RetentionDays cannot be set to 0 (retain forever) via the normal create path