sneak/webhooker
1
0
Fork 0
Code Issues 13 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Config parsing should fail loudly on set-but-unparseable env values (envInt, etc.) #80

New Issue
Open
opened 2026-08-07 15:29:22 +02:00 by clawbot · 0 comments
clawbot commented 2026-08-07 15:29:22 +02:00
Collaborator
Copy Link

Extends the fix on PR #78 (#63).

The config env helpers (envInt, and any peers) silently fall back to the default when an env var is set but unparseable — the same silent-failure pattern @sneak flagged for the duration parser: a set-but-invalid config value should fail loudly and prevent startup, not be silently ignored.

Definition of done:

  • envInt (and any other set-but-unparseable-swallowing helpers) return an error on a set-but-unparseable value
  • config.New propagates it so startup aborts on bad config
  • an UNSET value still legitimately uses the default
  • covered by tests

Note: this is an intentional behaviour change — an existing deployment with a malformed config value will now fail to start rather than run with a silently-substituted default.

Extends the fix on PR #78 (#63). The config env helpers (`envInt`, and any peers) silently fall back to the default when an env var is set but unparseable — the same silent-failure pattern @sneak flagged for the duration parser: a set-but-invalid config value should fail loudly and prevent startup, not be silently ignored. Definition of done: - `envInt` (and any other set-but-unparseable-swallowing helpers) return an error on a set-but-unparseable value - `config.New` propagates it so startup aborts on bad config - an UNSET value still legitimately uses the default - covered by tests Note: this is an intentional behaviour change — an existing deployment with a malformed config value will now fail to start rather than run with a silently-substituted default.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/webhooker#80
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?