Session-handoff status: the test pass was fully executed and all six checks passed (plus all nine scripts/manual-test.sh checks). The implementor was stopped right before committing, so the…
Status checkpoint (session handoff — a fresh session will pick up from the tracker):
- PR #46 (
signatureextraction + full whitelist→allowlist rename including theallowlist_hostsconfig…
Independent review — one required change before merge-ready
The archive mechanics are correct and well-tested; one behaviour needs fixing before this goes to @sneak.
Verified solid:
-…
File-by-file summary
internal/delivery/target_database.go—databaseTargetnow holds a per-webhookarchiveWriterregistry (guarded by a mutex, lazily populated).Deliverarchives…
Independent review — PASS (merge-ready)
Adversarial review against the issue spec and repo policies.
- Route:
POST /passwordadded under/user/{username}insetupUserRoutes, inheriting…
File-by-file summary:
internal/server/routes.go: addedr.Post("/password", s.h.HandlePasswordChange())tosetupUserRoutes, so it inherits the group'sCSRF,NoCache, andRequireAuth…
Closing per the decision above: main keeps the responsive mobile layout from #5, so the "not available on mobile" approach in this PR is rejected. No code from this branch will be merged.
Follow…
Dispatching an implementor now. Direction:
- Branch
test/manual-auth-flow-passfrom currentmain(6573b9d), in a worktree. - Build with
make build; run./bin/pixadwith a purpose-made…
Re-review: PASS
Reviewed at head 3dc1999 (6526b71 + golden test d69019b + imgcache rename 43b9f1c + config-key rename 3dc1999). All verification independent of the implementor's…
Re-review: PASS
Verified at head cb9e14e in a fresh worktree with an isolated lint cache: make check fully green (all tests, golangci-lint 0 issues, fmt-check clean) — independently run,…
Done — the config surface is renamed in this PR as directed, one pass, no
back-compat alias, no deprecation window. Commit 3dc1999.
Changes:
- YAML key
whitelist_hosts->allowlist_hosts…
Rework for the blocking item is pushed: cb9e14e.
session.NewManagernow takes only the signing key:NewManager(signingKey string). The ignored_ boolparameter and the "retained only so…
Implementation instructions
routes.go is free again (the interface refactor merged), so implement the admin password-change flow.
Scope: internal/handlers/profile.go (or a new handler…
Implementation instructions
The Target interface (#77) is now merged, so implement this as the databaseTarget implementation.
Authoritative spec (from @sneak on this issue): the database…