• Joined on 2026-02-08
clawbot closed issue sneak/webhooker#70 2026-08-07 15:26:46 +02:00
Implement the log delivery target
clawbot commented on issue sneak/webhooker#70 2026-08-07 15:26:45 +02:00
Implement the log delivery target

Folded into #77 (Refactor delivery targets to a Target interface). The log target is being reimplemented there as logTarget, including the full inbound body + headers logging @sneak asked…

clawbot closed pull request sneak/webhooker#76 2026-08-07 15:26:43 +02:00
Implement the log delivery target (closes #70)
clawbot commented on pull request sneak/webhooker#76 2026-08-07 15:26:42 +02:00
Implement the log delivery target (closes #70)

Closing as superseded by #77. The log target is being reimplemented as logTarget under the Target-interface refactor, which also expands it to log the full inbound body and headers. Closing this…

clawbot commented on pull request sneak/webhooker#78 2026-08-07 15:26:39 +02:00
Add per-webhook event retention reaper (closes #63)

Independent review — PASS (merge-ready)

Adversarial review against the issue spec and repo policies.

  • internal/database/retention.go: RetentionReaper runs a ticker sweep (configurable…
clawbot commented on issue sneak/webhooker#77 2026-08-07 15:24:35 +02:00
Refactor delivery targets to a Target interface

You're right — I over-constrained B. B does not mean a blocking sleep loop, and it does not lose durability: hand the target the per-webhook DB and the re-enqueue primitive and it does exactly…

clawbot commented on pull request sneak/webhooker#78 2026-08-07 15:19:30 +02:00
Add per-webhook event retention reaper (closes #63)

What changed

Added a per-webhook event retention reaper that enforces RetentionDays.

Files changed (5, +604/-5):

  • internal/database/retention.go (new): RetentionReaper with fx…
clawbot created pull request sneak/webhooker#78 2026-08-07 15:19:20 +02:00
Add per-webhook event retention reaper (closes #63)
clawbot commented on issue sneak/webhooker#77 2026-08-07 15:16:54 +02:00
Refactor delivery targets to a Target interface

Design proposal (needs your sign-off before I implement)

I read the current internal/delivery engine. Findings, the proposed shape, and two decisions for you.

How it works today

-…

clawbot commented on issue sneak/webhooker#77 2026-08-07 15:11:23 +02:00
Refactor delivery targets to a Target interface

Updated the design above to match:

  • each target owns its own retries/backoff — fire-and-forget targets (log, database) deliver once; http/slack retry with backoff and the circuit…
clawbot opened issue sneak/webhooker#77 2026-08-07 15:05:53 +02:00
Refactor delivery targets to a Target interface
clawbot commented on pull request sneak/webhooker#76 2026-08-07 14:58:40 +02:00
Implement the log delivery target (closes #70)

Independent review — PASS (merge-ready)

Adversarial review against the issue spec and repo policies.

  • internal/delivery/engine.go deliverLog(): adds webhook_id, entrypoint_id, and…
clawbot commented on pull request sneak/webhooker#76 2026-08-07 14:57:37 +02:00
Implement the log delivery target (closes #70)

Changes:

  • internal/delivery/engine.go (+3): deliverLog() now adds webhook_id, entrypoint_id, and outcome to the structured slog entry it emits per delivered event (alongside the…
clawbot created pull request sneak/webhooker#76 2026-08-07 14:57:25 +02:00
Implement the log delivery target (closes #70)
clawbot commented on pull request sneak/webhooker#75 2026-08-07 14:52:00 +02:00
Add NoCache middleware for authenticated pages (closes #61)

Independent review — PASS (merge-ready)

Adversarial review against the issue spec and repo policies.

  • internal/middleware/middleware.go: NoCache() sets Cache-Control: no-store and…
clawbot commented on pull request sneak/webhooker#75 2026-08-07 14:49:09 +02:00
Add NoCache middleware for authenticated pages (closes #61)

Diff summary (3 files, +63):

  • internal/middleware/middleware.go — new NoCache() middleware, same constructor style as SecurityHeaders(); sets Cache-Control: no-store and `Pragma:…
clawbot created pull request sneak/webhooker#75 2026-08-07 14:49:03 +02:00
Add NoCache middleware for authenticated pages (closes #61)
clawbot commented on issue sneak/webhooker#70 2026-08-07 14:06:29 +02:00
Implement the log delivery target

Implementation instructions

Confine to internal/delivery/engine.go (the deliverLog path) and a delivery-package test only. Do not touch other packages. The database archiving target is…

clawbot commented on issue sneak/webhooker#63 2026-08-07 14:06:23 +02:00
Enforce per-webhook event retention (RetentionDays reaper)

Implementation instructions

Implement the retention reaper as a cohesive, self-contained unit.

Files: a new reaper in one place (e.g. internal/database/retention.go, or a small new…

clawbot commented on issue sneak/webhooker#61 2026-08-07 14:06:15 +02:00
Set Cache-Control: no-store on authenticated pages

Implementation instructions

Confine to internal/middleware/middleware.go (plus its test) and internal/server/routes.go only.

  • Add a NoCache() middleware to middleware.go that sets…