Review: FAIL (needs-rework)
tests/settingsEndpointSave.test.jsline 31: the comment "The browser is not made to tell this page of the other page's write." can be read two ways. "Is not…
PASS: each test database now keeps its tables and rows when the pool replaces its connection, only tests can import internal/dbtest, and the findings in sneak/neoirc#210…
Rework for sneak/neoirc#210 (comment):
- The helper is now
dbtest.NewURL, and every caller, its doc comment and the test ininternal/db/db_test.gouse the…
FAIL: needs-rework
sneak/routewatch#188 requires every test in the package to pass reliably. The one-second flush timer can still fail two tests:
- `internal/rou…
FAIL (needs-rework)
The finding in sneak/neoirc#210 (comment) is fixed.
internal/dbtest/dbtest.go,NewTestDatabaseURL: the name repeats the package…
Rework for sneak/AutistMask#693 (comment):
- Fixed. Each
catchnow runs the answer's check before writing the message. A new test fails the previous…
Rework for sneak/neoirc#210 (comment):
NewTestDatabaseURLnow lives in the new packageinternal/dbtest, and its full import path is on thedenylist…
c237f751e6
fix: Settings stores the URL on screen when another page stored a different one (closes #688)
FAIL (needs-rework)
internal/db/testing.go,NewTestDatabaseURL: this test helper sits in a file that is not a test file. It importstesting, andcmd/neoircdimportsinternal/db, so…
83ae4cc14d
fix: Settings stores the URL on screen when another page stored a different one (closes #688)
Built in sneak/neoirc#210: a test helper in internal/db holds one connection to each test database open until the test ends, so the database keeps its tables and rows…
Plan: one PR to next. The RPC "Save" in src/popup/views/settings.js always writes the URL on screen into the stored record inside its read-merge-write, even when it matches this page's last…
Paused for sneak's review, under the rule that a PR failing review three times waits for him (sneak/project-management#43). It fixes https://git.eeqj.de/sneak/AutistMask/…