Restore silently continues when individual file restoration fails #21

Open
opened 2026-02-08 17:16:56 +01:00 by clawbot · 0 comments
Collaborator

In restore.go Restore(), file restore errors are logged but skipped:

if err := v.restoreFile(...); err != nil {
    log.Error("Failed to restore file", "path", file.Path, "error", err)
    continue
}

The final result does not report how many files failed, and the function returns nil (success) even if files failed. Should track failed files and report them, similar to how verify tracks FilesFailed.

Ref: parent issue #1

In `restore.go` `Restore()`, file restore errors are logged but skipped: ```go if err := v.restoreFile(...); err != nil { log.Error("Failed to restore file", "path", file.Path, "error", err) continue } ``` The final result does not report how many files failed, and the function returns nil (success) even if files failed. Should track failed files and report them, similar to how verify tracks `FilesFailed`. Ref: parent issue #1
clawbot was assigned by sneak 2026-02-08 17:31:34 +01:00
Sign in to join this conversation.
No Label
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sneak/vaultik#21
No description provided.