uploads table FK on snapshot_id lacks ON DELETE CASCADE #18

New Issue

clawbot · 2026-02-08T17:16:54+01:00

clawbot commented

2026-02-08 17:16:54 +01:00

In schema.sql, the uploads table has:

FOREIGN KEY (snapshot_id) REFERENCES snapshots(id)

Unlike snapshot_files and snapshot_blobs which have ON DELETE CASCADE, the uploads FK does not cascade. This means deleting a snapshot without first deleting its uploads will fail with a FK violation (if FK enforcement is on). The code works around this by manually deleting uploads first in deleteSnapshotFromLocalDB, but syncWithRemote does NOT do this cleanup.

Ref: parent issue #1

In `schema.sql`, the `uploads` table has: ```sql FOREIGN KEY (snapshot_id) REFERENCES snapshots(id) ``` Unlike `snapshot_files` and `snapshot_blobs` which have `ON DELETE CASCADE`, the `uploads` FK does not cascade. This means deleting a snapshot without first deleting its uploads will fail with a FK violation (if FK enforcement is on). The code works around this by manually deleting uploads first in `deleteSnapshotFromLocalDB`, but `syncWithRemote` does NOT do this cleanup. Ref: parent issue #1

clawbot referenced this issue

2026-02-08 17:17:10 +01:00

find bugs or incomplete functionality for 1.0 #1

clawbot self-assigned this 2026-02-20 09:29:00 +01:00

clawbot added the needs-review label 2026-02-20 09:29:00 +01:00

clawbot referenced this issue from a commit

2026-03-17 13:48:45 +01:00

fix: add ON DELETE CASCADE to uploads FK on snapshot_id

clawbot referenced this issue

2026-03-17 13:48:49 +01:00

fix: add ON DELETE CASCADE to uploads FK on snapshot_id #44

clawbot referenced this issue