Block a user
Bug: NumSecrets() always returns 0 due to incorrect directory traversal
Bug: getLongTermPrivateKey hardcodes derivation index 0 for mnemonic path
Bug: FindExtraFiles reports manifest file and dotfiles as extra
Bug: newTimestampFromTime panics on dates outside ~1678-2262 due to UnixNano overflow
Bug: IsHiddenPath(".") returns true, incorrectly treating current directory as hidden
Bug: fetch command does not URL-encode file paths, breaking files with special characters
Bug: errors.Is with errors.New() never matches in checker file-not-found detection
Unbounded blob cache during restore can exhaust memory
CompressStream double-closes the blobgen.Writer causing potential errors
SQL injection risk in getTableCount via fmt.Sprintf table name interpolation
Multiple methods write to os.Stdout instead of v.Stdout, breaking testability
deleteSnapshotFromLocalDB silently swallows all errors and always returns nil
please provide a detailed and critical design review of this format and implementation
Created TODO.md on a branch off next with 10 design questions (with answer placeholders) and a 22-item phased implementation plan.
PR: sneak/mfer#11
Once you answer…
please provide a detailed and critical design review of this format and implementation
Created TODO.md on the next branch with:
- 14 design questions at the top (numbered, with space for inline answers)
- **22-item…
docs: add TODO.md with design questions and 1.0 implementation plan
please provide a detailed and critical design review of this format and implementation
Revised Design Review: mfer (
Revised Design Review: mfer (next branch)
Reviewed: all source on next branch, including protobuf schema, mfer/ package, internal/ packages, CLI, and tests.
1. Format Design…
fix: JSONHandler deadlock from recursive log.Println (closes #3)
I wrote a regression test for this deadlock bug (see PR #7). The test reproduces the issue by calling slog.Info() with JSONHandler as the default handler and using a 5-second timeout to detect…