In the target list on the webhook page, a slack target now shows its retry setting next to its masked webhook URL: "Max Retries" with the number, or "0 (fire-and-forget)" for zero. The line is built by the same code an http target uses, so the label and wording cannot drift apart. Before this, a slack target showed only its masked webhook URL, though its edit page saves retries and delivery honours them.
slackConfigFields now takes the target row instead of its configuration text, because the retry setting is stored on the row. A slack target shows no queue size even when one is stored, since delivery never reads it; an http target still shows one as before.
Every slack target in the list now has a "Max Retries" line, including those left at zero.
Judgement call: the deleted-target test now checks that a deleted slack target's fields equal a live one's, instead of repeating the literal list a third time.
Model: opus-5-5
In the target list on the webhook page, a `slack` target now shows its retry setting next to its masked webhook URL: "Max Retries" with the number, or "0 (fire-and-forget)" for zero. The line is built by the same code an `http` target uses, so the label and wording cannot drift apart. Before this, a `slack` target showed only its masked webhook URL, though its edit page saves retries and delivery honours them.
`slackConfigFields` now takes the target row instead of its configuration text, because the retry setting is stored on the row. A `slack` target shows no queue size even when one is stored, since delivery never reads it; an `http` target still shows one as before.
Every `slack` target in the list now has a "Max Retries" line, including those left at zero.
Judgement call: the deleted-target test now checks that a deleted `slack` target's fields equal a live one's, instead of repeating the literal list a third time.
Model: opus-5-5
internal/delivery/target_config_view.go, slackConfigFields: it appends the whole of retryFields, so a slack target with a queue size stored shows a "Max Queue Size" line. The delivery engine never reads a target's queue size (the README's max_queue_size row says so too), so the line shows a setting that does nothing for a slack target. The new test TestNewTargetViews_SlackRetries asserts that line, and the PR body says the list shows it. Acceptable: a slack target shows "Webhook URL" and "Max Retries" only. The "Max Retries" line comes from the same code the http target uses, so the label and the "0 (fire-and-forget)" wording cannot drift apart. The test stores a queue size on the slack target and checks that no "Max Queue Size" line appears. The PR body drops the queue-size claim.
Model: opus-5-5
Review: FAIL (needs-rework)
1. `internal/delivery/target_config_view.go`, `slackConfigFields`: it appends the whole of `retryFields`, so a `slack` target with a queue size stored shows a "Max Queue Size" line. The delivery engine never reads a target's queue size (the README's `max_queue_size` row says so too), so the line shows a setting that does nothing for a `slack` target. The new test `TestNewTargetViews_SlackRetries` asserts that line, and the PR body says the list shows it. Acceptable: a `slack` target shows "Webhook URL" and "Max Retries" only. The "Max Retries" line comes from the same code the `http` target uses, so the label and the "0 (fire-and-forget)" wording cannot drift apart. The test stores a queue size on the `slack` target and checks that no "Max Queue Size" line appears. The PR body drops the queue-size claim.
Model: opus-5-5
The target list showed only the masked webhook URL for a slack
target, though its edit page saves a retry setting and delivery
honours it. It now shows the "Max Retries" line, built by the same
code as an http target's. It shows no queue size: delivery never
reads one.
Model: opus-5-5
A slack target now shows only "Webhook URL" and "Max Retries". The "Max Retries" line comes from one function that the http target also uses, so its label and the "0 (fire-and-forget)" wording are shared. The queue-size line is now added only by the http target. The test now stores a queue size on the slack target and checks that no "Max Queue Size" line appears. The PR body no longer claims that a queue size is shown.
Model: opus-5-5
A `slack` target now shows only "Webhook URL" and "Max Retries". The "Max Retries" line comes from one function that the `http` target also uses, so its label and the "0 (fire-and-forget)" wording are shared. The queue-size line is now added only by the `http` target. The test now stores a queue size on the `slack` target and checks that no "Max Queue Size" line appears. The PR body no longer claims that a queue size is shown.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
In the target list on the webhook page, a
slacktarget now shows its retry setting next to its masked webhook URL: "Max Retries" with the number, or "0 (fire-and-forget)" for zero. The line is built by the same code anhttptarget uses, so the label and wording cannot drift apart. Before this, aslacktarget showed only its masked webhook URL, though its edit page saves retries and delivery honours them.slackConfigFieldsnow takes the target row instead of its configuration text, because the retry setting is stored on the row. Aslacktarget shows no queue size even when one is stored, since delivery never reads it; anhttptarget still shows one as before.Every
slacktarget in the list now has a "Max Retries" line, including those left at zero.Judgement call: the deleted-target test now checks that a deleted
slacktarget's fields equal a live one's, instead of repeating the literal list a third time.Model: opus-5-5
Review: FAIL (needs-rework)
internal/delivery/target_config_view.go,slackConfigFields: it appends the whole ofretryFields, so aslacktarget with a queue size stored shows a "Max Queue Size" line. The delivery engine never reads a target's queue size (the README'smax_queue_sizerow says so too), so the line shows a setting that does nothing for aslacktarget. The new testTestNewTargetViews_SlackRetriesasserts that line, and the PR body says the list shows it. Acceptable: aslacktarget shows "Webhook URL" and "Max Retries" only. The "Max Retries" line comes from the same code thehttptarget uses, so the label and the "0 (fire-and-forget)" wording cannot drift apart. The test stores a queue size on theslacktarget and checks that no "Max Queue Size" line appears. The PR body drops the queue-size claim.Model: opus-5-5
d0fe433d31to67410ec9f8A
slacktarget now shows only "Webhook URL" and "Max Retries". The "Max Retries" line comes from one function that thehttptarget also uses, so its label and the "0 (fire-and-forget)" wording are shared. The queue-size line is now added only by thehttptarget. The test now stores a queue size on theslacktarget and checks that no "Max Queue Size" line appears. The PR body no longer claims that a queue size is shown.Model: opus-5-5
Review: PASS.
Model: opus-5-5