audit the whole app for stupid cases of missing functionality or basic things like this (like the stats panel at the top that i requested).
What is wrong: the edit page of a slack target offers "Max retries" and saves it, and the delivery engine honours it. But the target list on the webhook page shows only the masked URL for a slack target (slackConfigFields in internal/delivery/target_config_view.go), while an http target shows its retry setting. In the audit, setting a slack target's retries to 2 changed nothing visible.
The add form offers no retry field for this type either. That part belongs to the per-type form of #370.
Definition of done:
In the target list, a slack target shows its retry setting exactly as an http target does.
Test: a slack target with retries set shows them in the list.
PRIORITY: from the owner's audit request of 1 October (#377), in the tier of #367 to #376.
Model: opus-5-5
Owner's request, https://git.eeqj.de/sneak/webhooker/issues/377 (chat, 2026-10-01):
> audit the whole app for stupid cases of missing functionality or basic things like this (like the stats panel at the top that i requested).
What is wrong: the edit page of a `slack` target offers "Max retries" and saves it, and the delivery engine honours it. But the target list on the webhook page shows only the masked URL for a `slack` target (`slackConfigFields` in `internal/delivery/target_config_view.go`), while an `http` target shows its retry setting. In the audit, setting a `slack` target's retries to 2 changed nothing visible.
The add form offers no retry field for this type either. That part belongs to the per-type form of https://git.eeqj.de/sneak/webhooker/issues/370.
Definition of done:
- In the target list, a `slack` target shows its retry setting exactly as an `http` target does.
- Test: a `slack` target with retries set shows them in the list.
PRIORITY: from the owner's audit request of 1 October (https://git.eeqj.de/sneak/webhooker/issues/377), in the tier of https://git.eeqj.de/sneak/webhooker/issues/367 to https://git.eeqj.de/sneak/webhooker/issues/376.
Model: opus-5-5
clawbot
self-assigned this 2026-10-01 22:06:25 +02:00
Plan. In slackConfigFields (internal/delivery/target_config_view.go), show the retry setting exactly as the http target's fields do, with the same label and the same wording for zero. A test: a slack target with retries set shows them in the target list. Nothing else changes.
Model: opus-5-5
Plan. In `slackConfigFields` (`internal/delivery/target_config_view.go`), show the retry setting exactly as the `http` target's fields do, with the same label and the same wording for zero. A test: a `slack` target with retries set shows them in the target list. Nothing else changes.
Model: opus-5-5
#475: in the target list, a slack target now shows "Max Retries" (and "Max Queue Size" when set) exactly as an http target does, zero shown as "0 (fire-and-forget)". A test covers a slack target with retries set.
Judgement call: the deleted-target test now checks that a deleted slack target's fields equal a live one's rather than repeating the literal list.
Model: opus-5-5
https://git.eeqj.de/sneak/webhooker/pulls/475: in the target list, a `slack` target now shows "Max Retries" (and "Max Queue Size" when set) exactly as an `http` target does, zero shown as "0 (fire-and-forget)". A test covers a `slack` target with retries set.
Judgement call: the deleted-target test now checks that a deleted `slack` target's fields equal a live one's rather than repeating the literal list.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Owner's request, #377 (chat, 2026-10-01):
What is wrong: the edit page of a
slacktarget offers "Max retries" and saves it, and the delivery engine honours it. But the target list on the webhook page shows only the masked URL for aslacktarget (slackConfigFieldsininternal/delivery/target_config_view.go), while anhttptarget shows its retry setting. In the audit, setting aslacktarget's retries to 2 changed nothing visible.The add form offers no retry field for this type either. That part belongs to the per-type form of #370.
Definition of done:
slacktarget shows its retry setting exactly as anhttptarget does.slacktarget with retries set shows them in the list.PRIORITY: from the owner's audit request of 1 October (#377), in the tier of #367 to #376.
Model: opus-5-5
Plan. In
slackConfigFields(internal/delivery/target_config_view.go), show the retry setting exactly as thehttptarget's fields do, with the same label and the same wording for zero. A test: aslacktarget with retries set shows them in the target list. Nothing else changes.Model: opus-5-5
#475: in the target list, a
slacktarget now shows "Max Retries" (and "Max Queue Size" when set) exactly as anhttptarget does, zero shown as "0 (fire-and-forget)". A test covers aslacktarget with retries set.Judgement call: the deleted-target test now checks that a deleted
slacktarget's fields equal a live one's rather than repeating the literal list.Model: opus-5-5