An http target's max_queue_size is stored and shown but nothing enforces it #477

New Issue

2026-10-03T00:01:40+02:00

clawbot commented

2026-10-03 00:01:40 +02:00

An http target's max_queue_size is stored, accepted on its forms and shown in the target list as "Max Queue Size", but nothing in the delivery engine reads it. The README's target configuration table says so ("Stored and shown on the target's detail view, but not enforced anywhere yet"). An operator who sets it expecting deliveries to that target to be bounded gets nothing, the same trap #317 removed for MAINTENANCE_MODE. Found by the review of #475.

Definition of done

max_queue_size is removed from the target configuration, its forms, its validation, the target list and the README, together with anything that exists only for it.
A leftover value in a stored target's configuration is ignored.
Tests that set or check it are removed or adjusted; nothing else changes.

Model: opus-5-5

An `http` target's `max_queue_size` is stored, accepted on its forms and shown in the target list as "Max Queue Size", but nothing in the delivery engine reads it. The README's target configuration table says so ("Stored and shown on the target's detail view, but not enforced anywhere yet"). An operator who sets it expecting deliveries to that target to be bounded gets nothing, the same trap https://git.eeqj.de/sneak/webhooker/issues/317 removed for `MAINTENANCE_MODE`. Found by the review of https://git.eeqj.de/sneak/webhooker/pulls/475. ## Definition of done - `max_queue_size` is removed from the target configuration, its forms, its validation, the target list and the README, together with anything that exists only for it. - A leftover value in a stored target's configuration is ignored. - Tests that set or check it are removed or adjusted; nothing else changes. Model: opus-5-5

clawbot commented

2026-10-03 01:16:42 +02:00

Plan. Remove max_queue_size everywhere it appears on next: the http target's configuration, its add and edit form fields and their validation, the target list's "Max Queue Size" line, the README's configuration table row, and anything that exists only for it. A leftover value in a stored target's configuration is ignored by the decoder; nothing is added to detect or warn about it. Tests that set or check it are removed or adjusted. Nothing else changes.

Model: opus-5-5

Plan. Remove `max_queue_size` everywhere it appears on `next`: the `http` target's configuration, its add and edit form fields and their validation, the target list's "Max Queue Size" line, the README's configuration table row, and anything that exists only for it. A leftover value in a stored target's configuration is ignored by the decoder; nothing is added to detect or warn about it. Tests that set or check it are removed or adjusted. Nothing else changes. Model: opus-5-5

clawbot referenced this issue from a commit

2026-10-03 01:24:08 +02:00

Remove an http target's max_queue_size (closes #477)

clawbot referenced a pull request that will close this issue

2026-10-03 01:24:21 +02:00

Remove an http target's max_queue_size (closes #477) #481

clawbot commented

2026-10-03 01:24:26 +02:00

#481 removes an http target's max_queue_size: the field on the target, the "Max Queue Size" line in the target list, the README's target table row, and its use in two view tests. Nothing checks for a leftover value. An existing database keeps its old column, which is no longer read, so no database needs recreating.

Judgement call: on next neither target form had a max_queue_size field or any validation for it, so there was nothing to remove there.
Judgement call: the README table's first column keeps its old padding rather than re-padding every row.

Model: opus-5-5

https://git.eeqj.de/sneak/webhooker/pulls/481 removes an `http` target's `max_queue_size`: the field on the target, the "Max Queue Size" line in the target list, the README's target table row, and its use in two view tests. Nothing checks for a leftover value. An existing database keeps its old column, which is no longer read, so no database needs recreating. - Judgement call: on `next` neither target form had a `max_queue_size` field or any validation for it, so there was nothing to remove there. - Judgement call: the README table's first column keeps its old padding rather than re-padding every row. Model: opus-5-5

clawbot closed this issue

2026-10-03 01:39:13 +02:00

clawbot referenced this issue

2026-10-03 01:39:14 +02:00

Milestone: next into main #380

clawbot referenced this issue from a commit

2026-10-03 01:39:15 +02:00

Remove an http target's max_queue_size (closes #477)

Sign in to join this conversation.