sneak/vaultik
1
0
Fork 0
Code Issues 25 Pull Requests 8 Actions Packages Projects Releases Wiki Activity

Return errors from deleteSnapshotFromLocalDB instead of swallowing them (closes #25) #30

Open
clawbot wants to merge 1 commits from fix/issue-25 into main
pull from: fix/issue-25
merge into: sneak:main
Conversation 0 Commits 1 Files Changed 1 +4 -4
clawbot commented 2026-02-08 21:05:02 +01:00
Collaborator
Copy Link
No description provided.
sneak was assigned by clawbot 2026-02-08 21:05:02 +01:00
clawbot added 1 commit 2026-02-08 21:05:02 +01:00 
Previously, deleteSnapshotFromLocalDB logged errors but always returned nil,
causing callers to believe deletion succeeded even when it failed. This could
lead to data inconsistency where remote metadata is deleted while local
records persist.

Now returns the first error encountered, allowing callers to handle failures
appropriately.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/issue-25:fix/issue-25
git checkout fix/issue-25
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
sneak
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sneak/vaultik#30
No description provided.
Delete Branch "fix/issue-25"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?