deleteSnapshotFromLocalDB silently swallows all errors and always returns nil #25

New Issue

clawbot · 2026-02-08T21:01:07+01:00

clawbot commented

2026-02-08 21:01:07 +01:00

Bug

deleteSnapshotFromLocalDB in internal/vaultik/snapshot.go logs errors but always returns nil, even when every operation fails. Callers (including PurgeSnapshots and PruneDatabase) assume success and proceed, potentially leaving the database in an inconsistent state.

func (v *Vaultik) deleteSnapshotFromLocalDB(snapshotID string) error {
    // ... all errors are logged but swallowed ...
    return nil
}

Impact

PurgeSnapshots reports successful deletion even when the database still contains the snapshot
RemoveSnapshot tells the user the snapshot was removed when it may not have been
Remote metadata could be deleted while local records persist, causing sync inconsistencies

Fix

Return the first error encountered instead of swallowing all errors.

## Bug `deleteSnapshotFromLocalDB` in `internal/vaultik/snapshot.go` logs errors but always returns `nil`, even when every operation fails. Callers (including `PurgeSnapshots` and `PruneDatabase`) assume success and proceed, potentially leaving the database in an inconsistent state. ```go func (v *Vaultik) deleteSnapshotFromLocalDB(snapshotID string) error { // ... all errors are logged but swallowed ... return nil } ``` ## Impact - `PurgeSnapshots` reports successful deletion even when the database still contains the snapshot - `RemoveSnapshot` tells the user the snapshot was removed when it may not have been - Remote metadata could be deleted while local records persist, causing sync inconsistencies ## Fix Return the first error encountered instead of swallowing all errors.

clawbot self-assigned this 2026-02-08 21:01:07 +01:00

clawbot referenced a pull request that will close this issue

2026-02-08 21:05:02 +01:00

Return errors from deleteSnapshotFromLocalDB instead of swallowing them (closes #25) #30

clawbot added the

merge-ready

label 2026-02-20 09:17:45 +01:00

sneak closed this issue

2026-02-20 11:18:31 +01:00

sneak referenced this issue from a commit

2026-02-20 11:18:33 +01:00

Merge pull request 'Return errors from deleteSnapshotFromLocalDB instead of swallowing them (closes #25)' (#30) from fix/issue-25 into main