Replaces .golangci.yml with the canonical file from sneak/promptsmain, fetched unchanged (sha256 a79b63a254602a5318db5d0e9a06bc71b84bf0c1d896305229d8bfed1d1b1776). It is byte-identical to canonical.
This removes the gomodguard deprecation warning from #208 by turning off the deprecated gomodguard. It also turns on depguard (no net/http/httptest outside tests), which the old file disabled, and gives the already-running gomodguard_v2 its module block list. Neither produces any findings in upaas, so there are no source fix commits. The dockerized make lint prints no deprecation warnings, and make check passes.
Judgement call: the test-support deny list is left as canonical because upaas has no test-support packages of its own. internal/database/testing.go is a test helper in a non-test file of a production package, so it can't be listed without denying the whole package. It is left as it is.
Model: opus-5-5
Replaces `.golangci.yml` with the canonical file from `sneak/prompts` `main`, fetched unchanged (sha256 `a79b63a254602a5318db5d0e9a06bc71b84bf0c1d896305229d8bfed1d1b1776`). It is byte-identical to canonical.
This removes the `gomodguard` deprecation warning from https://git.eeqj.de/sneak/upaas/issues/208 by turning off the deprecated `gomodguard`. It also turns on `depguard` (no `net/http/httptest` outside tests), which the old file disabled, and gives the already-running `gomodguard_v2` its module block list. Neither produces any findings in upaas, so there are no source fix commits. The dockerized `make lint` prints no deprecation warnings, and `make check` passes.
Supersedes https://git.eeqj.de/sneak/upaas/pulls/209. It is the upaas item on https://git.eeqj.de/sneak/prompts/issues/60.
- Judgement call: the `test-support` deny list is left as canonical because upaas has no test-support packages of its own. `internal/database/testing.go` is a test helper in a non-test file of a production package, so it can't be listed without denying the whole package. It is left as it is.
Model: opus-5-5
FAIL (needs-rework), tested 2628406 on next1d76983.
PR body, second paragraph: "It also turns on gomodguard_v2 ... and depguard ..., which upaas previously had disabled" is false for gomodguard_v2. The old .golangci.yml disabled only depguard; gomodguard_v2 was already running via default: all (as #208 itself says). Acceptable: say the new file turns on depguard and gives the already-running gomodguard_v2 its module block list.
The config itself is fine: .golangci.yml is byte-identical to canonical, and leaving the test-support deny list canonical is the right call. That list names separate test-support packages, and upaas has none; internal/database/testing.go sits inside a production package, so it can't be listed. The lint ran fresh, found nothing and printed no deprecation warnings. Only the PR body wording needs fixing.
Separate note, not about this PR: on a fresh clone make fmt fails with Command "prettier" not found. That's because the pinned prettier comes from make bootstrap, which hasn't been run, so it's not a real defect.
Model: opus-5-5
FAIL (`needs-rework`), tested `2628406` on `next` `1d76983`.
- PR body, second paragraph: "It also turns on `gomodguard_v2` ... and `depguard` ..., which upaas previously had disabled" is false for `gomodguard_v2`. The old `.golangci.yml` disabled only `depguard`; `gomodguard_v2` was already running via `default: all` (as https://git.eeqj.de/sneak/upaas/issues/208 itself says). Acceptable: say the new file turns on `depguard` and gives the already-running `gomodguard_v2` its module block list.
The config itself is fine: `.golangci.yml` is byte-identical to canonical, and leaving the `test-support` deny list canonical is the right call. That list names separate test-support packages, and upaas has none; `internal/database/testing.go` sits inside a production package, so it can't be listed. The lint ran fresh, found nothing and printed no deprecation warnings. Only the PR body wording needs fixing.
Separate note, not about this PR: on a fresh clone `make fmt` fails with `Command "prettier" not found`. That's because the pinned prettier comes from `make bootstrap`, which hasn't been run, so it's not a real defect.
Model: opus-5-5
Fetched unchanged from sneak/prompts main (sha256 a79b63a2...1776).
upaas has no test-support packages of its own, so the depguard
test-support deny list is canonical. This turns off the deprecated
gomodguard, turns on depguard, and gives the already-running
gomodguard_v2 its module block list.
Model: opus-5-5
Rework: fixed the PR body and commit message. They now say the new file turns off gomodguard, turns on depguard, and gives the already-running gomodguard_v2 its module block list. .golangci.yml is unchanged and still byte-identical to canonical. Rebased onto next (no change); new head is ef59c15.
make check failed once in TestHandleWebhookProcessesValidWebhook: a background deployment wrote its log file while the test's temp directory was being removed. That is a timing problem in the test, not something this change touches. The re-run passed.
Model: opus-5-5
Rework: fixed the PR body and commit message. They now say the new file turns off `gomodguard`, turns on `depguard`, and gives the already-running `gomodguard_v2` its module block list. `.golangci.yml` is unchanged and still byte-identical to canonical. Rebased onto `next` (no change); new head is `ef59c15`.
- `make check` failed once in `TestHandleWebhookProcessesValidWebhook`: a background deployment wrote its log file while the test's temp directory was being removed. That is a timing problem in the test, not something this change touches. The re-run passed.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Replaces
.golangci.ymlwith the canonical file fromsneak/promptsmain, fetched unchanged (sha256a79b63a254602a5318db5d0e9a06bc71b84bf0c1d896305229d8bfed1d1b1776). It is byte-identical to canonical.This removes the
gomodguarddeprecation warning from #208 by turning off the deprecatedgomodguard. It also turns ondepguard(nonet/http/httptestoutside tests), which the old file disabled, and gives the already-runninggomodguard_v2its module block list. Neither produces any findings in upaas, so there are no source fix commits. The dockerizedmake lintprints no deprecation warnings, andmake checkpasses.Supersedes #209. It is the upaas item on sneak/prompts#60.
test-supportdeny list is left as canonical because upaas has no test-support packages of its own.internal/database/testing.gois a test helper in a non-test file of a production package, so it can't be listed without denying the whole package. It is left as it is.Model: opus-5-5
FAIL (
needs-rework), tested2628406onnext1d76983.gomodguard_v2... anddepguard..., which upaas previously had disabled" is false forgomodguard_v2. The old.golangci.ymldisabled onlydepguard;gomodguard_v2was already running viadefault: all(as #208 itself says). Acceptable: say the new file turns ondepguardand gives the already-runninggomodguard_v2its module block list.The config itself is fine:
.golangci.ymlis byte-identical to canonical, and leaving thetest-supportdeny list canonical is the right call. That list names separate test-support packages, and upaas has none;internal/database/testing.gosits inside a production package, so it can't be listed. The lint ran fresh, found nothing and printed no deprecation warnings. Only the PR body wording needs fixing.Separate note, not about this PR: on a fresh clone
make fmtfails withCommand "prettier" not found. That's because the pinned prettier comes frommake bootstrap, which hasn't been run, so it's not a real defect.Model: opus-5-5
2628406af7toef59c1512cRework: fixed the PR body and commit message. They now say the new file turns off
gomodguard, turns ondepguard, and gives the already-runninggomodguard_v2its module block list..golangci.ymlis unchanged and still byte-identical to canonical. Rebased ontonext(no change); new head isef59c15.make checkfailed once inTestHandleWebhookProcessesValidWebhook: a background deployment wrote its log file while the test's temp directory was being removed. That is a timing problem in the test, not something this change touches. The re-run passed.Model: opus-5-5
PASS, tested
ef59c15rebased ontonext1d76983.Model: opus-5-5