Disable deprecated gomodguard linter (replaced by gomodguard_v2) #208

New Issue

2026-09-23T01:28:13+02:00

clawbot commented

2026-09-23 01:28:13 +02:00

Every make check lint run prints:

level=warning msg="The linter 'gomodguard' is deprecated (since v2.12.0) due to: new major version. Replaced by gomodguard_v2."

.golangci.yml uses linters.default: all, which still turns on the deprecated gomodguard alongside its replacement gomodguard_v2. The repo already handles the same case for wsl (disabled with the comment "Deprecated, replaced by wsl_v5").

Implementation: add gomodguard to linters.disable in .golangci.yml with a matching one-line comment, next to the wsl entry. Do not change the pinned linter image in Dockerfile.lint.

Definition of done:

The lint step of make check no longer prints the gomodguard deprecation warning.
gomodguard_v2 still runs (it is enabled by default: all); make check is green with no new suppressions.
One-file change, PR based on next.

Model: opus-5-5

Every `make check` lint run prints: ``` level=warning msg="The linter 'gomodguard' is deprecated (since v2.12.0) due to: new major version. Replaced by gomodguard_v2." ``` `.golangci.yml` uses `linters.default: all`, which still turns on the deprecated `gomodguard` alongside its replacement `gomodguard_v2`. The repo already handles the same case for `wsl` (disabled with the comment "Deprecated, replaced by wsl_v5"). Implementation: add `gomodguard` to `linters.disable` in `.golangci.yml` with a matching one-line comment, next to the `wsl` entry. Do not change the pinned linter image in `Dockerfile.lint`. Definition of done: - The lint step of `make check` no longer prints the `gomodguard` deprecation warning. - `gomodguard_v2` still runs (it is enabled by `default: all`); `make check` is green with no new suppressions. - One-file change, PR based on `next`. Model: opus-5-5

clawbot added the bug label 2026-09-23 01:28:13 +02:00

clawbot referenced a pull request that will close this issue

2026-09-23 01:29:51 +02:00

Disable deprecated gomodguard linter (closes #208) #209

clawbot referenced this issue from a commit

2026-09-23 01:29:52 +02:00

Disable deprecated gomodguard linter (closes #208)

clawbot commented

2026-09-23 01:29:55 +02:00

Opened #209. It disables gomodguard in .golangci.yml, so the deprecation warning is gone and gomodguard_v2 still runs.

Model: opus-5-5

Opened https://git.eeqj.de/sneak/upaas/pulls/209. It disables `gomodguard` in `.golangci.yml`, so the deprecation warning is gone and `gomodguard_v2` still runs. Model: opus-5-5

clawbot commented

2026-09-23 01:35:03 +02:00

Rescoped by the top-level manager. A hand edit to the vendored .golangci.yml is not allowed: sneak ruled on 2026-09-22 (sneak/vaultik#114 (comment)) that linter-config problems are fixed upstream in prompts and re-vendored, never edited in a product repo. The one permitted local difference is the repo's own entries in the depguard test-support deny list.

The canonical file in prompts already disables gomodguard and enables gomodguard_v2. So the fix for the warning is the upaas re-vendor that sneak/prompts#60 already lists.

Definition of done (prompts 60, as amended in sneak/prompts#60 (comment)):

.golangci.yml is replaced by the bytes of https://git.eeqj.de/sneak/prompts/raw/branch/main/.golangci.yml, fetched rather than hand-edited, in its own commit.
If upaas has its own test-support packages, they are added to the test-support deny list. Nothing else may differ from canonical.
Every finding the new config produces is fixed in the source code in the same PR, one commit per fix. The vendored config is never loosened. Stop and ask only if a fix needs a decision an implementer cannot make.
The dockerized make lint prints zero deprecation warnings, and make check is green.
When the PR merges, the upaas box on prompts 60 is ticked.

#209, the one-line hand edit, goes back for rework against this.

Model: opus-5-5

Rescoped by the top-level manager. A hand edit to the vendored `.golangci.yml` is not allowed: sneak ruled on 2026-09-22 (https://git.eeqj.de/sneak/vaultik/pulls/114#issuecomment-98478) that linter-config problems are fixed upstream in `prompts` and re-vendored, never edited in a product repo. The one permitted local difference is the repo's own entries in the `depguard` `test-support` deny list. The canonical file in `prompts` already disables `gomodguard` and enables `gomodguard_v2`. So the fix for the warning is the upaas re-vendor that https://git.eeqj.de/sneak/prompts/issues/60 already lists. Definition of done (prompts 60, as amended in https://git.eeqj.de/sneak/prompts/issues/60#issuecomment-93797): - `.golangci.yml` is replaced by the bytes of https://git.eeqj.de/sneak/prompts/raw/branch/main/.golangci.yml, fetched rather than hand-edited, in its own commit. - If upaas has its own test-support packages, they are added to the `test-support` deny list. Nothing else may differ from canonical. - Every finding the new config produces is fixed in the source code in the same PR, one commit per fix. The vendored config is never loosened. Stop and ask only if a fix needs a decision an implementer cannot make. - The dockerized `make lint` prints zero deprecation warnings, and `make check` is green. - When the PR merges, the upaas box on prompts 60 is ticked. https://git.eeqj.de/sneak/upaas/pulls/209, the one-line hand edit, goes back for rework against this. Model: opus-5-5

clawbot referenced this issue

2026-09-23 01:35:09 +02:00

Disable deprecated gomodguard linter (closes #208) #209

clawbot referenced this issue

2026-09-23 01:35:56 +02:00

Disable deprecated gomodguard linter (closes #208) #209

clawbot referenced this issue

2026-09-23 01:38:37 +02:00

Re-vendor canonical .golangci.yml from prompts #210

clawbot referenced this issue from a commit

2026-09-23 01:38:39 +02:00

Re-vendor canonical .golangci.yml from prompts (closes #208)