Compare commits
10 Commits
8417f8f795
...
feature/ed
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
8156305705 | ||
| e31666ab5c | |||
|
|
c5f957477f | ||
| ebcae55302 | |||
| e2ad42f0ac | |||
|
|
a80b7ac0a6 | ||
|
|
69a5a8c298 | ||
| 3f499163a7 | |||
| 07ac71974c | |||
| cdd7e3fd3a |
@@ -335,7 +335,7 @@ func (h *Handlers) HandleAppDeploy() http.HandlerFunc {
|
|||||||
deployCtx := context.WithoutCancel(request.Context())
|
deployCtx := context.WithoutCancel(request.Context())
|
||||||
|
|
||||||
go func(ctx context.Context, appToDeploy *models.App) {
|
go func(ctx context.Context, appToDeploy *models.App) {
|
||||||
deployErr := h.deploy.Deploy(ctx, appToDeploy, nil)
|
deployErr := h.deploy.Deploy(ctx, appToDeploy, nil, false)
|
||||||
if deployErr != nil {
|
if deployErr != nil {
|
||||||
h.log.Error(
|
h.log.Error(
|
||||||
"deployment failed",
|
"deployment failed",
|
||||||
@@ -354,6 +354,32 @@ func (h *Handlers) HandleAppDeploy() http.HandlerFunc {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// HandleCancelDeploy cancels an in-progress deployment for an app.
|
||||||
|
func (h *Handlers) HandleCancelDeploy() http.HandlerFunc {
|
||||||
|
return func(writer http.ResponseWriter, request *http.Request) {
|
||||||
|
appID := chi.URLParam(request, "id")
|
||||||
|
|
||||||
|
application, findErr := models.FindApp(request.Context(), h.db, appID)
|
||||||
|
if findErr != nil || application == nil {
|
||||||
|
http.NotFound(writer, request)
|
||||||
|
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
cancelled := h.deploy.CancelDeploy(application.ID)
|
||||||
|
if cancelled {
|
||||||
|
h.log.Info("deployment cancelled by user", "app", application.Name)
|
||||||
|
}
|
||||||
|
|
||||||
|
http.Redirect(
|
||||||
|
writer,
|
||||||
|
request,
|
||||||
|
"/apps/"+application.ID,
|
||||||
|
http.StatusSeeOther,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// HandleAppDeployments returns the deployments history handler.
|
// HandleAppDeployments returns the deployments history handler.
|
||||||
func (h *Handlers) HandleAppDeployments() http.HandlerFunc {
|
func (h *Handlers) HandleAppDeployments() http.HandlerFunc {
|
||||||
tmpl := templates.GetParsed()
|
tmpl := templates.GetParsed()
|
||||||
@@ -382,22 +408,22 @@ func (h *Handlers) HandleAppDeployments() http.HandlerFunc {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// defaultLogTail is the default number of log lines to fetch.
|
// DefaultLogTail is the default number of log lines to fetch.
|
||||||
const defaultLogTail = "500"
|
const DefaultLogTail = "500"
|
||||||
|
|
||||||
// maxLogTail is the maximum allowed value for the tail parameter.
|
// maxLogTail is the maximum allowed value for the tail parameter.
|
||||||
const maxLogTail = 500
|
const maxLogTail = 500
|
||||||
|
|
||||||
// sanitizeTail validates and clamps the tail query parameter.
|
// SanitizeTail validates and clamps the tail query parameter.
|
||||||
// It returns a numeric string clamped to maxLogTail, or the default if invalid.
|
// It returns a numeric string clamped to maxLogTail, or the default if invalid.
|
||||||
func sanitizeTail(raw string) string {
|
func SanitizeTail(raw string) string {
|
||||||
if raw == "" {
|
if raw == "" {
|
||||||
return defaultLogTail
|
return DefaultLogTail
|
||||||
}
|
}
|
||||||
|
|
||||||
n, err := strconv.Atoi(raw)
|
n, err := strconv.Atoi(raw)
|
||||||
if err != nil || n < 1 {
|
if err != nil || n < 1 {
|
||||||
return defaultLogTail
|
return DefaultLogTail
|
||||||
}
|
}
|
||||||
|
|
||||||
if n > maxLogTail {
|
if n > maxLogTail {
|
||||||
@@ -428,7 +454,7 @@ func (h *Handlers) HandleAppLogs() http.HandlerFunc {
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
tail := sanitizeTail(request.URL.Query().Get("tail"))
|
tail := SanitizeTail(request.URL.Query().Get("tail"))
|
||||||
|
|
||||||
logs, logsErr := h.docker.ContainerLogs(
|
logs, logsErr := h.docker.ContainerLogs(
|
||||||
request.Context(),
|
request.Context(),
|
||||||
@@ -870,6 +896,54 @@ func (h *Handlers) HandleEnvVarDelete() http.HandlerFunc {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// HandleEnvVarEdit handles editing an existing environment variable.
|
||||||
|
func (h *Handlers) HandleEnvVarEdit() http.HandlerFunc {
|
||||||
|
return func(writer http.ResponseWriter, request *http.Request) {
|
||||||
|
appID := chi.URLParam(request, "id")
|
||||||
|
envVarIDStr := chi.URLParam(request, "varID")
|
||||||
|
|
||||||
|
envVarID, parseErr := strconv.ParseInt(envVarIDStr, 10, 64)
|
||||||
|
if parseErr != nil {
|
||||||
|
http.NotFound(writer, request)
|
||||||
|
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
envVar, findErr := models.FindEnvVar(request.Context(), h.db, envVarID)
|
||||||
|
if findErr != nil || envVar == nil || envVar.AppID != appID {
|
||||||
|
http.NotFound(writer, request)
|
||||||
|
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
formErr := request.ParseForm()
|
||||||
|
if formErr != nil {
|
||||||
|
http.Error(writer, "Bad Request", http.StatusBadRequest)
|
||||||
|
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
key := request.FormValue("key")
|
||||||
|
value := request.FormValue("value")
|
||||||
|
|
||||||
|
if key == "" || value == "" {
|
||||||
|
http.Redirect(writer, request, "/apps/"+appID, http.StatusSeeOther)
|
||||||
|
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
envVar.Key = key
|
||||||
|
envVar.Value = value
|
||||||
|
|
||||||
|
saveErr := envVar.Save(request.Context())
|
||||||
|
if saveErr != nil {
|
||||||
|
h.log.Error("failed to edit env var", "error", saveErr)
|
||||||
|
}
|
||||||
|
|
||||||
|
http.Redirect(writer, request, "/apps/"+appID, http.StatusSeeOther)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// HandleLabelAdd handles adding a label.
|
// HandleLabelAdd handles adding a label.
|
||||||
func (h *Handlers) HandleLabelAdd() http.HandlerFunc {
|
func (h *Handlers) HandleLabelAdd() http.HandlerFunc {
|
||||||
return func(writer http.ResponseWriter, request *http.Request) {
|
return func(writer http.ResponseWriter, request *http.Request) {
|
||||||
@@ -917,6 +991,54 @@ func (h *Handlers) HandleLabelDelete() http.HandlerFunc {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// HandleLabelEdit handles editing an existing label.
|
||||||
|
func (h *Handlers) HandleLabelEdit() http.HandlerFunc {
|
||||||
|
return func(writer http.ResponseWriter, request *http.Request) {
|
||||||
|
appID := chi.URLParam(request, "id")
|
||||||
|
labelIDStr := chi.URLParam(request, "labelID")
|
||||||
|
|
||||||
|
labelID, parseErr := strconv.ParseInt(labelIDStr, 10, 64)
|
||||||
|
if parseErr != nil {
|
||||||
|
http.NotFound(writer, request)
|
||||||
|
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
label, findErr := models.FindLabel(request.Context(), h.db, labelID)
|
||||||
|
if findErr != nil || label == nil || label.AppID != appID {
|
||||||
|
http.NotFound(writer, request)
|
||||||
|
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
formErr := request.ParseForm()
|
||||||
|
if formErr != nil {
|
||||||
|
http.Error(writer, "Bad Request", http.StatusBadRequest)
|
||||||
|
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
key := request.FormValue("key")
|
||||||
|
value := request.FormValue("value")
|
||||||
|
|
||||||
|
if key == "" || value == "" {
|
||||||
|
http.Redirect(writer, request, "/apps/"+appID, http.StatusSeeOther)
|
||||||
|
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
label.Key = key
|
||||||
|
label.Value = value
|
||||||
|
|
||||||
|
saveErr := label.Save(request.Context())
|
||||||
|
if saveErr != nil {
|
||||||
|
h.log.Error("failed to edit label", "error", saveErr)
|
||||||
|
}
|
||||||
|
|
||||||
|
http.Redirect(writer, request, "/apps/"+appID, http.StatusSeeOther)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// HandleVolumeAdd handles adding a volume mount.
|
// HandleVolumeAdd handles adding a volume mount.
|
||||||
func (h *Handlers) HandleVolumeAdd() http.HandlerFunc {
|
func (h *Handlers) HandleVolumeAdd() http.HandlerFunc {
|
||||||
return func(writer http.ResponseWriter, request *http.Request) {
|
return func(writer http.ResponseWriter, request *http.Request) {
|
||||||
@@ -995,6 +1117,56 @@ func (h *Handlers) HandleVolumeDelete() http.HandlerFunc {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// HandleVolumeEdit handles editing an existing volume mount.
|
||||||
|
func (h *Handlers) HandleVolumeEdit() http.HandlerFunc {
|
||||||
|
return func(writer http.ResponseWriter, request *http.Request) {
|
||||||
|
appID := chi.URLParam(request, "id")
|
||||||
|
volumeIDStr := chi.URLParam(request, "volumeID")
|
||||||
|
|
||||||
|
volumeID, parseErr := strconv.ParseInt(volumeIDStr, 10, 64)
|
||||||
|
if parseErr != nil {
|
||||||
|
http.NotFound(writer, request)
|
||||||
|
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
volume, findErr := models.FindVolume(request.Context(), h.db, volumeID)
|
||||||
|
if findErr != nil || volume == nil || volume.AppID != appID {
|
||||||
|
http.NotFound(writer, request)
|
||||||
|
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
formErr := request.ParseForm()
|
||||||
|
if formErr != nil {
|
||||||
|
http.Error(writer, "Bad Request", http.StatusBadRequest)
|
||||||
|
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
hostPath := request.FormValue("host_path")
|
||||||
|
containerPath := request.FormValue("container_path")
|
||||||
|
readOnly := request.FormValue("readonly") == "1"
|
||||||
|
|
||||||
|
if hostPath == "" || containerPath == "" {
|
||||||
|
http.Redirect(writer, request, "/apps/"+appID, http.StatusSeeOther)
|
||||||
|
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
volume.HostPath = hostPath
|
||||||
|
volume.ContainerPath = containerPath
|
||||||
|
volume.ReadOnly = readOnly
|
||||||
|
|
||||||
|
saveErr := volume.Save(request.Context())
|
||||||
|
if saveErr != nil {
|
||||||
|
h.log.Error("failed to edit volume", "error", saveErr)
|
||||||
|
}
|
||||||
|
|
||||||
|
http.Redirect(writer, request, "/apps/"+appID, http.StatusSeeOther)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// HandlePortAdd handles adding a port mapping.
|
// HandlePortAdd handles adding a port mapping.
|
||||||
func (h *Handlers) HandlePortAdd() http.HandlerFunc {
|
func (h *Handlers) HandlePortAdd() http.HandlerFunc {
|
||||||
return func(writer http.ResponseWriter, request *http.Request) {
|
return func(writer http.ResponseWriter, request *http.Request) {
|
||||||
|
|||||||
@@ -1,9 +0,0 @@
|
|||||||
package handlers
|
|
||||||
|
|
||||||
// ExportedSanitizeTail wraps sanitizeTail for external tests.
|
|
||||||
func ExportedSanitizeTail(input string) string {
|
|
||||||
return sanitizeTail(input)
|
|
||||||
}
|
|
||||||
|
|
||||||
// ExportedDefaultLogTail exports defaultLogTail for external tests.
|
|
||||||
const ExportedDefaultLogTail = defaultLogTail
|
|
||||||
@@ -684,6 +684,47 @@ func TestDeletePortOwnershipVerification(t *testing.T) {
|
|||||||
assert.NotNil(t, found, "port should still exist after IDOR attempt")
|
assert.NotNil(t, found, "port should still exist after IDOR attempt")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestHandleCancelDeployRedirects(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
testCtx := setupTestHandlers(t)
|
||||||
|
|
||||||
|
createdApp := createTestApp(t, testCtx, "cancel-deploy-app")
|
||||||
|
|
||||||
|
request := httptest.NewRequest(
|
||||||
|
http.MethodPost,
|
||||||
|
"/apps/"+createdApp.ID+"/deployments/cancel",
|
||||||
|
nil,
|
||||||
|
)
|
||||||
|
request = addChiURLParams(request, map[string]string{"id": createdApp.ID})
|
||||||
|
recorder := httptest.NewRecorder()
|
||||||
|
|
||||||
|
handler := testCtx.handlers.HandleCancelDeploy()
|
||||||
|
handler.ServeHTTP(recorder, request)
|
||||||
|
|
||||||
|
assert.Equal(t, http.StatusSeeOther, recorder.Code)
|
||||||
|
assert.Equal(t, "/apps/"+createdApp.ID, recorder.Header().Get("Location"))
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestHandleCancelDeployReturns404ForUnknownApp(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
testCtx := setupTestHandlers(t)
|
||||||
|
|
||||||
|
request := httptest.NewRequest(
|
||||||
|
http.MethodPost,
|
||||||
|
"/apps/nonexistent/deployments/cancel",
|
||||||
|
nil,
|
||||||
|
)
|
||||||
|
request = addChiURLParams(request, map[string]string{"id": "nonexistent"})
|
||||||
|
recorder := httptest.NewRecorder()
|
||||||
|
|
||||||
|
handler := testCtx.handlers.HandleCancelDeploy()
|
||||||
|
handler.ServeHTTP(recorder, request)
|
||||||
|
|
||||||
|
assert.Equal(t, http.StatusNotFound, recorder.Code)
|
||||||
|
}
|
||||||
|
|
||||||
func TestHandleWebhookReturns404ForUnknownSecret(t *testing.T) {
|
func TestHandleWebhookReturns404ForUnknownSecret(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
|
|
||||||
|
|||||||
@@ -14,16 +14,16 @@ func TestSanitizeTail(t *testing.T) {
|
|||||||
input string
|
input string
|
||||||
expected string
|
expected string
|
||||||
}{
|
}{
|
||||||
{"empty uses default", "", handlers.ExportedDefaultLogTail},
|
{"empty uses default", "", handlers.DefaultLogTail},
|
||||||
{"valid small number", "50", "50"},
|
{"valid small number", "50", "50"},
|
||||||
{"valid max boundary", "500", "500"},
|
{"valid max boundary", "500", "500"},
|
||||||
{"exceeds max clamped", "501", "500"},
|
{"exceeds max clamped", "501", "500"},
|
||||||
{"very large clamped", "999999", "500"},
|
{"very large clamped", "999999", "500"},
|
||||||
{"non-numeric uses default", "abc", handlers.ExportedDefaultLogTail},
|
{"non-numeric uses default", "abc", handlers.DefaultLogTail},
|
||||||
{"all keyword uses default", "all", handlers.ExportedDefaultLogTail},
|
{"all keyword uses default", "all", handlers.DefaultLogTail},
|
||||||
{"negative uses default", "-1", handlers.ExportedDefaultLogTail},
|
{"negative uses default", "-1", handlers.DefaultLogTail},
|
||||||
{"zero uses default", "0", handlers.ExportedDefaultLogTail},
|
{"zero uses default", "0", handlers.DefaultLogTail},
|
||||||
{"float uses default", "1.5", handlers.ExportedDefaultLogTail},
|
{"float uses default", "1.5", handlers.DefaultLogTail},
|
||||||
{"one is valid", "1", "1"},
|
{"one is valid", "1", "1"},
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -31,7 +31,7 @@ func TestSanitizeTail(t *testing.T) {
|
|||||||
t.Run(tc.name, func(t *testing.T) {
|
t.Run(tc.name, func(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
|
|
||||||
got := handlers.ExportedSanitizeTail(tc.input)
|
got := handlers.SanitizeTail(tc.input)
|
||||||
if got != tc.expected {
|
if got != tc.expected {
|
||||||
t.Errorf("sanitizeTail(%q) = %q, want %q", tc.input, got, tc.expected)
|
t.Errorf("sanitizeTail(%q) = %q, want %q", tc.input, got, tc.expected)
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -19,6 +19,7 @@ const (
|
|||||||
DeploymentStatusDeploying DeploymentStatus = "deploying"
|
DeploymentStatusDeploying DeploymentStatus = "deploying"
|
||||||
DeploymentStatusSuccess DeploymentStatus = "success"
|
DeploymentStatusSuccess DeploymentStatus = "success"
|
||||||
DeploymentStatusFailed DeploymentStatus = "failed"
|
DeploymentStatusFailed DeploymentStatus = "failed"
|
||||||
|
DeploymentStatusCancelled DeploymentStatus = "cancelled"
|
||||||
)
|
)
|
||||||
|
|
||||||
// Display constants.
|
// Display constants.
|
||||||
|
|||||||
@@ -54,46 +54,50 @@ func (s *Server) SetupRoutes() {
|
|||||||
r.Group(func(r chi.Router) {
|
r.Group(func(r chi.Router) {
|
||||||
r.Use(s.mw.SessionAuth())
|
r.Use(s.mw.SessionAuth())
|
||||||
|
|
||||||
// Dashboard
|
// Dashboard
|
||||||
r.Get("/", s.handlers.HandleDashboard())
|
r.Get("/", s.handlers.HandleDashboard())
|
||||||
|
|
||||||
// Logout
|
// Logout
|
||||||
r.Post("/logout", s.handlers.HandleLogout())
|
r.Post("/logout", s.handlers.HandleLogout())
|
||||||
|
|
||||||
// App routes
|
// App routes
|
||||||
r.Get("/apps/new", s.handlers.HandleAppNew())
|
r.Get("/apps/new", s.handlers.HandleAppNew())
|
||||||
r.Post("/apps", s.handlers.HandleAppCreate())
|
r.Post("/apps", s.handlers.HandleAppCreate())
|
||||||
r.Get("/apps/{id}", s.handlers.HandleAppDetail())
|
r.Get("/apps/{id}", s.handlers.HandleAppDetail())
|
||||||
r.Get("/apps/{id}/edit", s.handlers.HandleAppEdit())
|
r.Get("/apps/{id}/edit", s.handlers.HandleAppEdit())
|
||||||
r.Post("/apps/{id}", s.handlers.HandleAppUpdate())
|
r.Post("/apps/{id}", s.handlers.HandleAppUpdate())
|
||||||
r.Post("/apps/{id}/delete", s.handlers.HandleAppDelete())
|
r.Post("/apps/{id}/delete", s.handlers.HandleAppDelete())
|
||||||
r.Post("/apps/{id}/deploy", s.handlers.HandleAppDeploy())
|
r.Post("/apps/{id}/deploy", s.handlers.HandleAppDeploy())
|
||||||
r.Get("/apps/{id}/deployments", s.handlers.HandleAppDeployments())
|
r.Post("/apps/{id}/deployments/cancel", s.handlers.HandleCancelDeploy())
|
||||||
r.Get("/apps/{id}/deployments/{deploymentID}/logs", s.handlers.HandleDeploymentLogsAPI())
|
r.Get("/apps/{id}/deployments", s.handlers.HandleAppDeployments())
|
||||||
r.Get("/apps/{id}/deployments/{deploymentID}/download", s.handlers.HandleDeploymentLogDownload())
|
r.Get("/apps/{id}/deployments/{deploymentID}/logs", s.handlers.HandleDeploymentLogsAPI())
|
||||||
r.Get("/apps/{id}/logs", s.handlers.HandleAppLogs())
|
r.Get("/apps/{id}/deployments/{deploymentID}/download", s.handlers.HandleDeploymentLogDownload())
|
||||||
r.Get("/apps/{id}/container-logs", s.handlers.HandleContainerLogsAPI())
|
r.Get("/apps/{id}/logs", s.handlers.HandleAppLogs())
|
||||||
r.Get("/apps/{id}/status", s.handlers.HandleAppStatusAPI())
|
r.Get("/apps/{id}/container-logs", s.handlers.HandleContainerLogsAPI())
|
||||||
r.Get("/apps/{id}/recent-deployments", s.handlers.HandleRecentDeploymentsAPI())
|
r.Get("/apps/{id}/status", s.handlers.HandleAppStatusAPI())
|
||||||
r.Post("/apps/{id}/restart", s.handlers.HandleAppRestart())
|
r.Get("/apps/{id}/recent-deployments", s.handlers.HandleRecentDeploymentsAPI())
|
||||||
r.Post("/apps/{id}/stop", s.handlers.HandleAppStop())
|
r.Post("/apps/{id}/restart", s.handlers.HandleAppRestart())
|
||||||
r.Post("/apps/{id}/start", s.handlers.HandleAppStart())
|
r.Post("/apps/{id}/stop", s.handlers.HandleAppStop())
|
||||||
|
r.Post("/apps/{id}/start", s.handlers.HandleAppStart())
|
||||||
|
|
||||||
// Environment variables
|
// Environment variables
|
||||||
r.Post("/apps/{id}/env-vars", s.handlers.HandleEnvVarAdd())
|
r.Post("/apps/{id}/env-vars", s.handlers.HandleEnvVarAdd())
|
||||||
r.Post("/apps/{id}/env-vars/{varID}/delete", s.handlers.HandleEnvVarDelete())
|
r.Post("/apps/{id}/env-vars/{varID}/edit", s.handlers.HandleEnvVarEdit())
|
||||||
|
r.Post("/apps/{id}/env-vars/{varID}/delete", s.handlers.HandleEnvVarDelete())
|
||||||
|
|
||||||
// Labels
|
// Labels
|
||||||
r.Post("/apps/{id}/labels", s.handlers.HandleLabelAdd())
|
r.Post("/apps/{id}/labels", s.handlers.HandleLabelAdd())
|
||||||
r.Post("/apps/{id}/labels/{labelID}/delete", s.handlers.HandleLabelDelete())
|
r.Post("/apps/{id}/labels/{labelID}/edit", s.handlers.HandleLabelEdit())
|
||||||
|
r.Post("/apps/{id}/labels/{labelID}/delete", s.handlers.HandleLabelDelete())
|
||||||
|
|
||||||
// Volumes
|
// Volumes
|
||||||
r.Post("/apps/{id}/volumes", s.handlers.HandleVolumeAdd())
|
r.Post("/apps/{id}/volumes", s.handlers.HandleVolumeAdd())
|
||||||
r.Post("/apps/{id}/volumes/{volumeID}/delete", s.handlers.HandleVolumeDelete())
|
r.Post("/apps/{id}/volumes/{volumeID}/edit", s.handlers.HandleVolumeEdit())
|
||||||
|
r.Post("/apps/{id}/volumes/{volumeID}/delete", s.handlers.HandleVolumeDelete())
|
||||||
|
|
||||||
// Ports
|
// Ports
|
||||||
r.Post("/apps/{id}/ports", s.handlers.HandlePortAdd())
|
r.Post("/apps/{id}/ports", s.handlers.HandlePortAdd())
|
||||||
r.Post("/apps/{id}/ports/{portID}/delete", s.handlers.HandlePortDelete())
|
r.Post("/apps/{id}/ports/{portID}/delete", s.handlers.HandlePortDelete())
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
|
|
||||||
|
|||||||
@@ -10,7 +10,6 @@ import (
|
|||||||
"log/slog"
|
"log/slog"
|
||||||
"net/http"
|
"net/http"
|
||||||
"strings"
|
"strings"
|
||||||
"time"
|
|
||||||
|
|
||||||
"github.com/gorilla/sessions"
|
"github.com/gorilla/sessions"
|
||||||
"go.uber.org/fx"
|
"go.uber.org/fx"
|
||||||
@@ -269,7 +268,7 @@ func (svc *Service) DestroySession(
|
|||||||
return fmt.Errorf("failed to get session: %w", err)
|
return fmt.Errorf("failed to get session: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
session.Options.MaxAge = -1 * int(time.Second)
|
session.Options.MaxAge = -1
|
||||||
|
|
||||||
saveErr := session.Save(request, respWriter)
|
saveErr := session.Save(request, respWriter)
|
||||||
if saveErr != nil {
|
if saveErr != nil {
|
||||||
|
|||||||
@@ -369,3 +369,38 @@ func TestAuthenticate(testingT *testing.T) {
|
|||||||
assert.ErrorIs(t, err, auth.ErrInvalidCredentials)
|
assert.ErrorIs(t, err, auth.ErrInvalidCredentials)
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestDestroySessionMaxAge(testingT *testing.T) {
|
||||||
|
testingT.Parallel()
|
||||||
|
|
||||||
|
testingT.Run("sets MaxAge to exactly -1", func(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
svc, cleanup := setupTestService(t)
|
||||||
|
defer cleanup()
|
||||||
|
|
||||||
|
recorder := httptest.NewRecorder()
|
||||||
|
request := httptest.NewRequest(http.MethodGet, "/", nil)
|
||||||
|
|
||||||
|
err := svc.DestroySession(recorder, request)
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
|
// Check the Set-Cookie header to verify MaxAge is -1 (immediate expiry).
|
||||||
|
// With MaxAge = -1, the cookie should have Max-Age=0 in the HTTP header
|
||||||
|
// (per http.Cookie semantics: negative MaxAge means delete now).
|
||||||
|
cookies := recorder.Result().Cookies()
|
||||||
|
require.NotEmpty(t, cookies, "expected a Set-Cookie header")
|
||||||
|
|
||||||
|
found := false
|
||||||
|
|
||||||
|
for _, c := range cookies {
|
||||||
|
if c.MaxAge < 0 {
|
||||||
|
found = true
|
||||||
|
|
||||||
|
break
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
assert.True(t, found, "expected a cookie with negative MaxAge (deletion)")
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|||||||
@@ -43,6 +43,8 @@ var (
|
|||||||
ErrContainerUnhealthy = errors.New("container unhealthy after 60 seconds")
|
ErrContainerUnhealthy = errors.New("container unhealthy after 60 seconds")
|
||||||
// ErrDeploymentInProgress indicates another deployment is already running.
|
// ErrDeploymentInProgress indicates another deployment is already running.
|
||||||
ErrDeploymentInProgress = errors.New("deployment already in progress for this app")
|
ErrDeploymentInProgress = errors.New("deployment already in progress for this app")
|
||||||
|
// ErrDeployCancelled indicates the deployment was cancelled by a newer deploy.
|
||||||
|
ErrDeployCancelled = errors.New("deployment cancelled by newer deploy")
|
||||||
// ErrBuildTimeout indicates the build phase exceeded the timeout.
|
// ErrBuildTimeout indicates the build phase exceeded the timeout.
|
||||||
ErrBuildTimeout = errors.New("build timeout exceeded")
|
ErrBuildTimeout = errors.New("build timeout exceeded")
|
||||||
// ErrDeployTimeout indicates the deploy phase exceeded the timeout.
|
// ErrDeployTimeout indicates the deploy phase exceeded the timeout.
|
||||||
@@ -205,15 +207,22 @@ type ServiceParams struct {
|
|||||||
Notify *notify.Service
|
Notify *notify.Service
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// activeDeploy tracks a running deployment so it can be cancelled.
|
||||||
|
type activeDeploy struct {
|
||||||
|
cancel context.CancelFunc
|
||||||
|
done chan struct{}
|
||||||
|
}
|
||||||
|
|
||||||
// Service provides deployment functionality.
|
// Service provides deployment functionality.
|
||||||
type Service struct {
|
type Service struct {
|
||||||
log *slog.Logger
|
log *slog.Logger
|
||||||
db *database.Database
|
db *database.Database
|
||||||
docker *docker.Client
|
docker *docker.Client
|
||||||
notify *notify.Service
|
notify *notify.Service
|
||||||
config *config.Config
|
config *config.Config
|
||||||
params *ServiceParams
|
params *ServiceParams
|
||||||
appLocks sync.Map // map[string]*sync.Mutex - per-app deployment locks
|
activeDeploys sync.Map // map[string]*activeDeploy - per-app active deployment tracking
|
||||||
|
appLocks sync.Map // map[string]*sync.Mutex - per-app deployment locks
|
||||||
}
|
}
|
||||||
|
|
||||||
// New creates a new deploy Service.
|
// New creates a new deploy Service.
|
||||||
@@ -274,12 +283,39 @@ func (svc *Service) GetLogFilePath(app *models.App, deployment *models.Deploymen
|
|||||||
return filepath.Join(svc.config.DataDir, "logs", hostname, app.Name, filename)
|
return filepath.Join(svc.config.DataDir, "logs", hostname, app.Name, filename)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Deploy deploys an app.
|
// HasActiveDeploy returns true if there is an active deployment for the given app.
|
||||||
|
func (svc *Service) HasActiveDeploy(appID string) bool {
|
||||||
|
_, ok := svc.activeDeploys.Load(appID)
|
||||||
|
|
||||||
|
return ok
|
||||||
|
}
|
||||||
|
|
||||||
|
// CancelDeploy cancels any in-progress deployment for the given app
|
||||||
|
// and waits for it to finish before returning. Returns true if a deployment
|
||||||
|
// was cancelled, false if there was nothing to cancel.
|
||||||
|
func (svc *Service) CancelDeploy(appID string) bool {
|
||||||
|
if !svc.HasActiveDeploy(appID) {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
|
||||||
|
svc.cancelActiveDeploy(appID)
|
||||||
|
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
|
||||||
|
// Deploy deploys an app. If cancelExisting is true (e.g. webhook-triggered),
|
||||||
|
// any in-progress deploy for the same app will be cancelled before starting.
|
||||||
|
// If cancelExisting is false and a deploy is in progress, ErrDeploymentInProgress is returned.
|
||||||
func (svc *Service) Deploy(
|
func (svc *Service) Deploy(
|
||||||
ctx context.Context,
|
ctx context.Context,
|
||||||
app *models.App,
|
app *models.App,
|
||||||
webhookEventID *int64,
|
webhookEventID *int64,
|
||||||
|
cancelExisting bool,
|
||||||
) error {
|
) error {
|
||||||
|
if cancelExisting {
|
||||||
|
svc.cancelActiveDeploy(app.ID)
|
||||||
|
}
|
||||||
|
|
||||||
// Try to acquire per-app deployment lock
|
// Try to acquire per-app deployment lock
|
||||||
if !svc.tryLockApp(app.ID) {
|
if !svc.tryLockApp(app.ID) {
|
||||||
svc.log.Warn("deployment already in progress", "app", app.Name)
|
svc.log.Warn("deployment already in progress", "app", app.Name)
|
||||||
@@ -288,45 +324,80 @@ func (svc *Service) Deploy(
|
|||||||
}
|
}
|
||||||
defer svc.unlockApp(app.ID)
|
defer svc.unlockApp(app.ID)
|
||||||
|
|
||||||
|
// Set up cancellable context and register as active deploy
|
||||||
|
deployCtx, cancel := context.WithCancel(ctx)
|
||||||
|
done := make(chan struct{})
|
||||||
|
ad := &activeDeploy{cancel: cancel, done: done}
|
||||||
|
svc.activeDeploys.Store(app.ID, ad)
|
||||||
|
|
||||||
|
defer func() {
|
||||||
|
cancel()
|
||||||
|
close(done)
|
||||||
|
svc.activeDeploys.Delete(app.ID)
|
||||||
|
}()
|
||||||
|
|
||||||
// Fetch webhook event and create deployment record
|
// Fetch webhook event and create deployment record
|
||||||
webhookEvent := svc.fetchWebhookEvent(ctx, webhookEventID)
|
webhookEvent := svc.fetchWebhookEvent(deployCtx, webhookEventID)
|
||||||
|
|
||||||
deployment, err := svc.createDeploymentRecord(ctx, app, webhookEventID, webhookEvent)
|
// Use a background context for DB operations that must complete regardless of cancellation
|
||||||
|
bgCtx := context.WithoutCancel(deployCtx)
|
||||||
|
|
||||||
|
deployment, err := svc.createDeploymentRecord(bgCtx, app, webhookEventID, webhookEvent)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
svc.logWebhookPayload(ctx, deployment, webhookEvent)
|
svc.logWebhookPayload(bgCtx, deployment, webhookEvent)
|
||||||
|
|
||||||
err = svc.updateAppStatusBuilding(ctx, app)
|
err = svc.updateAppStatusBuilding(bgCtx, app)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
svc.notify.NotifyBuildStart(ctx, app, deployment)
|
svc.notify.NotifyBuildStart(bgCtx, app, deployment)
|
||||||
|
|
||||||
|
return svc.runBuildAndDeploy(deployCtx, bgCtx, app, deployment)
|
||||||
|
}
|
||||||
|
|
||||||
|
// runBuildAndDeploy executes the build and deploy phases, handling cancellation.
|
||||||
|
func (svc *Service) runBuildAndDeploy(
|
||||||
|
deployCtx context.Context,
|
||||||
|
bgCtx context.Context,
|
||||||
|
app *models.App,
|
||||||
|
deployment *models.Deployment,
|
||||||
|
) error {
|
||||||
// Build phase with timeout
|
// Build phase with timeout
|
||||||
imageID, err := svc.buildImageWithTimeout(ctx, app, deployment)
|
imageID, err := svc.buildImageWithTimeout(deployCtx, app, deployment)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
cancelErr := svc.checkCancelled(deployCtx, bgCtx, app, deployment)
|
||||||
|
if cancelErr != nil {
|
||||||
|
return cancelErr
|
||||||
|
}
|
||||||
|
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
svc.notify.NotifyBuildSuccess(ctx, app, deployment)
|
svc.notify.NotifyBuildSuccess(bgCtx, app, deployment)
|
||||||
|
|
||||||
// Deploy phase with timeout
|
// Deploy phase with timeout
|
||||||
err = svc.deployContainerWithTimeout(ctx, app, deployment, imageID)
|
err = svc.deployContainerWithTimeout(deployCtx, app, deployment, imageID)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
cancelErr := svc.checkCancelled(deployCtx, bgCtx, app, deployment)
|
||||||
|
if cancelErr != nil {
|
||||||
|
return cancelErr
|
||||||
|
}
|
||||||
|
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
err = svc.updateAppRunning(ctx, app, imageID)
|
err = svc.updateAppRunning(bgCtx, app, imageID)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
// Use context.WithoutCancel to ensure health check completes even if
|
// Use context.WithoutCancel to ensure health check completes even if
|
||||||
// the parent context is cancelled (e.g., HTTP request ends).
|
// the parent context is cancelled (e.g., HTTP request ends).
|
||||||
go svc.checkHealthAfterDelay(context.WithoutCancel(ctx), app, deployment)
|
go svc.checkHealthAfterDelay(bgCtx, app, deployment)
|
||||||
|
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
@@ -463,6 +534,43 @@ func (svc *Service) unlockApp(appID string) {
|
|||||||
svc.getAppLock(appID).Unlock()
|
svc.getAppLock(appID).Unlock()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// cancelActiveDeploy cancels any in-progress deployment for the given app
|
||||||
|
// and waits for it to finish before returning.
|
||||||
|
func (svc *Service) cancelActiveDeploy(appID string) {
|
||||||
|
val, ok := svc.activeDeploys.Load(appID)
|
||||||
|
if !ok {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
ad, ok := val.(*activeDeploy)
|
||||||
|
if !ok {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
svc.log.Info("cancelling in-progress deployment", "app_id", appID)
|
||||||
|
ad.cancel()
|
||||||
|
<-ad.done
|
||||||
|
}
|
||||||
|
|
||||||
|
// checkCancelled checks if the deploy context was cancelled (by a newer deploy)
|
||||||
|
// and if so, marks the deployment as cancelled. Returns ErrDeployCancelled or nil.
|
||||||
|
func (svc *Service) checkCancelled(
|
||||||
|
deployCtx context.Context,
|
||||||
|
bgCtx context.Context,
|
||||||
|
app *models.App,
|
||||||
|
deployment *models.Deployment,
|
||||||
|
) error {
|
||||||
|
if !errors.Is(deployCtx.Err(), context.Canceled) {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
svc.log.Info("deployment cancelled by newer deploy", "app", app.Name)
|
||||||
|
|
||||||
|
_ = deployment.MarkFinished(bgCtx, models.DeploymentStatusCancelled)
|
||||||
|
|
||||||
|
return ErrDeployCancelled
|
||||||
|
}
|
||||||
|
|
||||||
func (svc *Service) fetchWebhookEvent(
|
func (svc *Service) fetchWebhookEvent(
|
||||||
ctx context.Context,
|
ctx context.Context,
|
||||||
webhookEventID *int64,
|
webhookEventID *int64,
|
||||||
|
|||||||
133
internal/service/deploy/deploy_cancel_test.go
Normal file
133
internal/service/deploy/deploy_cancel_test.go
Normal file
@@ -0,0 +1,133 @@
|
|||||||
|
package deploy_test
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"log/slog"
|
||||||
|
"sync"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"github.com/stretchr/testify/assert"
|
||||||
|
|
||||||
|
"git.eeqj.de/sneak/upaas/internal/service/deploy"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestCancelActiveDeploy_NoExisting(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
svc := deploy.NewTestService(slog.Default())
|
||||||
|
|
||||||
|
// Should not panic or block when no active deploy exists
|
||||||
|
svc.CancelActiveDeploy("nonexistent-app")
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestCancelActiveDeploy_CancelsAndWaits(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
svc := deploy.NewTestService(slog.Default())
|
||||||
|
|
||||||
|
ctx, cancel := context.WithCancel(context.Background())
|
||||||
|
done := make(chan struct{})
|
||||||
|
|
||||||
|
svc.RegisterActiveDeploy("app-1", cancel, done)
|
||||||
|
|
||||||
|
// Simulate a running deploy that respects cancellation
|
||||||
|
var deployFinished bool
|
||||||
|
|
||||||
|
go func() {
|
||||||
|
<-ctx.Done()
|
||||||
|
|
||||||
|
deployFinished = true
|
||||||
|
|
||||||
|
close(done)
|
||||||
|
}()
|
||||||
|
|
||||||
|
svc.CancelActiveDeploy("app-1")
|
||||||
|
assert.True(t, deployFinished, "deploy should have finished after cancellation")
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestCancelActiveDeploy_BlocksUntilDone(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
svc := deploy.NewTestService(slog.Default())
|
||||||
|
|
||||||
|
ctx, cancel := context.WithCancel(context.Background())
|
||||||
|
done := make(chan struct{})
|
||||||
|
|
||||||
|
svc.RegisterActiveDeploy("app-2", cancel, done)
|
||||||
|
|
||||||
|
// Simulate slow cleanup after cancellation
|
||||||
|
go func() {
|
||||||
|
<-ctx.Done()
|
||||||
|
time.Sleep(50 * time.Millisecond)
|
||||||
|
close(done)
|
||||||
|
}()
|
||||||
|
|
||||||
|
start := time.Now()
|
||||||
|
|
||||||
|
svc.CancelActiveDeploy("app-2")
|
||||||
|
|
||||||
|
elapsed := time.Since(start)
|
||||||
|
|
||||||
|
assert.GreaterOrEqual(t, elapsed, 50*time.Millisecond,
|
||||||
|
"cancelActiveDeploy should block until the deploy finishes")
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestTryLockApp_PreventsConcurrent(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
svc := deploy.NewTestService(slog.Default())
|
||||||
|
|
||||||
|
assert.True(t, svc.TryLockApp("app-1"), "first lock should succeed")
|
||||||
|
assert.False(t, svc.TryLockApp("app-1"), "second lock should fail")
|
||||||
|
|
||||||
|
svc.UnlockApp("app-1")
|
||||||
|
|
||||||
|
assert.True(t, svc.TryLockApp("app-1"), "lock after unlock should succeed")
|
||||||
|
|
||||||
|
svc.UnlockApp("app-1")
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestCancelActiveDeploy_AllowsNewDeploy(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
|
||||||
|
svc := deploy.NewTestService(slog.Default())
|
||||||
|
|
||||||
|
// Simulate an active deploy holding the lock
|
||||||
|
ctx, cancel := context.WithCancel(context.Background())
|
||||||
|
done := make(chan struct{})
|
||||||
|
|
||||||
|
svc.RegisterActiveDeploy("app-3", cancel, done)
|
||||||
|
|
||||||
|
// Lock the app as if a deploy is in progress
|
||||||
|
assert.True(t, svc.TryLockApp("app-3"))
|
||||||
|
|
||||||
|
// Simulate deploy goroutine: release lock on cancellation
|
||||||
|
var mu sync.Mutex
|
||||||
|
|
||||||
|
released := false
|
||||||
|
|
||||||
|
go func() {
|
||||||
|
<-ctx.Done()
|
||||||
|
|
||||||
|
svc.UnlockApp("app-3")
|
||||||
|
|
||||||
|
mu.Lock()
|
||||||
|
released = true
|
||||||
|
mu.Unlock()
|
||||||
|
|
||||||
|
close(done)
|
||||||
|
}()
|
||||||
|
|
||||||
|
// Cancel should cause the old deploy to release its lock
|
||||||
|
svc.CancelActiveDeploy("app-3")
|
||||||
|
|
||||||
|
mu.Lock()
|
||||||
|
assert.True(t, released)
|
||||||
|
mu.Unlock()
|
||||||
|
|
||||||
|
// Now a new deploy should be able to acquire the lock
|
||||||
|
assert.True(t, svc.TryLockApp("app-3"), "should be able to lock after cancellation")
|
||||||
|
|
||||||
|
svc.UnlockApp("app-3")
|
||||||
|
}
|
||||||
33
internal/service/deploy/export_test.go
Normal file
33
internal/service/deploy/export_test.go
Normal file
@@ -0,0 +1,33 @@
|
|||||||
|
package deploy
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"log/slog"
|
||||||
|
)
|
||||||
|
|
||||||
|
// NewTestService creates a Service with minimal dependencies for testing.
|
||||||
|
func NewTestService(log *slog.Logger) *Service {
|
||||||
|
return &Service{
|
||||||
|
log: log,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// CancelActiveDeploy exposes cancelActiveDeploy for testing.
|
||||||
|
func (svc *Service) CancelActiveDeploy(appID string) {
|
||||||
|
svc.cancelActiveDeploy(appID)
|
||||||
|
}
|
||||||
|
|
||||||
|
// RegisterActiveDeploy registers an active deploy for testing.
|
||||||
|
func (svc *Service) RegisterActiveDeploy(appID string, cancel context.CancelFunc, done chan struct{}) {
|
||||||
|
svc.activeDeploys.Store(appID, &activeDeploy{cancel: cancel, done: done})
|
||||||
|
}
|
||||||
|
|
||||||
|
// TryLockApp exposes tryLockApp for testing.
|
||||||
|
func (svc *Service) TryLockApp(appID string) bool {
|
||||||
|
return svc.tryLockApp(appID)
|
||||||
|
}
|
||||||
|
|
||||||
|
// UnlockApp exposes unlockApp for testing.
|
||||||
|
func (svc *Service) UnlockApp(appID string) {
|
||||||
|
svc.unlockApp(appID)
|
||||||
|
}
|
||||||
@@ -143,7 +143,7 @@ func (svc *Service) triggerDeployment(
|
|||||||
// even if the HTTP request context is cancelled.
|
// even if the HTTP request context is cancelled.
|
||||||
deployCtx := context.WithoutCancel(ctx)
|
deployCtx := context.WithoutCancel(ctx)
|
||||||
|
|
||||||
deployErr := svc.deploy.Deploy(deployCtx, app, &eventID)
|
deployErr := svc.deploy.Deploy(deployCtx, app, &eventID, true)
|
||||||
if deployErr != nil {
|
if deployErr != nil {
|
||||||
svc.log.Error("deployment failed", "error", deployErr, "app", appName)
|
svc.log.Error("deployment failed", "error", deployErr, "app", appName)
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -40,6 +40,10 @@
|
|||||||
<span x-text="deploying ? 'Deploying...' : 'Deploy Now'"></span>
|
<span x-text="deploying ? 'Deploying...' : 'Deploy Now'"></span>
|
||||||
</button>
|
</button>
|
||||||
</form>
|
</form>
|
||||||
|
<form method="POST" action="/apps/{{.App.ID}}/deployments/cancel" class="inline" x-show="deploying" x-cloak x-data="confirmAction('Cancel the current deployment?')" @submit="confirm($event)">
|
||||||
|
{{ .CSRFField }}
|
||||||
|
<button type="submit" class="btn-danger">Cancel Deploy</button>
|
||||||
|
</form>
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
@@ -102,15 +106,33 @@
|
|||||||
</thead>
|
</thead>
|
||||||
<tbody class="table-body">
|
<tbody class="table-body">
|
||||||
{{range .EnvVars}}
|
{{range .EnvVars}}
|
||||||
<tr>
|
<tr x-data="{ editing: false }">
|
||||||
<td class="font-mono font-medium">{{.Key}}</td>
|
<template x-if="!editing">
|
||||||
<td class="font-mono text-gray-500">{{.Value}}</td>
|
<td class="font-mono font-medium">{{.Key}}</td>
|
||||||
<td class="text-right">
|
</template>
|
||||||
<form method="POST" action="/apps/{{$.App.ID}}/env/{{.ID}}/delete" class="inline" x-data="confirmAction('Delete this environment variable?')" @submit="confirm($event)">
|
<template x-if="!editing">
|
||||||
{{ .CSRFField }}
|
<td class="font-mono text-gray-500">{{.Value}}</td>
|
||||||
<button type="submit" class="text-error-500 hover:text-error-700 text-sm">Delete</button>
|
</template>
|
||||||
</form>
|
<template x-if="!editing">
|
||||||
</td>
|
<td class="text-right">
|
||||||
|
<button @click="editing = true" class="text-primary-600 hover:text-primary-800 text-sm mr-2">Edit</button>
|
||||||
|
<form method="POST" action="/apps/{{$.App.ID}}/env-vars/{{.ID}}/delete" class="inline" x-data="confirmAction('Delete this environment variable?')" @submit="confirm($event)">
|
||||||
|
{{ .CSRFField }}
|
||||||
|
<button type="submit" class="text-error-500 hover:text-error-700 text-sm">Delete</button>
|
||||||
|
</form>
|
||||||
|
</td>
|
||||||
|
</template>
|
||||||
|
<template x-if="editing">
|
||||||
|
<td colspan="3">
|
||||||
|
<form method="POST" action="/apps/{{$.App.ID}}/env-vars/{{.ID}}/edit" class="flex flex-col sm:flex-row gap-2 items-center">
|
||||||
|
{{ .CSRFField }}
|
||||||
|
<input type="text" name="key" value="{{.Key}}" required class="input flex-1 font-mono text-sm">
|
||||||
|
<input type="text" name="value" value="{{.Value}}" required class="input flex-1 font-mono text-sm">
|
||||||
|
<button type="submit" class="btn-primary text-sm">Save</button>
|
||||||
|
<button type="button" @click="editing = false" class="text-gray-500 hover:text-gray-700 text-sm">Cancel</button>
|
||||||
|
</form>
|
||||||
|
</td>
|
||||||
|
</template>
|
||||||
</tr>
|
</tr>
|
||||||
{{end}}
|
{{end}}
|
||||||
</tbody>
|
</tbody>
|
||||||
@@ -147,15 +169,33 @@
|
|||||||
</td>
|
</td>
|
||||||
</tr>
|
</tr>
|
||||||
{{range .Labels}}
|
{{range .Labels}}
|
||||||
<tr>
|
<tr x-data="{ editing: false }">
|
||||||
<td class="font-mono font-medium">{{.Key}}</td>
|
<template x-if="!editing">
|
||||||
<td class="font-mono text-gray-500">{{.Value}}</td>
|
<td class="font-mono font-medium">{{.Key}}</td>
|
||||||
<td class="text-right">
|
</template>
|
||||||
<form method="POST" action="/apps/{{$.App.ID}}/labels/{{.ID}}/delete" class="inline" x-data="confirmAction('Delete this label?')" @submit="confirm($event)">
|
<template x-if="!editing">
|
||||||
{{ .CSRFField }}
|
<td class="font-mono text-gray-500">{{.Value}}</td>
|
||||||
<button type="submit" class="text-error-500 hover:text-error-700 text-sm">Delete</button>
|
</template>
|
||||||
</form>
|
<template x-if="!editing">
|
||||||
</td>
|
<td class="text-right">
|
||||||
|
<button @click="editing = true" class="text-primary-600 hover:text-primary-800 text-sm mr-2">Edit</button>
|
||||||
|
<form method="POST" action="/apps/{{$.App.ID}}/labels/{{.ID}}/delete" class="inline" x-data="confirmAction('Delete this label?')" @submit="confirm($event)">
|
||||||
|
{{ .CSRFField }}
|
||||||
|
<button type="submit" class="text-error-500 hover:text-error-700 text-sm">Delete</button>
|
||||||
|
</form>
|
||||||
|
</td>
|
||||||
|
</template>
|
||||||
|
<template x-if="editing">
|
||||||
|
<td colspan="3">
|
||||||
|
<form method="POST" action="/apps/{{$.App.ID}}/labels/{{.ID}}/edit" class="flex flex-col sm:flex-row gap-2 items-center">
|
||||||
|
{{ .CSRFField }}
|
||||||
|
<input type="text" name="key" value="{{.Key}}" required class="input flex-1 font-mono text-sm">
|
||||||
|
<input type="text" name="value" value="{{.Value}}" required class="input flex-1 font-mono text-sm">
|
||||||
|
<button type="submit" class="btn-primary text-sm">Save</button>
|
||||||
|
<button type="button" @click="editing = false" class="text-gray-500 hover:text-gray-700 text-sm">Cancel</button>
|
||||||
|
</form>
|
||||||
|
</td>
|
||||||
|
</template>
|
||||||
</tr>
|
</tr>
|
||||||
{{end}}
|
{{end}}
|
||||||
</tbody>
|
</tbody>
|
||||||
@@ -185,22 +225,46 @@
|
|||||||
</thead>
|
</thead>
|
||||||
<tbody class="table-body">
|
<tbody class="table-body">
|
||||||
{{range .Volumes}}
|
{{range .Volumes}}
|
||||||
<tr>
|
<tr x-data="{ editing: false }">
|
||||||
<td class="font-mono">{{.HostPath}}</td>
|
<template x-if="!editing">
|
||||||
<td class="font-mono">{{.ContainerPath}}</td>
|
<td class="font-mono">{{.HostPath}}</td>
|
||||||
<td>
|
</template>
|
||||||
{{if .ReadOnly}}
|
<template x-if="!editing">
|
||||||
<span class="badge-neutral">Read-only</span>
|
<td class="font-mono">{{.ContainerPath}}</td>
|
||||||
{{else}}
|
</template>
|
||||||
<span class="badge-info">Read-write</span>
|
<template x-if="!editing">
|
||||||
{{end}}
|
<td>
|
||||||
</td>
|
{{if .ReadOnly}}
|
||||||
<td class="text-right">
|
<span class="badge-neutral">Read-only</span>
|
||||||
<form method="POST" action="/apps/{{$.App.ID}}/volumes/{{.ID}}/delete" class="inline" x-data="confirmAction('Delete this volume mount?')" @submit="confirm($event)">
|
{{else}}
|
||||||
{{ .CSRFField }}
|
<span class="badge-info">Read-write</span>
|
||||||
<button type="submit" class="text-error-500 hover:text-error-700 text-sm">Delete</button>
|
{{end}}
|
||||||
</form>
|
</td>
|
||||||
</td>
|
</template>
|
||||||
|
<template x-if="!editing">
|
||||||
|
<td class="text-right">
|
||||||
|
<button @click="editing = true" class="text-primary-600 hover:text-primary-800 text-sm mr-2">Edit</button>
|
||||||
|
<form method="POST" action="/apps/{{$.App.ID}}/volumes/{{.ID}}/delete" class="inline" x-data="confirmAction('Delete this volume mount?')" @submit="confirm($event)">
|
||||||
|
{{ .CSRFField }}
|
||||||
|
<button type="submit" class="text-error-500 hover:text-error-700 text-sm">Delete</button>
|
||||||
|
</form>
|
||||||
|
</td>
|
||||||
|
</template>
|
||||||
|
<template x-if="editing">
|
||||||
|
<td colspan="4">
|
||||||
|
<form method="POST" action="/apps/{{$.App.ID}}/volumes/{{.ID}}/edit" class="flex flex-col sm:flex-row gap-2 items-center">
|
||||||
|
{{ .CSRFField }}
|
||||||
|
<input type="text" name="host_path" value="{{.HostPath}}" required class="input flex-1 font-mono text-sm" placeholder="/host/path">
|
||||||
|
<input type="text" name="container_path" value="{{.ContainerPath}}" required class="input flex-1 font-mono text-sm" placeholder="/container/path">
|
||||||
|
<label class="flex items-center gap-2 text-sm text-gray-600 whitespace-nowrap">
|
||||||
|
<input type="checkbox" name="readonly" value="1" {{if .ReadOnly}}checked{{end}} class="rounded border-gray-300 text-primary-600 focus:ring-primary-500">
|
||||||
|
Read-only
|
||||||
|
</label>
|
||||||
|
<button type="submit" class="btn-primary text-sm">Save</button>
|
||||||
|
<button type="button" @click="editing = false" class="text-gray-500 hover:text-gray-700 text-sm">Cancel</button>
|
||||||
|
</form>
|
||||||
|
</td>
|
||||||
|
</template>
|
||||||
</tr>
|
</tr>
|
||||||
{{end}}
|
{{end}}
|
||||||
</tbody>
|
</tbody>
|
||||||
|
|||||||
Reference in New Issue
Block a user