sneak/upaas
1
0
Fork 0
Code Issues 21 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Fix all golangci-lint issues (closes #32) #51

Merged
sneak merged 2 commits from :fix/lint-cleanup into main 2026-02-16 09:06:09 +01:00
Conversation 2 Commits 2 Files Changed 2 +17 -15
clawbot commented 2026-02-16 07:10:18 +01:00
Collaborator
Copy Link

Resolves #32

Changes

Fixes the remaining testpackage lint issue by moving tail_validation_test.go from package handlers to package handlers_test, using an export bridge (export_test.go) for unexported symbols.

Results

Before: 1 lint issue (testpackage)
After: 0 lint issues

Tests: All passing

ok  git.eeqj.de/sneak/upaas/internal/handlers  0.405s
(all packages pass)
Resolves #32 ## Changes Fixes the remaining `testpackage` lint issue by moving `tail_validation_test.go` from `package handlers` to `package handlers_test`, using an export bridge (`export_test.go`) for unexported symbols. ## Results **Before:** 1 lint issue (`testpackage`) **After:** 0 lint issues **Tests:** All passing ``` ok git.eeqj.de/sneak/upaas/internal/handlers 0.405s (all packages pass) ```
clawbot added 1 commit 2026-02-16 07:10:18 +01:00
sneak commented 2026-02-16 07:11:57 +01:00
Owner
Copy Link

don't wrap it, just rename the original function

don't wrap it, just rename the original function
clawbot force-pushed fix/lint-cleanup from 8417f8f795 to a80b7ac0a6 2026-02-16 07:14:16 +01:00 Compare
clawbot commented 2026-02-16 07:14:21 +01:00
Author
Collaborator
Copy Link

Updated per review: exported SanitizeTail and DefaultLogTail directly by renaming them (no wrapper). Deleted export_test.go. Test and lint both pass:

  • make test: all passing
  • golangci-lint run ./...: 0 issues
Updated per review: exported `SanitizeTail` and `DefaultLogTail` directly by renaming them (no wrapper). Deleted `export_test.go`. Test and lint both pass: - `make test`: all passing - `golangci-lint run ./...`: 0 issues
sneak merged commit e2ad42f0ac into main 2026-02-16 09:06:09 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
notplanned

   
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
notplanned
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sneak/upaas#51
No description provided.
Delete Branch ":fix/lint-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?