fix: set DestroySession MaxAge to -1 instead of -1*time.Second (closes #39) #50

clawbot · 2026-02-16T07:08:19+01:00

clawbot commented

2026-02-16 07:08:19 +01:00

Summary

Fixes the DestroySession method which was setting MaxAge = -1 * int(time.Second) (resulting in -1000000000) instead of simply -1.

The gorilla/sessions MaxAge field expects a value in seconds. The previous code multiplied by time.Second (nanoseconds), which worked by accident since any negative value deletes the cookie, but was semantically incorrect.

Changes

internal/service/auth/auth.go: Changed MaxAge = -1 * int(time.Second) to MaxAge = -1; removed unused time import
internal/service/auth/auth_test.go: Added TestDestroySessionMaxAge test

(closes #39)

## Summary Fixes the `DestroySession` method which was setting `MaxAge = -1 * int(time.Second)` (resulting in `-1000000000`) instead of simply `-1`. The gorilla/sessions `MaxAge` field expects a value in **seconds**. The previous code multiplied by `time.Second` (nanoseconds), which worked by accident since any negative value deletes the cookie, but was semantically incorrect. ## Changes - `internal/service/auth/auth.go`: Changed `MaxAge = -1 * int(time.Second)` to `MaxAge = -1`; removed unused `time` import - `internal/service/auth/auth_test.go`: Added `TestDestroySessionMaxAge` test (closes #39)

sneak was assigned by clawbot

2026-02-16 07:08:19 +01:00

clawbot added 1 commit 2026-02-16 07:08:20 +01:00

fix: set DestroySession MaxAge to -1 instead of -1*time.Second (closes #39 ) cdd7e3fd3a

The gorilla/sessions MaxAge field expects seconds, not nanoseconds.
Previously MaxAge was set to -1000000000 (-1 * time.Second in nanoseconds),
which worked by accident since any negative value deletes the cookie.
Changed to the conventional value of -1.

clawbot commented

2026-02-16 07:08:27 +01:00

Test Results ✅

All tests pass:

ok  git.eeqj.de/sneak/upaas/internal/service/auth  coverage: 70.7%

All other packages also pass (database, docker, handlers, middleware, models, app, webhook, ssh).

Lint Results ✅

No new lint issues. One pre-existing issue in internal/handlers/tail_validation_test.go (wrong package name) — not related to this change.

## Test Results ✅ All tests pass: ``` ok git.eeqj.de/sneak/upaas/internal/service/auth coverage: 70.7% ``` All other packages also pass (database, docker, handlers, middleware, models, app, webhook, ssh). ## Lint Results ✅ No new lint issues. One pre-existing issue in `internal/handlers/tail_validation_test.go` (wrong package name) — not related to this change.

sneak merged commit 07ac71974c into main

2026-02-16 07:09:26 +01:00

sneak referenced this issue from a commit

2026-02-16 07:09:27 +01:00

Merge pull request 'fix: set DestroySession MaxAge to -1 instead of -1*time.Second (closes #39)' (#50) from clawbot/upaas:fix/destroy-session-maxage into main

Sign in to join this conversation.

No reviewers