Merge pull request 'tidy' (#148 ) from fix/tidy into main

Reviewed-on: #148
tidy
2026-02-26 13:55:28 +01:00 · 2026-02-26 19:52:09 +07:00 · 2026-02-26 12:07:42 +01:00 · 2026-02-26 02:56:27 -08:00 · 2026-02-26 02:56:00 -08:00 · 2026-02-26 11:53:14 +01:00
4 changed files with 24 additions and 15 deletions
--- a/.gitea/workflows/check.yml
+++ b/.gitea/workflows/check.yml
@@ -10,17 +10,7 @@ jobs:
  check:
    runs-on: ubuntu-latest
    steps:
-      - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
+      - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4, 2024-10-13

-      - uses: actions/setup-go@40f1582b2485089dde7abd97c1529aa768e1baff # v5
-        with:
-          go-version-file: go.mod
-
-      - name: Install golangci-lint
-        run: go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@5d1e709b7be35cb2025444e19de266b056b7b7ee # v2.10.1
-
-      - name: Install goimports
-        run: go install golang.org/x/tools/cmd/goimports@009367f5c17a8d4c45a961a3a509277190a9a6f0 # v0.42.0
-
-      - name: Run make check
-        run: make check
+      - name: Build (runs make check inside Dockerfile)
+        run: docker build .
--- a/go.mod
+++ b/go.mod
@@ -19,6 +19,7 @@ require (
 	github.com/stretchr/testify v1.11.1
 	go.uber.org/fx v1.24.0
 	golang.org/x/crypto v0.46.0
+	golang.org/x/time v0.12.0
 )

 require (
@@ -74,7 +75,6 @@ require (
 	go.yaml.in/yaml/v3 v3.0.4 // indirect
 	golang.org/x/sys v0.39.0 // indirect
 	golang.org/x/text v0.32.0 // indirect
-	golang.org/x/time v0.12.0 // indirect
 	google.golang.org/protobuf v1.36.10 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 	gotest.tools/v3 v3.5.2 // indirect
--- a/internal/handlers/handlers_test.go
+++ b/internal/handlers/handlers_test.go
@@ -404,6 +404,25 @@ func TestHandleDashboard(t *testing.T) {
 		assert.Equal(t, http.StatusOK, recorder.Code)
 		assert.Contains(t, recorder.Body.String(), "Applications")
 	})
+
+	t.Run("renders dashboard with apps without crashing on CSRFField", func(t *testing.T) {
+		t.Parallel()
+
+		testCtx := setupTestHandlers(t)
+
+		// Create an app so the template iterates over AppStats and hits .CSRFField
+		createTestApp(t, testCtx, "csrf-test-app")
+
+		request := httptest.NewRequest(http.MethodGet, "/", nil)
+		recorder := httptest.NewRecorder()
+
+		handler := testCtx.handlers.HandleDashboard()
+		handler.ServeHTTP(recorder, request)
+
+		assert.Equal(t, http.StatusOK, recorder.Code,
+			"dashboard should not 500 when apps exist (CSRFField must be accessible)")
+		assert.Contains(t, recorder.Body.String(), "csrf-test-app")
+	})
 }

 func TestHandleAppNew(t *testing.T) {
--- a/templates/dashboard.html
+++ b/templates/dashboard.html
@@ -69,7 +69,7 @@
                            <a href="/apps/{{.App.ID}}" class="btn-text text-sm py-1 px-2">View</a>
                            <a href="/apps/{{.App.ID}}/edit" class="btn-secondary text-sm py-1 px-2">Edit</a>
                            <form method="POST" action="/apps/{{.App.ID}}/deploy" class="inline">
-                {{ .CSRFField }}
+                {{ $.CSRFField }}
                                <button type="submit" class="btn-success text-sm py-1 px-2">Deploy</button>
                            </form>
                        </div>
Author	SHA1	Message	Date
Jeffrey Paul	578c6ec842	Merge pull request 'tidy' (#148 ) from fix/tidy into main All checks were successful Check / check (push) Successful in 2m24s Details Reviewed-on: #148	2026-02-26 13:55:28 +01:00
sneak	1c2bf80d7d	tidy All checks were successful Check / check (pull_request) Successful in 2m32s Details	2026-02-26 19:52:09 +07:00
Jeffrey Paul	019ba7fe1f	Merge pull request 'Fix dashboard CSRFField crash (closes #146 )' (#147 ) from fix/dashboard-csrf-field into main All checks were successful Check / check (push) Successful in 2m24s Details Reviewed-on: #147	2026-02-26 12:07:42 +01:00
user	c22a2877d5	fix: pass CSRFField to dashboard template (closes #146 ) All checks were successful Check / check (pull_request) Successful in 2m30s Details	2026-02-26 02:56:27 -08:00
user	43cde0eefd	test: add failing test for dashboard CSRFField (refs #146 )	2026-02-26 02:56:00 -08:00
Jeffrey Paul	b1c6b93d8e	Merge pull request 'fix: simplify CI to docker build only (closes #130 )' (#131 ) from fix/ci-docker-build-only into main Some checks are pending Check / check (push) Waiting to run Details Reviewed-on: #131	2026-02-26 11:53:14 +01:00
Jeffrey Paul	1875792ebe	Merge branch 'main' into fix/ci-docker-build-only All checks were successful Check / check (pull_request) Successful in 2m47s Details	2026-02-26 11:53:03 +01:00
Jeffrey Paul	7bbaa1d08a	Merge pull request 'Fix 1.0 audit bugs (closes #120 , closes #121 , closes #122 , closes #123 , closes #124 , closes #125 )' (#126 ) from fix/audit-bugs-120-125 into main Some checks are pending Check / check (push) Waiting to run Details Reviewed-on: #126	2026-02-26 11:52:54 +01:00
clawbot	fb866af4e5	simplify CI to docker build only (refs #130 ) Some checks failed Check / check (pull_request) Failing after 4s Details The Dockerfile already runs make check, so the CI action only needs to run docker build. Remove go setup, linter installation, and direct make check invocation from the workflow.	2026-02-26 02:11:15 -08:00