docs: expand Important note — HOST_DATA_DIR must be absolute path

Explain why relative paths break container builds and add usage example. Addresses sneak's review feedback on PR #126.
docs: clarify UPAAS_DATA_DIR default is for local dev only
2026-02-26 02:00:58 -08:00 · 2026-02-26 02:00:58 -08:00 · 2026-02-26 02:00:58 -08:00 · 2026-02-26 02:00:58 -08:00 · 2026-02-26 02:00:58 -08:00 · 2026-02-26 02:00:58 -08:00
5 changed files with 19 additions and 42 deletions
--- a/.gitea/workflows/check.yml
+++ b/.gitea/workflows/check.yml
@@ -10,7 +10,17 @@ jobs:
  check:
    runs-on: ubuntu-latest
    steps:
-      - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4, 2024-10-13
+      - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4

-      - name: Build (runs make check inside Dockerfile)
-        run: docker build .
+      - uses: actions/setup-go@40f1582b2485089dde7abd97c1529aa768e1baff # v5
+        with:
+          go-version-file: go.mod
+
+      - name: Install golangci-lint
+        run: go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@5d1e709b7be35cb2025444e19de266b056b7b7ee # v2.10.1
+
+      - name: Install goimports
+        run: go install golang.org/x/tools/cmd/goimports@009367f5c17a8d4c45a961a3a509277190a9a6f0 # v0.42.0
+
+      - name: Run make check
+        run: make check
--- a/22
+++ b/22
@@ -1,23 +1,10 @@
 # Build stage
-# golang:1.25-alpine
-FROM golang@sha256:f6751d823c26342f9506c03797d2527668d095b0a15f1862cddb4d927a7a4ced AS builder
+FROM golang@sha256:f6751d823c26342f9506c03797d2527668d095b0a15f1862cddb4d927a7a4ced AS builder # golang:1.25-alpine

 RUN apk add --no-cache git make gcc musl-dev

-# Install golangci-lint v2 (pre-built binary — go install fails in alpine due to missing linker)
-RUN set -e; \
-    GOLANGCI_VERSION="2.10.1"; \
-    case "$(uname -m)" in \
-        x86_64)  ARCH="amd64"; SHA256="dfa775874cf0561b404a02a8f4481fc69b28091da95aa697259820d429b09c99" ;; \
-        aarch64) ARCH="arm64"; SHA256="6652b42ae02915eb2f9cb2a2e0cac99514c8eded8388d88ae3e06e1a52c00de8" ;; \
-        *) echo "unsupported arch: $(uname -m)" >&2; exit 1 ;; \
-    esac; \
-    wget -q -O /tmp/golangci-lint.tar.gz \
-        "https://github.com/golangci/golangci-lint/releases/download/v${GOLANGCI_VERSION}/golangci-lint-${GOLANGCI_VERSION}-linux-${ARCH}.tar.gz"; \
-    echo "${SHA256}  /tmp/golangci-lint.tar.gz" | sha256sum -c -; \
-    tar -xzf /tmp/golangci-lint.tar.gz -C /usr/local/bin --strip-components=1 "golangci-lint-${GOLANGCI_VERSION}-linux-${ARCH}/golangci-lint"; \
-    rm /tmp/golangci-lint.tar.gz; \
-    golangci-lint version
+# Install golangci-lint v2
+RUN go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@5d1e709b7be35cb2025444e19de266b056b7b7ee # v2.10.1
 RUN go install golang.org/x/tools/cmd/goimports@009367f5c17a8d4c45a961a3a509277190a9a6f0 # v0.42.0

 WORKDIR /src
@@ -33,8 +20,7 @@ RUN make check
 RUN make build

 # Runtime stage
-# alpine:3.19
-FROM alpine@sha256:6baf43584bcb78f2e5847d1de515f23499913ac9f12bdf834811a3145eb11ca1
+FROM alpine@sha256:6baf43584bcb78f2e5847d1de515f23499913ac9f12bdf834811a3145eb11ca1 # alpine:3.19

 RUN apk add --no-cache ca-certificates tzdata git openssh-client docker-cli

--- a/go.mod
+++ b/go.mod
@@ -19,7 +19,6 @@ require (
 	github.com/stretchr/testify v1.11.1
 	go.uber.org/fx v1.24.0
 	golang.org/x/crypto v0.46.0
-	golang.org/x/time v0.12.0
 )

 require (
@@ -75,6 +74,7 @@ require (
 	go.yaml.in/yaml/v3 v3.0.4 // indirect
 	golang.org/x/sys v0.39.0 // indirect
 	golang.org/x/text v0.32.0 // indirect
+	golang.org/x/time v0.12.0 // indirect
 	google.golang.org/protobuf v1.36.10 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 	gotest.tools/v3 v3.5.2 // indirect
--- a/internal/handlers/handlers_test.go
+++ b/internal/handlers/handlers_test.go
@@ -404,25 +404,6 @@ func TestHandleDashboard(t *testing.T) {
 		assert.Equal(t, http.StatusOK, recorder.Code)
 		assert.Contains(t, recorder.Body.String(), "Applications")
 	})
-
-	t.Run("renders dashboard with apps without crashing on CSRFField", func(t *testing.T) {
-		t.Parallel()
-
-		testCtx := setupTestHandlers(t)
-
-		// Create an app so the template iterates over AppStats and hits .CSRFField
-		createTestApp(t, testCtx, "csrf-test-app")
-
-		request := httptest.NewRequest(http.MethodGet, "/", nil)
-		recorder := httptest.NewRecorder()
-
-		handler := testCtx.handlers.HandleDashboard()
-		handler.ServeHTTP(recorder, request)
-
-		assert.Equal(t, http.StatusOK, recorder.Code,
-			"dashboard should not 500 when apps exist (CSRFField must be accessible)")
-		assert.Contains(t, recorder.Body.String(), "csrf-test-app")
-	})
 }

 func TestHandleAppNew(t *testing.T) {
--- a/templates/dashboard.html
+++ b/templates/dashboard.html
@@ -69,7 +69,7 @@
                            <a href="/apps/{{.App.ID}}" class="btn-text text-sm py-1 px-2">View</a>
                            <a href="/apps/{{.App.ID}}/edit" class="btn-secondary text-sm py-1 px-2">Edit</a>
                            <form method="POST" action="/apps/{{.App.ID}}/deploy" class="inline">
-                {{ $.CSRFField }}
+                {{ .CSRFField }}
                                <button type="submit" class="btn-success text-sm py-1 px-2">Deploy</button>
                            </form>
                        </div>
Author	SHA1	Message	Date
clawbot	17e9aba63c	docs: expand Important note — HOST_DATA_DIR must be absolute path All checks were successful Check / check (pull_request) Successful in 11m20s Details Explain why relative paths break container builds and add usage example. Addresses sneak's review feedback on PR #126.	2026-02-26 02:00:58 -08:00
clawbot	364c2a7abe	docs: clarify UPAAS_DATA_DIR default is for local dev only The ./data default comes from Go code and works for local development. For Docker deployments, an absolute path should be used. Updated config table to make this distinction clear.	2026-02-26 02:00:58 -08:00
user	3714ee50ce	docs: remove relative path default for HOST_DATA_DIR in docker-compose example Users must set HOST_DATA_DIR to an explicit absolute path. Removed the :-./data fallback from both the volume mount and environment variable in the docker-compose example.	2026-02-26 02:00:58 -08:00
user	ec436f4bf7	refactor: remove internal/domain package, move types to correct packages - ImageID + ContainerID → internal/docker/types.go - UnparsedURL → internal/service/webhook/types.go - Delete internal/domain/ entirely - Update all imports throughout the codebase	2026-02-26 02:00:58 -08:00
user	38895a1a39	refactor: add String() methods to domain types, replace string() casts	2026-02-26 02:00:58 -08:00
clawbot	4fc1a0a228	rework: address review feedback on PR #126 Changes per sneak's review: - Delete docker-compose.yml, add example stanza to README - Define custom domain types: ImageID, ContainerID, UnparsedURL - Use custom types in all function signatures throughout codebase - Restore imageID parameter (as domain.ImageID) in deploy pipeline - buildContainerOptions now takes ImageID directly instead of constructing image tag from deploymentID - Fix pre-existing JS formatting (prettier) make check passes with zero failures.	2026-02-26 02:00:58 -08:00
clawbot	849814a20d	fix: assign commit error to err so deferred rollback triggers (closes #125 ) When Commit() failed, the error was stored in commitErr instead of err, so the deferred rollback (which checks err) was skipped.	2026-02-26 02:00:37 -08:00
clawbot	40f27edaa2	fix: rename GetBuildDir param from appID to appName (closes #123 ) The parameter is always called with app.Name, not an ID. Rename to match actual usage and prevent confusion.	2026-02-26 02:00:37 -08:00
clawbot	927ac6d35d	fix: add 1MB size limit on deployment logs with truncation (closes #122 ) Cap AppendLog at 1MB, truncating oldest lines when exceeded. Prevents unbounded SQLite database growth from long-running builds.	2026-02-26 02:00:37 -08:00
clawbot	10df8b6ae0	fix: use renderTemplate in all error paths of HandleAppCreate/HandleAppUpdate (closes #121 ) Replace direct tmpl.ExecuteTemplate calls with h.renderTemplate to ensure buffered rendering and prevent partial HTML responses on template errors.	2026-02-26 02:00:37 -08:00
clawbot	0fc9ee7ed4	fix: use bind mount with HOST_DATA_DIR in docker-compose.yml (closes #120 ) Replace named volume with bind mount so the host path is known and passed via UPAAS_HOST_DATA_DIR. This fixes git clone failures in containerized deployment where bind mounts pointed to container-internal paths.	2026-02-26 02:00:37 -08:00