Revert "Say that a deploy keeps only an app's volumes when the app has none"

The owner asked for this commit to be reverted in full
(#254 (comment)). It
removes the no-volume-mounts sentence from the app page and the deploy
log, the constant and tests behind it, the README sentence, and its
TODO.md entry. Later TODO.md entries stay. #248
stays closed as rejected.

Model: opus-5-5

internal/handlers/app.go

@@ -21,7 +21,6 @@ import (
 	"sneak.berlin/go/upaas/internal/database"
 	"sneak.berlin/go/upaas/internal/models"
 	"sneak.berlin/go/upaas/internal/service/app"
-	"sneak.berlin/go/upaas/internal/service/deploy"
 	"sneak.berlin/go/upaas/templates"
 )
 
@@ -195,7 +194,6 @@ func (h *Handlers) HandleAppDetail() http.HandlerFunc {
 			"EnvVars":          envVars,
 			"Labels":           labels,
 			"Volumes":          volumes,
-			"NoVolumesWarning": deploy.NoVolumesWarning,
 			"Ports":            ports,
 			"Deployments":      deployments,
 			"LatestDeployment": latestDeployment,

internal/handlers/app_no_volumes_test.go

@@ -1,45 +0,0 @@
-package handlers_test
-
-import (
-	"net/http"
-	"net/http/httptest"
-	"testing"
-
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
-
-	"sneak.berlin/go/upaas/internal/models"
-	"sneak.berlin/go/upaas/internal/service/deploy"
-)
-
-// TestAppPageSaysFilesAreLostOnlyWhenAppHasNoVolumes checks that the app page
-// shows deploy.NoVolumesWarning until the app gets a volume mount.
-func TestAppPageSaysFilesAreLostOnlyWhenAppHasNoVolumes(t *testing.T) {
-	t.Parallel()
-
-	testCtx := setupTestHandlers(t)
-	createdApp := createTestApp(t, testCtx, "no-volumes-app")
-
-	renderAppPage := func() string {
-		request := httptest.NewRequestWithContext(
-			t.Context(), http.MethodGet, "/apps/"+createdApp.ID, nil,
-		)
-		request = addChiURLParams(request, map[string]string{"id": createdApp.ID})
-		recorder := httptest.NewRecorder()
-
-		testCtx.handlers.HandleAppDetail().ServeHTTP(recorder, request)
-		require.Equal(t, http.StatusOK, recorder.Code)
-
-		return recorder.Body.String()
-	}
-
-	assert.Contains(t, renderAppPage(), deploy.NoVolumesWarning)
-
-	volume := models.NewVolume(testCtx.database)
-	volume.AppID = createdApp.ID
-	volume.HostPath = "/srv/no-volumes-app"
-	volume.ContainerPath = "/data"
-	require.NoError(t, volume.Save(t.Context()))
-
-	assert.NotContains(t, renderAppPage(), deploy.NoVolumesWarning)
-}