sneak/routewatch
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

Add missing standard files: LICENSE, .editorconfig, and a CI workflow #1

New Issue
Open
opened 2026-07-26 20:12:19 +02:00 by clawbot · 2 comments
clawbot commented 2026-07-26 20:12:19 +02:00
Collaborator
Copy Link
Copy Source

routewatch is missing several standard repo files that its siblings have. It already has .golangci.yml, script/, Dockerfile, and REPO_POLICIES.md.

Definition of done

  1. Add a LICENSE matching the one used across our other repos (copy the exact license text from a sibling such as sneak/vaultik or sneak/dnswatcher; if siblings disagree on license, STOP and ask rather than guessing).
  2. Add a standard .editorconfig matching our other Go repos (e.g. sneak/dnswatcher).
  3. Add .gitea/workflows/check.yml that runs script/cibuild on push, mirroring a conformant repo (e.g. sneak/dnswatcher).
  4. make check and docker build . stay green.

The finishing commit's title must end with (closes #N) referencing this issue.

routewatch is missing several standard repo files that its siblings have. It already has `.golangci.yml`, `script/`, `Dockerfile`, and `REPO_POLICIES.md`. ## Definition of done 1. Add a `LICENSE` matching the one used across our other repos (copy the exact license text from a sibling such as `sneak/vaultik` or `sneak/dnswatcher`; if siblings disagree on license, STOP and ask rather than guessing). 2. Add a standard `.editorconfig` matching our other Go repos (e.g. `sneak/dnswatcher`). 3. Add `.gitea/workflows/check.yml` that runs `script/cibuild` on push, mirroring a conformant repo (e.g. `sneak/dnswatcher`). 4. `make check` and `docker build .` stay green. The finishing commit's title must end with ` (closes #N)` referencing this issue.
clawbot commented 2026-07-26 20:44:40 +02:00
Author
Collaborator
Copy Link
Copy Source

Note for your triage: the local ~/dev/routewatch clone has an unpushed local branch repo-policies-compliance with 3 commits that is NOT on the remote and appears stale — it adds LICENSE and .editorconfig but also deletes the entire current script/ directory and guts REPO_POLICIES.md/README.md, i.e. it was branched before the scripts-to-rule-them-all adoption that is now on main. I did not touch it; it is at-risk (unpushed) but looks superseded by current main. Recommend discarding it after a look. Meanwhile I am doing this issue fresh off current origin/main in an isolated worktree (adds LICENSE + .editorconfig + the CI workflow without disturbing that branch).

Note for your triage: the local `~/dev/routewatch` clone has an unpushed local branch `repo-policies-compliance` with 3 commits that is NOT on the remote and appears stale — it adds `LICENSE` and `.editorconfig` but also deletes the entire current `script/` directory and guts `REPO_POLICIES.md`/`README.md`, i.e. it was branched before the scripts-to-rule-them-all adoption that is now on `main`. I did not touch it; it is at-risk (unpushed) but looks superseded by current `main`. Recommend discarding it after a look. Meanwhile I am doing this issue fresh off current `origin/main` in an isolated worktree (adds `LICENSE` + `.editorconfig` + the CI workflow without disturbing that branch).
clawbot commented 2026-07-26 20:56:14 +02:00
Author
Collaborator
Copy Link
Copy Source

Two blockers found; needs your input before this can land green.

  1. LICENSE is not determinable without a decision — our repos diverge: sneak/dnswatcher has NO license file; sneak/vaultik is MIT (Copyright (c) 2025 Jeffrey Paul sneak@sneak.berlin); sneak/netwatch is MIT (Copyright (c) 2026 @sneak (https://sneak.berlin) — different holder and year); sneak/secret is WTFPL. Which license and exact copyright line should routewatch carry?

  2. make check is already RED on origin/main, independent of this issue: TestRouteWatchLiveFeed (internal/routewatch/app_integration_test.go) connects to the live RIS BGP feed and the race detector reports a data race. Since the CI workflow this issue asks for runs script/cibuild (= make check) on every push, adding it would make CI red on arrival until that test is fixed or de-flaked. That flaky/racy test probably deserves its own issue.

The other two files are unambiguous and ready to drop in (.editorconfig verbatim from dnswatcher; .gitea/workflows/check.yml mirroring dnswatcher's script/cibuild workflow). Once you decide the license and the racy test is handled, I'll land all three with (closes #1). Assigning to you.

Two blockers found; needs your input before this can land green. 1. LICENSE is not determinable without a decision — our repos diverge: `sneak/dnswatcher` has NO license file; `sneak/vaultik` is MIT (`Copyright (c) 2025 Jeffrey Paul sneak@sneak.berlin`); `sneak/netwatch` is MIT (`Copyright (c) 2026 @sneak (https://sneak.berlin)` — different holder and year); `sneak/secret` is WTFPL. Which license and exact copyright line should routewatch carry? 2. `make check` is already RED on `origin/main`, independent of this issue: `TestRouteWatchLiveFeed` (`internal/routewatch/app_integration_test.go`) connects to the live RIS BGP feed and the race detector reports a data race. Since the CI workflow this issue asks for runs `script/cibuild` (= `make check`) on every push, adding it would make CI red on arrival until that test is fixed or de-flaked. That flaky/racy test probably deserves its own issue. The other two files are unambiguous and ready to drop in (`.editorconfig` verbatim from dnswatcher; `.gitea/workflows/check.yml` mirroring dnswatcher's `script/cibuild` workflow). Once you decide the license and the racy test is handled, I'll land all three with `(closes #1)`. Assigning to you.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/routewatch#1