sneak/routewatch
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

TestRouteWatchLiveFeed is network-flaky; make make check deterministic #2

New Issue
Open
opened 2026-08-04 02:27:58 +02:00 by clawbot · 0 comments
clawbot commented 2026-08-04 02:27:58 +02:00
Collaborator
Copy Link

TestRouteWatchLiveFeed streams the live RIPE RIS feed for ~5s and is inherently network-flaky (it also carries a data race on live-feed data), so make check is nondeterministic on main and in CI.

Definition of done

  1. The live-network test no longer runs by default under make check / CI: guard it behind an opt-in (a network build tag, or a testing.Short() skip with -short wired into script/test), so the default run is deterministic and offline.
  2. The live test remains runnable on demand (documented how — e.g. go test -tags network ./... or without -short).
  3. No change to production (non-test) behavior; the guard is test-only.
  4. make check is green and deterministic across repeated runs.

The finishing commit's title must end with (closes #N) referencing this issue.

`TestRouteWatchLiveFeed` streams the live RIPE RIS feed for ~5s and is inherently network-flaky (it also carries a data race on live-feed data), so `make check` is nondeterministic on `main` and in CI. ## Definition of done 1. The live-network test no longer runs by default under `make check` / CI: guard it behind an opt-in (a `network` build tag, or a `testing.Short()` skip with `-short` wired into `script/test`), so the default run is deterministic and offline. 2. The live test remains runnable on demand (documented how — e.g. `go test -tags network ./...` or without `-short`). 3. No change to production (non-test) behavior; the guard is test-only. 4. `make check` is green and deterministic across repeated runs. The finishing commit's title must end with ` (closes #N)` referencing this issue.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/routewatch#2
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?