Compare commits
8
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
6422d9fa0c | ||
|
|
057e0bd9a9 | ||
|
|
87a3bc115e | ||
|
|
d28a59023a | ||
|
|
1ac24669d3 | ||
|
|
6187ac8503 | ||
|
|
f2a9e90625 | ||
|
|
df9e23d503 |
@@ -0,0 +1,28 @@
|
|||||||
|
# Docker does not read .gitignore, and a pattern here matches from the root of
|
||||||
|
# the build context only: a pattern meant for every directory needs `**/`.
|
||||||
|
|
||||||
|
.git
|
||||||
|
|
||||||
|
# Local build and debug output: `make build`, `make run`, `make asupdate`, test
|
||||||
|
# binaries, coverage profiles and source archives.
|
||||||
|
/bin
|
||||||
|
/log.txt
|
||||||
|
/out
|
||||||
|
/pkg/asinfo/asdata.json
|
||||||
|
**/*.tar.zst
|
||||||
|
**/*.test
|
||||||
|
**/*.out
|
||||||
|
**/*.tmp
|
||||||
|
|
||||||
|
# Local databases and secrets. The image carries a source archive of the whole
|
||||||
|
# build context, so these would otherwise ship inside it.
|
||||||
|
**/*.db
|
||||||
|
**/*.db-journal
|
||||||
|
**/*.db-wal
|
||||||
|
**/.env
|
||||||
|
|
||||||
|
# A local Go workspace points at directories outside the build context.
|
||||||
|
/go.work
|
||||||
|
/go.work.sum
|
||||||
|
|
||||||
|
**/.DS_Store
|
||||||
+4
-4
@@ -79,8 +79,8 @@ RUN chown -R routewatch:routewatch /app
|
|||||||
ENV XDG_DATA_HOME=/var/lib
|
ENV XDG_DATA_HOME=/var/lib
|
||||||
|
|
||||||
# Cap the Go heap at 1.5 GiB so the runtime collects harder before the
|
# Cap the Go heap at 1.5 GiB so the runtime collects harder before the
|
||||||
# container's memory limit is reached. runuser preserves this the way it does
|
# container's memory limit is reached. setpriv in the entrypoint preserves this
|
||||||
# XDG_DATA_HOME above.
|
# the way it does XDG_DATA_HOME above.
|
||||||
ENV GOMEMLIMIT=1536MiB
|
ENV GOMEMLIMIT=1536MiB
|
||||||
|
|
||||||
# Cap glibc's malloc arenas. The SQLite C library allocates and frees millions
|
# Cap glibc's malloc arenas. The SQLite C library allocates and frees millions
|
||||||
@@ -96,8 +96,8 @@ EXPOSE 8080
|
|||||||
|
|
||||||
COPY ./entrypoint.sh /entrypoint.sh
|
COPY ./entrypoint.sh /entrypoint.sh
|
||||||
|
|
||||||
# Health check using the health endpoint
|
# Health check using the health endpoint, on the port PORT names
|
||||||
HEALTHCHECK --interval=30s --timeout=5s --start-period=10s --retries=3 \
|
HEALTHCHECK --interval=30s --timeout=5s --start-period=10s --retries=3 \
|
||||||
CMD curl -sf http://localhost:8080/.well-known/healthcheck.json || exit 1
|
CMD curl -sf "http://localhost:${PORT:-8080}/.well-known/healthcheck.json" || exit 1
|
||||||
|
|
||||||
ENTRYPOINT ["/bin/bash", "/entrypoint.sh" ]
|
ENTRYPOINT ["/bin/bash", "/entrypoint.sh" ]
|
||||||
|
|||||||
@@ -0,0 +1,21 @@
|
|||||||
|
MIT License
|
||||||
|
|
||||||
|
Copyright (c) 2026 Jeffrey Paul <sneak@sneak.berlin>
|
||||||
|
|
||||||
|
Permission is hereby granted, free of charge, to any person obtaining a copy
|
||||||
|
of this software and associated documentation files (the "Software"), to deal
|
||||||
|
in the Software without restriction, including without limitation the rights
|
||||||
|
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
||||||
|
copies of the Software, and to permit persons to whom the Software is
|
||||||
|
furnished to do so, subject to the following conditions:
|
||||||
|
|
||||||
|
The above copyright notice and this permission notice shall be included in all
|
||||||
|
copies or substantial portions of the Software.
|
||||||
|
|
||||||
|
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
||||||
|
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
||||||
|
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
||||||
|
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
||||||
|
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
||||||
|
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
||||||
|
SOFTWARE.
|
||||||
@@ -1,6 +1,9 @@
|
|||||||
# RouteWatch
|
# RouteWatch
|
||||||
|
|
||||||
RouteWatch is a real-time BGP routing table monitor that streams BGP UPDATE messages from the RIPE RIS Live service, maintains a live routing table in SQLite, and provides HTTP APIs for querying routing information.
|
RouteWatch is an MIT-licensed Go daemon by @sneak that monitors the BGP routing
|
||||||
|
table in real time: it streams BGP UPDATE messages from the RIPE RIS Live
|
||||||
|
service, maintains a live routing table in SQLite, and provides HTTP APIs for
|
||||||
|
querying routing information.
|
||||||
|
|
||||||
|
|
||||||
## Features
|
## Features
|
||||||
@@ -166,14 +169,21 @@ Configuration is handled via environment variables and OS-specific paths:
|
|||||||
|
|
||||||
| Variable | Default | Description |
|
| Variable | Default | Description |
|
||||||
|----------|----------|-------------|
|
|----------|----------|-------------|
|
||||||
| `PORT` | `8080` | HTTP server port |
|
| `PORT` | `8080` | HTTP server port, a whole number from 1 to 65535 |
|
||||||
| `DEBUG` | (empty) | Set to `routewatch` for debug logging |
|
| `DEBUG` | (empty) | Set to `routewatch` for debug logging |
|
||||||
|
| `XDG_DATA_HOME` | `/var/lib` (in the Docker image) | Base of the state directory; must be an absolute path |
|
||||||
| `GOMEMLIMIT` | `1536MiB` (in the Docker image) | Go soft memory limit; see Memory |
|
| `GOMEMLIMIT` | `1536MiB` (in the Docker image) | Go soft memory limit; see Memory |
|
||||||
| `MALLOC_ARENA_MAX` | `2` (in the Docker image) | glibc malloc arena cap; see Memory |
|
| `MALLOC_ARENA_MAX` | `2` (in the Docker image) | glibc malloc arena cap, a positive whole number; see Memory |
|
||||||
|
|
||||||
|
A variable that is set to an invalid value stops the start with an error and a
|
||||||
|
non-zero exit. An empty variable counts as unset.
|
||||||
|
|
||||||
State directory (database location):
|
State directory (database location):
|
||||||
- macOS: `~/Library/Application Support/routewatch/`
|
- macOS: `~/Library/Application Support/routewatch/`
|
||||||
- Linux: `/var/lib/routewatch/` or `~/.local/share/routewatch/`
|
- Linux: `/var/lib/berlin.sneak.app.routewatch/` when running as root,
|
||||||
|
otherwise `$XDG_DATA_HOME/berlin.sneak.app.routewatch/` (with `XDG_DATA_HOME`
|
||||||
|
unset, `~/.local/share/berlin.sneak.app.routewatch/`). In the Docker image
|
||||||
|
this is `/var/lib/berlin.sneak.app.routewatch/`.
|
||||||
|
|
||||||
## Memory
|
## Memory
|
||||||
|
|
||||||
@@ -220,6 +230,22 @@ What happens at each limit:
|
|||||||
With `DEBUG=routewatch` the daemon logs a `System stats` line every 60 seconds
|
With `DEBUG=routewatch` the daemon logs a `System stats` line every 60 seconds
|
||||||
with the goroutine count and Go memory figures.
|
with the goroutine count and Go memory figures.
|
||||||
|
|
||||||
|
## Running under upaas
|
||||||
|
|
||||||
|
What the [upaas](https://git.eeqj.de/sneak/upaas) app needs:
|
||||||
|
|
||||||
|
- Container port: `8080`.
|
||||||
|
- Volume: one, at container path `/var/lib/berlin.sneak.app.routewatch`.
|
||||||
|
- Environment: nothing is required. Leave `XDG_DATA_HOME`, `GOMEMLIMIT` and
|
||||||
|
`MALLOC_ARENA_MAX` at the image's values. `DEBUG=routewatch` is optional and
|
||||||
|
adds the `System stats` memory line to the log.
|
||||||
|
- Memory Limit: `5g`, the 5 GiB limit from Memory above. upaas sets no swap
|
||||||
|
limit, so on a host with swap Docker allows the same amount of swap again.
|
||||||
|
- Health check: the image's `HEALTHCHECK` requests
|
||||||
|
`/.well-known/healthcheck.json` on the container port. upaas reads the
|
||||||
|
container's health 60 seconds after a deploy and fails the deploy unless it
|
||||||
|
is `healthy`.
|
||||||
|
|
||||||
## Development
|
## Development
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
@@ -274,4 +300,8 @@ invoke `go test` directly without `-short`:
|
|||||||
|
|
||||||
## License
|
## License
|
||||||
|
|
||||||
See LICENSE file.
|
MIT. See [`LICENSE`](LICENSE).
|
||||||
|
|
||||||
|
## Author
|
||||||
|
|
||||||
|
[@sneak](https://sneak.berlin)
|
||||||
|
|||||||
@@ -10,19 +10,78 @@
|
|||||||
|
|
||||||
# Status
|
# Status
|
||||||
|
|
||||||
pre-1.0. No git tags. Runs in production-style Docker deployment, but
|
pre-1.0. No git tags. The Docker build runs the format check, the linter
|
||||||
the policy compliance branch (repo-policies-compliance, make check
|
and the tests, and the Gitea workflow runs that build on every push. The
|
||||||
passing, clean tree) is unmerged to main and the CI workflow is missing.
|
image sets memory ceilings for a 5 GiB container (README "Memory") and the
|
||||||
|
README says how to run it under upaas (README "Running under upaas"). A
|
||||||
|
35-hour run of `3898daa` on the live feed peaked at about 1 GiB, without a
|
||||||
|
container memory limit.
|
||||||
|
|
||||||
# Next Step
|
# Next Step
|
||||||
|
|
||||||
Merge repo-policies-compliance into main (3 commits: policy files and
|
`next` waits for sneak to merge it to `main` through
|
||||||
.gitignore, Makefile targets fmt-check/check/docker/hooks, gofmt pass),
|
https://git.eeqj.de/sneak/routewatch/pulls/6. After that, setting
|
||||||
then add .gitea/workflows/check.yml as a small follow-up commit so CI
|
routewatch up under upaas on fsn1app1 and deploying it are his
|
||||||
runs make check on main.
|
(https://git.eeqj.de/sneak/routewatch/issues/31), and so is the run under a
|
||||||
|
real 5 GiB limit (https://git.eeqj.de/sneak/routewatch/issues/3).
|
||||||
|
The other open issue is https://git.eeqj.de/sneak/routewatch/issues/30.
|
||||||
|
|
||||||
# Completed Steps
|
# Completed Steps
|
||||||
|
|
||||||
|
- 2026-09-29: the entrypoint creates the data directory if it is missing and
|
||||||
|
stops the start if a step fails; README "Running under upaas" no longer
|
||||||
|
asks for the host directory to be created first (closes #42)
|
||||||
|
- 2026-09-29: `.dockerignore` keeps `.git`, local build output, local
|
||||||
|
databases and `.env` out of the Docker build context, and so out of the
|
||||||
|
source archive in the image (closes #39)
|
||||||
|
- 2026-09-29: README first line names the MIT license and the author;
|
||||||
|
the License section now says MIT and links `LICENSE`, and an Author
|
||||||
|
section was added; this file brought up to date (closes #38)
|
||||||
|
- 2026-09-29: MIT `LICENSE` (closes #1)
|
||||||
|
- 2026-09-28: stopping the daemon while the feed is flowing no longer
|
||||||
|
panics with "send on closed channel": the read loop checks for a stop
|
||||||
|
just before handing a message to the handler queues, and a second
|
||||||
|
`Stop` no longer closes the queues again (closes #34)
|
||||||
|
- 2026-09-28: `docker stop` no longer kills the daemon 2 seconds after the
|
||||||
|
stop signal: the entrypoint switches to the `routewatch` user with
|
||||||
|
`setpriv` instead of `runuser`, so the daemon receives the signal itself
|
||||||
|
and gets the whole wait `docker stop` allows, up to its own 60-second
|
||||||
|
limit (closes #33)
|
||||||
|
- 2026-09-28: ready to run under upaas: a set but invalid `PORT`,
|
||||||
|
`XDG_DATA_HOME` or `MALLOC_ARENA_MAX` stops the start, the health
|
||||||
|
check follows `PORT`, README "Running under upaas" section (closes
|
||||||
|
#31)
|
||||||
|
- 2026-09-22: realtime in-memory database statistics: counts seeded at
|
||||||
|
startup and adjusted on every write, oldest/newest route timestamps via
|
||||||
|
index-end lookups; `/api/v1/stats` no longer scans the tables (closes
|
||||||
|
#27)
|
||||||
|
- 2026-09-21: batch writes take the write lock when their transaction
|
||||||
|
begins (`_txlock=immediate`), so they wait out a WAL checkpoint instead
|
||||||
|
of failing with "database is locked" (closes #25)
|
||||||
|
- 2026-09-21: `MALLOC_ARENA_MAX=2` in the image caps glibc malloc arenas,
|
||||||
|
so memory outside the Go runtime no longer grows with the core count
|
||||||
|
(closes #23)
|
||||||
|
- 2026-09-21: `GOMEMLIMIT=1536MiB` in the image; README Memory section
|
||||||
|
with the memory budget and the 5 GiB container limit (closes #13)
|
||||||
|
- 2026-09-21: the four handler queues hold at most 20,000 messages each,
|
||||||
|
down from 100,000 (closes #11)
|
||||||
|
- 2026-09-21: two goroutine leaks fixed: the stats handlers after a
|
||||||
|
timeout and the streamer's tickers on every reconnect (closes #12)
|
||||||
|
- 2026-09-21: parsed RIS messages no longer keep the unused `Community`
|
||||||
|
and `Raw` fields (closes #9)
|
||||||
|
- 2026-09-21: `.editorconfig`, and a Gitea workflow that runs
|
||||||
|
`script/cibuild` on every push (closes #14)
|
||||||
|
- 2026-09-21: the peering handler's AS-path map holds at most 500,000
|
||||||
|
paths and is swapped for an empty one every 30 seconds instead of copied
|
||||||
|
(closes #10)
|
||||||
|
- 2026-09-21: SQLite memory bounded across the whole connection pool: a
|
||||||
|
64 MiB page cache on each connection, 1 GiB soft and 1.5 GiB hard heap
|
||||||
|
limits (closes #8)
|
||||||
|
- 2026-09-21: the Docker build runs the format check, the linter and the
|
||||||
|
tests, linting in a separate stage on a golangci-lint image pinned by
|
||||||
|
digest (closes #5)
|
||||||
|
- 2026-09-21: `make test` skips the live-network feed test (`-short`), so
|
||||||
|
`make check` no longer depends on the network (closes #2)
|
||||||
- 2026-07-07 Adopted scripts-to-rule-them-all: `script/` entrypoints,
|
- 2026-07-07 Adopted scripts-to-rule-them-all: `script/` entrypoints,
|
||||||
Makefile shims, README Entrypoints section
|
Makefile shims, README Entrypoints section
|
||||||
- 2026-02-22: repo policy compliance: required policy files, .gitignore
|
- 2026-02-22: repo policy compliance: required policy files, .gitignore
|
||||||
@@ -41,8 +100,9 @@ runs make check on main.
|
|||||||
|
|
||||||
# Future Steps
|
# Future Steps
|
||||||
|
|
||||||
- Verify main is green after the merge: make check locally and the new
|
- Production memory under 5 GiB: whether to test under a real 5 GiB
|
||||||
CI workflow passing
|
container limit on fsn1app1 is open for sneak
|
||||||
- Review stale remote branches fix-min-time-calculation and
|
(https://git.eeqj.de/sneak/routewatch/issues/3)
|
||||||
optimize-sqlite-settings: land or delete
|
- `/api/v1/stats` answered HTTP 500 after 35 hours on the live feed, seen
|
||||||
- Clean up the tmp/ directory at the repo root: gitignore or remove
|
on `3898daa`, which predates the 2026-09-22 in-memory statistics
|
||||||
|
(https://git.eeqj.de/sneak/routewatch/issues/30)
|
||||||
|
|||||||
+14
-1
@@ -1,7 +1,20 @@
|
|||||||
#!/bin/bash
|
#!/bin/bash
|
||||||
|
set -euo pipefail
|
||||||
|
|
||||||
|
# glibc silently ignores a malformed MALLOC_ARENA_MAX, so refuse it here.
|
||||||
|
if [[ -n "${MALLOC_ARENA_MAX:-}" && ! "$MALLOC_ARENA_MAX" =~ ^[1-9][0-9]*$ ]]; then
|
||||||
|
echo "MALLOC_ARENA_MAX must be a positive whole number, got '$MALLOC_ARENA_MAX'" >&2
|
||||||
|
exit 1
|
||||||
|
fi
|
||||||
|
|
||||||
|
# Give the data directory to the routewatch user before the daemon starts,
|
||||||
|
# whether it is missing, an empty root-owned mount, or holds another uid's files.
|
||||||
|
mkdir -p /var/lib/berlin.sneak.app.routewatch
|
||||||
cd /var/lib/berlin.sneak.app.routewatch
|
cd /var/lib/berlin.sneak.app.routewatch
|
||||||
chown -R routewatch:routewatch .
|
chown -R routewatch:routewatch .
|
||||||
chmod 700 .
|
chmod 700 .
|
||||||
|
|
||||||
exec runuser -u routewatch -- /app/routewatch
|
# setpriv replaces itself with the daemon, so the daemon receives the stop
|
||||||
|
# signal directly. runuser would stay in between and kill the daemon 2 seconds
|
||||||
|
# after passing the signal on.
|
||||||
|
exec setpriv --reuid=routewatch --regid=routewatch --init-groups -- /app/routewatch
|
||||||
|
|||||||
@@ -6,6 +6,7 @@ import (
|
|||||||
"os"
|
"os"
|
||||||
"path/filepath"
|
"path/filepath"
|
||||||
"runtime"
|
"runtime"
|
||||||
|
"strconv"
|
||||||
"time"
|
"time"
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -18,6 +19,12 @@ const (
|
|||||||
|
|
||||||
// defaultRouteExpirationMinutes is the default route expiration timeout in minutes
|
// defaultRouteExpirationMinutes is the default route expiration timeout in minutes
|
||||||
defaultRouteExpirationMinutes = 5
|
defaultRouteExpirationMinutes = 5
|
||||||
|
|
||||||
|
// defaultPort is the HTTP port used when PORT is not set
|
||||||
|
defaultPort = 8080
|
||||||
|
|
||||||
|
// maxPort is the highest TCP port number
|
||||||
|
maxPort = 65535
|
||||||
)
|
)
|
||||||
|
|
||||||
// Config holds configuration for the entire application
|
// Config holds configuration for the entire application
|
||||||
@@ -25,6 +32,9 @@ type Config struct {
|
|||||||
// StateDir is the directory for all application state (database, snapshots)
|
// StateDir is the directory for all application state (database, snapshots)
|
||||||
StateDir string
|
StateDir string
|
||||||
|
|
||||||
|
// Port is the TCP port the HTTP server listens on
|
||||||
|
Port int
|
||||||
|
|
||||||
// MaxRuntime is the maximum runtime (0 = run forever)
|
// MaxRuntime is the maximum runtime (0 = run forever)
|
||||||
MaxRuntime time.Duration
|
MaxRuntime time.Duration
|
||||||
|
|
||||||
@@ -43,8 +53,14 @@ func New() (*Config, error) {
|
|||||||
return nil, fmt.Errorf("failed to determine state directory: %w", err)
|
return nil, fmt.Errorf("failed to determine state directory: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
port, err := getPort()
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
|
||||||
return &Config{
|
return &Config{
|
||||||
StateDir: stateDir,
|
StateDir: stateDir,
|
||||||
|
Port: port,
|
||||||
MaxRuntime: 0, // Run forever by default
|
MaxRuntime: 0, // Run forever by default
|
||||||
EnableBatchedDatabaseWrites: true, // Enable batching by default
|
EnableBatchedDatabaseWrites: true, // Enable batching by default
|
||||||
RouteExpirationTimeout: defaultRouteExpirationMinutes * time.Minute, // For active route monitoring
|
RouteExpirationTimeout: defaultRouteExpirationMinutes * time.Minute, // For active route monitoring
|
||||||
@@ -69,13 +85,20 @@ func getStateDirectory() (string, error) {
|
|||||||
return filepath.Join(home, "Library", "Application Support", AppIdentifier), nil
|
return filepath.Join(home, "Library", "Application Support", AppIdentifier), nil
|
||||||
|
|
||||||
case "linux", "freebsd", "openbsd", "netbsd":
|
case "linux", "freebsd", "openbsd", "netbsd":
|
||||||
|
// The XDG spec requires an absolute path; a relative one would put
|
||||||
|
// the database somewhere unexpected.
|
||||||
|
xdgData := os.Getenv("XDG_DATA_HOME")
|
||||||
|
if xdgData != "" && !filepath.IsAbs(xdgData) {
|
||||||
|
return "", fmt.Errorf("XDG_DATA_HOME must be an absolute path, got %q", xdgData)
|
||||||
|
}
|
||||||
|
|
||||||
// Unix-like: /var/lib/berlin.sneak.app.routewatch if root, else XDG_DATA_HOME
|
// Unix-like: /var/lib/berlin.sneak.app.routewatch if root, else XDG_DATA_HOME
|
||||||
if os.Geteuid() == 0 {
|
if os.Geteuid() == 0 {
|
||||||
return filepath.Join("/var/lib", AppIdentifier), nil
|
return filepath.Join("/var/lib", AppIdentifier), nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// Check XDG_DATA_HOME first
|
// Check XDG_DATA_HOME first
|
||||||
if xdgData := os.Getenv("XDG_DATA_HOME"); xdgData != "" {
|
if xdgData != "" {
|
||||||
return filepath.Join(xdgData, AppIdentifier), nil
|
return filepath.Join(xdgData, AppIdentifier), nil
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -92,6 +115,22 @@ func getStateDirectory() (string, error) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// getPort returns the HTTP port from PORT, or defaultPort when PORT is not set
|
||||||
|
func getPort() (int, error) {
|
||||||
|
value := os.Getenv("PORT")
|
||||||
|
if value == "" {
|
||||||
|
return defaultPort, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// ParseUint, unlike Atoi, refuses a sign: the health check URL cannot use "+9090"
|
||||||
|
port, err := strconv.ParseUint(value, 10, 0)
|
||||||
|
if err != nil || port < 1 || port > maxPort {
|
||||||
|
return 0, fmt.Errorf("PORT must be a whole number from 1 to %d, got %q", maxPort, value)
|
||||||
|
}
|
||||||
|
|
||||||
|
return int(port), nil
|
||||||
|
}
|
||||||
|
|
||||||
// EnsureDirectories creates all necessary directories if they don't exist
|
// EnsureDirectories creates all necessary directories if they don't exist
|
||||||
func (c *Config) EnsureDirectories() error {
|
func (c *Config) EnsureDirectories() error {
|
||||||
// Ensure state directory exists
|
// Ensure state directory exists
|
||||||
|
|||||||
@@ -0,0 +1,62 @@
|
|||||||
|
package config
|
||||||
|
|
||||||
|
import (
|
||||||
|
"runtime"
|
||||||
|
"testing"
|
||||||
|
)
|
||||||
|
|
||||||
|
func TestNewReadsPort(t *testing.T) {
|
||||||
|
tests := map[string]int{
|
||||||
|
"": defaultPort,
|
||||||
|
"1": 1,
|
||||||
|
"9090": 9090,
|
||||||
|
"65535": 65535,
|
||||||
|
}
|
||||||
|
|
||||||
|
for value, want := range tests {
|
||||||
|
t.Run(value, func(t *testing.T) {
|
||||||
|
t.Setenv("PORT", value)
|
||||||
|
t.Setenv("XDG_DATA_HOME", "")
|
||||||
|
|
||||||
|
cfg, err := New()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("New() with PORT=%q: %v", value, err)
|
||||||
|
}
|
||||||
|
|
||||||
|
if cfg.Port != want {
|
||||||
|
t.Errorf("New() with PORT=%q: Port = %d, want %d", value, cfg.Port, want)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestNewRefusesInvalidPort(t *testing.T) {
|
||||||
|
for _, value := range []string{"0", "65536", "-1", "+9090", "http", "80.5"} {
|
||||||
|
t.Run(value, func(t *testing.T) {
|
||||||
|
t.Setenv("PORT", value)
|
||||||
|
t.Setenv("XDG_DATA_HOME", "")
|
||||||
|
|
||||||
|
if _, err := New(); err == nil {
|
||||||
|
t.Errorf("New() with PORT=%q returned no error", value)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestNewRefusesRelativeXDGDataHome(t *testing.T) {
|
||||||
|
if runtime.GOOS == "darwin" {
|
||||||
|
t.Skip("macOS does not read XDG_DATA_HOME")
|
||||||
|
}
|
||||||
|
|
||||||
|
t.Setenv("PORT", "")
|
||||||
|
|
||||||
|
t.Setenv("XDG_DATA_HOME", "relative/path")
|
||||||
|
if _, err := New(); err == nil {
|
||||||
|
t.Error("New() with a relative XDG_DATA_HOME returned no error")
|
||||||
|
}
|
||||||
|
|
||||||
|
t.Setenv("XDG_DATA_HOME", "/var/lib")
|
||||||
|
if _, err := New(); err != nil {
|
||||||
|
t.Errorf("New() with XDG_DATA_HOME=/var/lib: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,146 @@
|
|||||||
|
package database
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"fmt"
|
||||||
|
"sync"
|
||||||
|
)
|
||||||
|
|
||||||
|
// liveCounts holds the running row counts that the stats endpoints report. They
|
||||||
|
// are seeded once at startup from the tables and then adjusted on every write,
|
||||||
|
// so a stats read serves them from memory instead of running a COUNT(*) over
|
||||||
|
// each table. Those scans, once the database passed a few GiB, took the whole
|
||||||
|
// request timeout and made /api/v1/stats return 500 (issue 27).
|
||||||
|
//
|
||||||
|
// A single mutex guards all fields so the stats reader takes a consistent
|
||||||
|
// snapshot at one instant and writers, which already run under the database
|
||||||
|
// write lock, adjust the counts after their transaction commits.
|
||||||
|
type liveCounts struct {
|
||||||
|
mu sync.RWMutex
|
||||||
|
asns int
|
||||||
|
prefixesV4 int
|
||||||
|
prefixesV6 int
|
||||||
|
peerings int
|
||||||
|
peers int
|
||||||
|
routesV4 int
|
||||||
|
routesV6 int
|
||||||
|
}
|
||||||
|
|
||||||
|
// seed sets every count to the value read from the tables at startup. It runs
|
||||||
|
// before any writer, so it needs no coordination with the adjust methods.
|
||||||
|
func (c *liveCounts) seed(asns, prefixesV4, prefixesV6, peerings, peers, routesV4, routesV6 int) {
|
||||||
|
c.mu.Lock()
|
||||||
|
defer c.mu.Unlock()
|
||||||
|
|
||||||
|
c.asns = asns
|
||||||
|
c.prefixesV4 = prefixesV4
|
||||||
|
c.prefixesV6 = prefixesV6
|
||||||
|
c.peerings = peerings
|
||||||
|
c.peers = peers
|
||||||
|
c.routesV4 = routesV4
|
||||||
|
c.routesV6 = routesV6
|
||||||
|
}
|
||||||
|
|
||||||
|
// addASNs adds n to the ASN count.
|
||||||
|
func (c *liveCounts) addASNs(n int) {
|
||||||
|
c.mu.Lock()
|
||||||
|
c.asns += n
|
||||||
|
c.mu.Unlock()
|
||||||
|
}
|
||||||
|
|
||||||
|
// addPrefixes adds to the IPv4 and IPv6 prefix counts.
|
||||||
|
func (c *liveCounts) addPrefixes(v4, v6 int) {
|
||||||
|
c.mu.Lock()
|
||||||
|
c.prefixesV4 += v4
|
||||||
|
c.prefixesV6 += v6
|
||||||
|
c.mu.Unlock()
|
||||||
|
}
|
||||||
|
|
||||||
|
// addPeerings adds n to the peering count.
|
||||||
|
func (c *liveCounts) addPeerings(n int) {
|
||||||
|
c.mu.Lock()
|
||||||
|
c.peerings += n
|
||||||
|
c.mu.Unlock()
|
||||||
|
}
|
||||||
|
|
||||||
|
// addPeers adds n to the BGP peer count.
|
||||||
|
func (c *liveCounts) addPeers(n int) {
|
||||||
|
c.mu.Lock()
|
||||||
|
c.peers += n
|
||||||
|
c.mu.Unlock()
|
||||||
|
}
|
||||||
|
|
||||||
|
// addRoutes adds to the IPv4 and IPv6 live-route counts. Deletions pass
|
||||||
|
// negative values.
|
||||||
|
func (c *liveCounts) addRoutes(v4, v6 int) {
|
||||||
|
c.mu.Lock()
|
||||||
|
c.routesV4 += v4
|
||||||
|
c.routesV6 += v6
|
||||||
|
c.mu.Unlock()
|
||||||
|
}
|
||||||
|
|
||||||
|
// fill copies the counts into a Stats, including the derived totals, under a
|
||||||
|
// single read lock so the reader sees one consistent snapshot.
|
||||||
|
func (c *liveCounts) fill(s *Stats) {
|
||||||
|
c.mu.RLock()
|
||||||
|
defer c.mu.RUnlock()
|
||||||
|
|
||||||
|
s.ASNs = c.asns
|
||||||
|
s.IPv4Prefixes = c.prefixesV4
|
||||||
|
s.IPv6Prefixes = c.prefixesV6
|
||||||
|
s.Prefixes = c.prefixesV4 + c.prefixesV6
|
||||||
|
s.Peerings = c.peerings
|
||||||
|
s.Peers = c.peers
|
||||||
|
s.IPv4Routes = c.routesV4
|
||||||
|
s.IPv6Routes = c.routesV6
|
||||||
|
s.LiveRoutes = c.routesV4 + c.routesV6
|
||||||
|
}
|
||||||
|
|
||||||
|
// countRows returns the number of rows in the named table. It is used only at
|
||||||
|
// startup to seed the in-memory counters, so a full COUNT(*) is acceptable.
|
||||||
|
func (d *Database) countRows(ctx context.Context, table string) (int, error) {
|
||||||
|
var n int
|
||||||
|
// table is one of a fixed set of literals below, never external input.
|
||||||
|
if err := d.db.QueryRowContext(ctx, "SELECT COUNT(*) FROM "+table).Scan(&n); err != nil {
|
||||||
|
return 0, fmt.Errorf("failed to count %s: %w", table, err)
|
||||||
|
}
|
||||||
|
|
||||||
|
return n, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// seedCounts reads the current row counts from the tables into the in-memory
|
||||||
|
// counters. It runs once at startup, before the streamer begins writing.
|
||||||
|
func (d *Database) seedCounts(ctx context.Context) error {
|
||||||
|
asns, err := d.countRows(ctx, "asns")
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
prefixesV4, err := d.countRows(ctx, "prefixes_v4")
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
prefixesV6, err := d.countRows(ctx, "prefixes_v6")
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
peerings, err := d.countRows(ctx, "peerings")
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
peers, err := d.countRows(ctx, "bgp_peers")
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
routesV4, err := d.countRows(ctx, "live_routes_v4")
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
routesV6, err := d.countRows(ctx, "live_routes_v6")
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
|
||||||
|
d.counts.seed(asns, prefixesV4, prefixesV6, peerings, peers, routesV4, routesV6)
|
||||||
|
|
||||||
|
return nil
|
||||||
|
}
|
||||||
@@ -0,0 +1,335 @@
|
|||||||
|
package database
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"sync"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"git.eeqj.de/sneak/routewatch/internal/config"
|
||||||
|
"git.eeqj.de/sneak/routewatch/internal/logger"
|
||||||
|
"github.com/google/uuid"
|
||||||
|
)
|
||||||
|
|
||||||
|
// mkV4Route builds an IPv4 live route with its range columns populated.
|
||||||
|
func mkV4Route(t *testing.T, prefix string, asn int, ts time.Time) *LiveRoute {
|
||||||
|
t.Helper()
|
||||||
|
|
||||||
|
start, end, err := CalculateIPv4Range(prefix)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("CalculateIPv4Range(%s): %v", prefix, err)
|
||||||
|
}
|
||||||
|
|
||||||
|
return &LiveRoute{
|
||||||
|
ID: uuid.New(),
|
||||||
|
Prefix: prefix,
|
||||||
|
MaskLength: 24,
|
||||||
|
IPVersion: ipVersionV4,
|
||||||
|
OriginASN: asn,
|
||||||
|
PeerIP: "192.0.2.1",
|
||||||
|
ASPath: []int{asn},
|
||||||
|
NextHop: "192.0.2.254",
|
||||||
|
LastUpdated: ts,
|
||||||
|
V4IPStart: &start,
|
||||||
|
V4IPEnd: &end,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// mkV6Route builds an IPv6 live route.
|
||||||
|
func mkV6Route(prefix string, asn int, ts time.Time) *LiveRoute {
|
||||||
|
return &LiveRoute{
|
||||||
|
ID: uuid.New(),
|
||||||
|
Prefix: prefix,
|
||||||
|
MaskLength: 32,
|
||||||
|
IPVersion: ipVersionV6,
|
||||||
|
OriginASN: asn,
|
||||||
|
PeerIP: "2001:db8::1",
|
||||||
|
ASPath: []int{asn},
|
||||||
|
NextHop: "2001:db8::ffff",
|
||||||
|
LastUpdated: ts,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// TestLiveCountsTrackWritesInRealtime checks that the stats counts start at
|
||||||
|
// zero, reflect each write the moment it commits (no recompute, no timer), do
|
||||||
|
// not move when a route is merely re-announced, and drop when a route is
|
||||||
|
// deleted. These counts are what /api/v1/stats reports; before this change the
|
||||||
|
// endpoint recomputed them with a COUNT(*) over each table on every request.
|
||||||
|
func TestLiveCountsTrackWritesInRealtime(t *testing.T) {
|
||||||
|
cfg := &config.Config{StateDir: t.TempDir()}
|
||||||
|
|
||||||
|
db, err := New(cfg, logger.New())
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("failed to create database: %v", err)
|
||||||
|
}
|
||||||
|
defer func() { _ = db.Close() }()
|
||||||
|
|
||||||
|
ctx := context.Background()
|
||||||
|
|
||||||
|
empty, err := db.GetStatsContext(ctx)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("GetStatsContext on empty database: %v", err)
|
||||||
|
}
|
||||||
|
if empty.ASNs != 0 || empty.Prefixes != 0 || empty.Peerings != 0 ||
|
||||||
|
empty.Peers != 0 || empty.LiveRoutes != 0 {
|
||||||
|
t.Fatalf("empty database counts nonzero: %+v", empty)
|
||||||
|
}
|
||||||
|
|
||||||
|
ts := time.Date(2026, 1, 2, 3, 4, 5, 0, time.UTC)
|
||||||
|
|
||||||
|
if err := db.GetOrCreateASNBatch(map[int]time.Time{64500: ts, 64501: ts}); err != nil {
|
||||||
|
t.Fatalf("GetOrCreateASNBatch: %v", err)
|
||||||
|
}
|
||||||
|
if err := db.UpdatePrefixesBatch(map[string]time.Time{
|
||||||
|
"198.51.100.0/24": ts,
|
||||||
|
"2001:db8::/32": ts,
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatalf("UpdatePrefixesBatch: %v", err)
|
||||||
|
}
|
||||||
|
if err := db.UpdatePeerBatch(map[string]PeerUpdate{
|
||||||
|
"192.0.2.1": {PeerIP: "192.0.2.1", PeerASN: 64500, MessageType: "UPDATE", Timestamp: ts},
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatalf("UpdatePeerBatch: %v", err)
|
||||||
|
}
|
||||||
|
if err := db.RecordPeering(64500, 64501, ts); err != nil {
|
||||||
|
t.Fatalf("RecordPeering: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
routes := []*LiveRoute{
|
||||||
|
mkV4Route(t, "198.51.100.0/24", 64500, ts),
|
||||||
|
mkV4Route(t, "203.0.113.0/24", 64501, ts.Add(time.Minute)),
|
||||||
|
mkV6Route("2001:db8::/32", 64502, ts.Add(2*time.Minute)),
|
||||||
|
}
|
||||||
|
if err := db.UpsertLiveRouteBatch(routes); err != nil {
|
||||||
|
t.Fatalf("UpsertLiveRouteBatch: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
stats, err := db.GetStatsContext(ctx)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("GetStatsContext: %v", err)
|
||||||
|
}
|
||||||
|
assertCounts(t, "after inserts", stats, wantCounts{
|
||||||
|
asns: 2, prefixes: 2, peerings: 1, peers: 1,
|
||||||
|
ipv4Routes: 2, ipv6Routes: 1, liveRoutes: 3,
|
||||||
|
})
|
||||||
|
|
||||||
|
// Re-announcing the same routes is an update, not an insert: counts hold.
|
||||||
|
if err := db.UpsertLiveRouteBatch(routes); err != nil {
|
||||||
|
t.Fatalf("UpsertLiveRouteBatch (re-announce): %v", err)
|
||||||
|
}
|
||||||
|
stats, err = db.GetStatsContext(ctx)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("GetStatsContext: %v", err)
|
||||||
|
}
|
||||||
|
assertCounts(t, "after re-announce", stats, wantCounts{
|
||||||
|
asns: 2, prefixes: 2, peerings: 1, peers: 1,
|
||||||
|
ipv4Routes: 2, ipv6Routes: 1, liveRoutes: 3,
|
||||||
|
})
|
||||||
|
|
||||||
|
// A withdrawal removes one route.
|
||||||
|
if err := db.DeleteLiveRouteBatch([]LiveRouteDeletion{
|
||||||
|
{Prefix: "203.0.113.0/24", OriginASN: 64501, PeerIP: "192.0.2.1", IPVersion: ipVersionV4},
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatalf("DeleteLiveRouteBatch: %v", err)
|
||||||
|
}
|
||||||
|
stats, err = db.GetStatsContext(ctx)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("GetStatsContext: %v", err)
|
||||||
|
}
|
||||||
|
assertCounts(t, "after delete", stats, wantCounts{
|
||||||
|
asns: 2, prefixes: 2, peerings: 1, peers: 1,
|
||||||
|
ipv4Routes: 1, ipv6Routes: 1, liveRoutes: 2,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
// TestLiveCountsSeededFromDatabaseAtStartup writes rows, reopens the same
|
||||||
|
// database file, and checks the counts come back from the seed scan rather than
|
||||||
|
// starting at zero.
|
||||||
|
func TestLiveCountsSeededFromDatabaseAtStartup(t *testing.T) {
|
||||||
|
cfg := &config.Config{StateDir: t.TempDir()}
|
||||||
|
|
||||||
|
db, err := New(cfg, logger.New())
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("failed to create database: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
ts := time.Date(2026, 1, 2, 3, 4, 5, 0, time.UTC)
|
||||||
|
if err := db.GetOrCreateASNBatch(map[int]time.Time{64500: ts, 64501: ts, 64502: ts}); err != nil {
|
||||||
|
t.Fatalf("GetOrCreateASNBatch: %v", err)
|
||||||
|
}
|
||||||
|
if err := db.UpsertLiveRouteBatch([]*LiveRoute{
|
||||||
|
mkV4Route(t, "198.51.100.0/24", 64500, ts),
|
||||||
|
mkV6Route("2001:db8::/32", 64502, ts),
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatalf("UpsertLiveRouteBatch: %v", err)
|
||||||
|
}
|
||||||
|
if err := db.Close(); err != nil {
|
||||||
|
t.Fatalf("Close: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
reopened, err := New(cfg, logger.New())
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("failed to reopen database: %v", err)
|
||||||
|
}
|
||||||
|
defer func() { _ = reopened.Close() }()
|
||||||
|
|
||||||
|
stats, err := reopened.GetStatsContext(context.Background())
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("GetStatsContext after reopen: %v", err)
|
||||||
|
}
|
||||||
|
if stats.ASNs != 3 {
|
||||||
|
t.Errorf("seeded ASNs = %d, want 3", stats.ASNs)
|
||||||
|
}
|
||||||
|
if stats.IPv4Routes != 1 || stats.IPv6Routes != 1 || stats.LiveRoutes != 2 {
|
||||||
|
t.Errorf("seeded routes = (v4 %d, v6 %d, total %d), want (1, 1, 2)",
|
||||||
|
stats.IPv4Routes, stats.IPv6Routes, stats.LiveRoutes)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// TestStatsRouteTimestamps checks the oldest/newest route timestamps are read
|
||||||
|
// from the right rows across both tables and parse into time.Time. The old
|
||||||
|
// MIN/MAX union query read its result into *time.Time, which the driver could
|
||||||
|
// not parse, so it logged a warning every call and left both timestamps nil.
|
||||||
|
func TestStatsRouteTimestamps(t *testing.T) {
|
||||||
|
cfg := &config.Config{StateDir: t.TempDir()}
|
||||||
|
|
||||||
|
db, err := New(cfg, logger.New())
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("failed to create database: %v", err)
|
||||||
|
}
|
||||||
|
defer func() { _ = db.Close() }()
|
||||||
|
|
||||||
|
ctx := context.Background()
|
||||||
|
|
||||||
|
empty, err := db.GetStatsContext(ctx)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("GetStatsContext on empty database: %v", err)
|
||||||
|
}
|
||||||
|
if empty.OldestRoute != nil || empty.NewestRoute != nil {
|
||||||
|
t.Fatalf("empty database timestamps = (%v, %v), want (nil, nil)",
|
||||||
|
empty.OldestRoute, empty.NewestRoute)
|
||||||
|
}
|
||||||
|
|
||||||
|
base := time.Date(2026, 1, 2, 3, 4, 5, 0, time.UTC)
|
||||||
|
oldest := base
|
||||||
|
newest := base.Add(2 * time.Minute)
|
||||||
|
if err := db.UpsertLiveRouteBatch([]*LiveRoute{
|
||||||
|
mkV4Route(t, "198.51.100.0/24", 64500, base.Add(time.Minute)),
|
||||||
|
mkV4Route(t, "203.0.113.0/24", 64501, oldest),
|
||||||
|
mkV6Route("2001:db8::/32", 64502, newest),
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatalf("UpsertLiveRouteBatch: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
stats, err := db.GetStatsContext(ctx)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("GetStatsContext: %v", err)
|
||||||
|
}
|
||||||
|
if stats.OldestRoute == nil || !stats.OldestRoute.Equal(oldest) {
|
||||||
|
t.Errorf("OldestRoute = %v, want %v", stats.OldestRoute, oldest)
|
||||||
|
}
|
||||||
|
if stats.NewestRoute == nil || !stats.NewestRoute.Equal(newest) {
|
||||||
|
t.Errorf("NewestRoute = %v, want %v", stats.NewestRoute, newest)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// TestLiveCountsConcurrentReadWrite runs writers and stats readers at once so
|
||||||
|
// the race detector proves the counters are safe under concurrent use.
|
||||||
|
func TestLiveCountsConcurrentReadWrite(t *testing.T) {
|
||||||
|
cfg := &config.Config{StateDir: t.TempDir()}
|
||||||
|
|
||||||
|
db, err := New(cfg, logger.New())
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("failed to create database: %v", err)
|
||||||
|
}
|
||||||
|
defer func() { _ = db.Close() }()
|
||||||
|
|
||||||
|
ts := time.Date(2026, 1, 2, 3, 4, 5, 0, time.UTC)
|
||||||
|
|
||||||
|
const writers = 4
|
||||||
|
var wg sync.WaitGroup
|
||||||
|
|
||||||
|
wg.Add(writers)
|
||||||
|
for w := range writers {
|
||||||
|
go func(base int) {
|
||||||
|
defer wg.Done()
|
||||||
|
for i := range 25 {
|
||||||
|
asn := 65000 + base*100 + i
|
||||||
|
route := mkV6Route("2001:db8::/32", asn, ts)
|
||||||
|
route.PeerIP = "2001:db8::" + uuid.NewString()
|
||||||
|
if err := db.UpsertLiveRoute(route); err != nil {
|
||||||
|
t.Errorf("UpsertLiveRoute: %v", err)
|
||||||
|
|
||||||
|
return
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}(w)
|
||||||
|
}
|
||||||
|
|
||||||
|
var readerWG sync.WaitGroup
|
||||||
|
readerWG.Add(1)
|
||||||
|
stop := make(chan struct{})
|
||||||
|
go func() {
|
||||||
|
defer readerWG.Done()
|
||||||
|
for {
|
||||||
|
select {
|
||||||
|
case <-stop:
|
||||||
|
return
|
||||||
|
default:
|
||||||
|
if _, err := db.GetStatsContext(context.Background()); err != nil {
|
||||||
|
t.Errorf("GetStatsContext: %v", err)
|
||||||
|
|
||||||
|
return
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
|
||||||
|
wg.Wait()
|
||||||
|
close(stop)
|
||||||
|
readerWG.Wait()
|
||||||
|
|
||||||
|
stats, err := db.GetStatsContext(context.Background())
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("GetStatsContext: %v", err)
|
||||||
|
}
|
||||||
|
if want := writers * 25; stats.IPv6Routes != want {
|
||||||
|
t.Errorf("IPv6Routes = %d, want %d", stats.IPv6Routes, want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
type wantCounts struct {
|
||||||
|
asns int
|
||||||
|
prefixes int
|
||||||
|
peerings int
|
||||||
|
peers int
|
||||||
|
ipv4Routes int
|
||||||
|
ipv6Routes int
|
||||||
|
liveRoutes int
|
||||||
|
}
|
||||||
|
|
||||||
|
func assertCounts(t *testing.T, when string, got Stats, want wantCounts) {
|
||||||
|
t.Helper()
|
||||||
|
|
||||||
|
if got.ASNs != want.asns {
|
||||||
|
t.Errorf("%s: ASNs = %d, want %d", when, got.ASNs, want.asns)
|
||||||
|
}
|
||||||
|
if got.Prefixes != want.prefixes {
|
||||||
|
t.Errorf("%s: Prefixes = %d, want %d", when, got.Prefixes, want.prefixes)
|
||||||
|
}
|
||||||
|
if got.Peerings != want.peerings {
|
||||||
|
t.Errorf("%s: Peerings = %d, want %d", when, got.Peerings, want.peerings)
|
||||||
|
}
|
||||||
|
if got.Peers != want.peers {
|
||||||
|
t.Errorf("%s: Peers = %d, want %d", when, got.Peers, want.peers)
|
||||||
|
}
|
||||||
|
if got.IPv4Routes != want.ipv4Routes {
|
||||||
|
t.Errorf("%s: IPv4Routes = %d, want %d", when, got.IPv4Routes, want.ipv4Routes)
|
||||||
|
}
|
||||||
|
if got.IPv6Routes != want.ipv6Routes {
|
||||||
|
t.Errorf("%s: IPv6Routes = %d, want %d", when, got.IPv6Routes, want.ipv6Routes)
|
||||||
|
}
|
||||||
|
if got.LiveRoutes != want.liveRoutes {
|
||||||
|
t.Errorf("%s: LiveRoutes = %d, want %d", when, got.LiveRoutes, want.liveRoutes)
|
||||||
|
}
|
||||||
|
}
|
||||||
+324
-207
@@ -72,6 +72,7 @@ type Database struct {
|
|||||||
mu sync.Mutex
|
mu sync.Mutex
|
||||||
lockedAt time.Time
|
lockedAt time.Time
|
||||||
lockedBy string
|
lockedBy string
|
||||||
|
counts *liveCounts
|
||||||
}
|
}
|
||||||
|
|
||||||
// New creates a new database connection and initializes the schema.
|
// New creates a new database connection and initializes the schema.
|
||||||
@@ -115,12 +116,19 @@ func New(cfg *config.Config, logger *logger.Logger) (*Database, error) {
|
|||||||
db.SetMaxIdleConns(maxConns)
|
db.SetMaxIdleConns(maxConns)
|
||||||
db.SetConnMaxLifetime(0)
|
db.SetConnMaxLifetime(0)
|
||||||
|
|
||||||
database := &Database{db: db, logger: logger, path: dbPath}
|
database := &Database{db: db, logger: logger, path: dbPath, counts: &liveCounts{}}
|
||||||
|
|
||||||
if err := database.Initialize(); err != nil {
|
if err := database.Initialize(); err != nil {
|
||||||
return nil, fmt.Errorf("failed to initialize database: %w", err)
|
return nil, fmt.Errorf("failed to initialize database: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Seed the in-memory statistics counters from the tables once, before the
|
||||||
|
// streamer starts writing. From here on every write keeps them current, so
|
||||||
|
// the stats endpoints never scan the tables to report counts.
|
||||||
|
if err := database.seedCounts(context.Background()); err != nil {
|
||||||
|
return nil, fmt.Errorf("failed to seed statistics counters: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
return database, nil
|
return database, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -208,6 +216,81 @@ func (d *Database) beginTx() (*loggingTx, error) {
|
|||||||
return &loggingTx{Tx: tx, logger: d.logger}, nil
|
return &loggingTx{Tx: tx, logger: d.logger}, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// A live-route upsert is an UPDATE followed, only when no row matched, by an
|
||||||
|
// INSERT. The UPDATE's rows-affected count (1 for an existing key, 0 for a new
|
||||||
|
// one) is what lets the in-memory route counters stay exact without a COUNT(*).
|
||||||
|
// Callers hold the database write lock, so no other writer can insert the same
|
||||||
|
// key between the two statements. The id column is set only on INSERT, so an
|
||||||
|
// updated route keeps its original id, exactly as the previous ON CONFLICT
|
||||||
|
// upsert did.
|
||||||
|
const (
|
||||||
|
updateLiveRouteV4SQL = `UPDATE live_routes_v4 SET mask_length = ?, as_path = ?, next_hop = ?,
|
||||||
|
last_updated = ?, ip_start = ?, ip_end = ? WHERE prefix = ? AND origin_asn = ? AND peer_ip = ?`
|
||||||
|
|
||||||
|
insertLiveRouteV4SQL = `INSERT INTO live_routes_v4 (id, prefix, mask_length, origin_asn, peer_ip,
|
||||||
|
as_path, next_hop, last_updated, ip_start, ip_end) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`
|
||||||
|
|
||||||
|
updateLiveRouteV6SQL = `UPDATE live_routes_v6 SET mask_length = ?, as_path = ?, next_hop = ?,
|
||||||
|
last_updated = ? WHERE prefix = ? AND origin_asn = ? AND peer_ip = ?`
|
||||||
|
|
||||||
|
insertLiveRouteV6SQL = `INSERT INTO live_routes_v6 (id, prefix, mask_length, origin_asn, peer_ip,
|
||||||
|
as_path, next_hop, last_updated) VALUES (?, ?, ?, ?, ?, ?, ?, ?)`
|
||||||
|
)
|
||||||
|
|
||||||
|
// upsertRouteRowV4 updates an IPv4 live route, inserting it when no row matched,
|
||||||
|
// and reports whether a new row was inserted.
|
||||||
|
func upsertRouteRowV4(upd, ins *sql.Stmt, route *LiveRoute, pathJSON string) (inserted bool, err error) {
|
||||||
|
if route.V4IPStart == nil || route.V4IPEnd == nil {
|
||||||
|
return false, fmt.Errorf("IPv4 route %s missing range values", route.Prefix)
|
||||||
|
}
|
||||||
|
|
||||||
|
res, err := upd.Exec(route.MaskLength, pathJSON, route.NextHop, route.LastUpdated,
|
||||||
|
*route.V4IPStart, *route.V4IPEnd, route.Prefix, route.OriginASN, route.PeerIP)
|
||||||
|
if err != nil {
|
||||||
|
return false, err
|
||||||
|
}
|
||||||
|
affected, err := res.RowsAffected()
|
||||||
|
if err != nil {
|
||||||
|
return false, err
|
||||||
|
}
|
||||||
|
if affected > 0 {
|
||||||
|
return false, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
_, err = ins.Exec(route.ID.String(), route.Prefix, route.MaskLength, route.OriginASN,
|
||||||
|
route.PeerIP, pathJSON, route.NextHop, route.LastUpdated, *route.V4IPStart, *route.V4IPEnd)
|
||||||
|
if err != nil {
|
||||||
|
return false, err
|
||||||
|
}
|
||||||
|
|
||||||
|
return true, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// upsertRouteRowV6 updates an IPv6 live route, inserting it when no row matched,
|
||||||
|
// and reports whether a new row was inserted.
|
||||||
|
func upsertRouteRowV6(upd, ins *sql.Stmt, route *LiveRoute, pathJSON string) (inserted bool, err error) {
|
||||||
|
res, err := upd.Exec(route.MaskLength, pathJSON, route.NextHop, route.LastUpdated,
|
||||||
|
route.Prefix, route.OriginASN, route.PeerIP)
|
||||||
|
if err != nil {
|
||||||
|
return false, err
|
||||||
|
}
|
||||||
|
affected, err := res.RowsAffected()
|
||||||
|
if err != nil {
|
||||||
|
return false, err
|
||||||
|
}
|
||||||
|
if affected > 0 {
|
||||||
|
return false, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
_, err = ins.Exec(route.ID.String(), route.Prefix, route.MaskLength, route.OriginASN,
|
||||||
|
route.PeerIP, pathJSON, route.NextHop, route.LastUpdated)
|
||||||
|
if err != nil {
|
||||||
|
return false, err
|
||||||
|
}
|
||||||
|
|
||||||
|
return true, nil
|
||||||
|
}
|
||||||
|
|
||||||
// UpsertLiveRouteBatch inserts or updates multiple live routes in a single transaction
|
// UpsertLiveRouteBatch inserts or updates multiple live routes in a single transaction
|
||||||
func (d *Database) UpsertLiveRouteBatch(routes []*LiveRoute) error {
|
func (d *Database) UpsertLiveRouteBatch(routes []*LiveRoute) error {
|
||||||
if len(routes) == 0 {
|
if len(routes) == 0 {
|
||||||
@@ -227,91 +310,65 @@ func (d *Database) UpsertLiveRouteBatch(routes []*LiveRoute) error {
|
|||||||
}
|
}
|
||||||
}()
|
}()
|
||||||
|
|
||||||
// Prepare statements for both IPv4 and IPv6
|
// Prepare the update and insert statements for both tables.
|
||||||
queryV4 := `
|
updV4, err := tx.Prepare(updateLiveRouteV4SQL)
|
||||||
INSERT INTO live_routes_v4 (id, prefix, mask_length, origin_asn, peer_ip, as_path, next_hop,
|
|
||||||
last_updated, ip_start, ip_end)
|
|
||||||
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
|
|
||||||
ON CONFLICT(prefix, origin_asn, peer_ip) DO UPDATE SET
|
|
||||||
mask_length = excluded.mask_length,
|
|
||||||
as_path = excluded.as_path,
|
|
||||||
next_hop = excluded.next_hop,
|
|
||||||
last_updated = excluded.last_updated,
|
|
||||||
ip_start = excluded.ip_start,
|
|
||||||
ip_end = excluded.ip_end
|
|
||||||
`
|
|
||||||
|
|
||||||
queryV6 := `
|
|
||||||
INSERT INTO live_routes_v6 (id, prefix, mask_length, origin_asn, peer_ip, as_path, next_hop,
|
|
||||||
last_updated)
|
|
||||||
VALUES (?, ?, ?, ?, ?, ?, ?, ?)
|
|
||||||
ON CONFLICT(prefix, origin_asn, peer_ip) DO UPDATE SET
|
|
||||||
mask_length = excluded.mask_length,
|
|
||||||
as_path = excluded.as_path,
|
|
||||||
next_hop = excluded.next_hop,
|
|
||||||
last_updated = excluded.last_updated
|
|
||||||
`
|
|
||||||
|
|
||||||
stmtV4, err := tx.Prepare(queryV4)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return fmt.Errorf("failed to prepare IPv4 statement: %w", err)
|
return fmt.Errorf("failed to prepare IPv4 update statement: %w", err)
|
||||||
}
|
}
|
||||||
defer func() { _ = stmtV4.Close() }()
|
defer func() { _ = updV4.Close() }()
|
||||||
|
|
||||||
stmtV6, err := tx.Prepare(queryV6)
|
insV4, err := tx.Prepare(insertLiveRouteV4SQL)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return fmt.Errorf("failed to prepare IPv6 statement: %w", err)
|
return fmt.Errorf("failed to prepare IPv4 insert statement: %w", err)
|
||||||
}
|
}
|
||||||
defer func() { _ = stmtV6.Close() }()
|
defer func() { _ = insV4.Close() }()
|
||||||
|
|
||||||
|
updV6, err := tx.Prepare(updateLiveRouteV6SQL)
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("failed to prepare IPv6 update statement: %w", err)
|
||||||
|
}
|
||||||
|
defer func() { _ = updV6.Close() }()
|
||||||
|
|
||||||
|
insV6, err := tx.Prepare(insertLiveRouteV6SQL)
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("failed to prepare IPv6 insert statement: %w", err)
|
||||||
|
}
|
||||||
|
defer func() { _ = insV6.Close() }()
|
||||||
|
|
||||||
|
var newV4, newV6 int
|
||||||
for _, route := range routes {
|
for _, route := range routes {
|
||||||
// Encode AS path as JSON
|
|
||||||
pathJSON, err := json.Marshal(route.ASPath)
|
pathJSON, err := json.Marshal(route.ASPath)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return fmt.Errorf("failed to encode AS path: %w", err)
|
return fmt.Errorf("failed to encode AS path: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Use appropriate statement based on IP version
|
|
||||||
if route.IPVersion == ipVersionV4 {
|
if route.IPVersion == ipVersionV4 {
|
||||||
// IPv4 routes must have range values
|
inserted, err := upsertRouteRowV4(updV4, insV4, route, string(pathJSON))
|
||||||
if route.V4IPStart == nil || route.V4IPEnd == nil {
|
|
||||||
return fmt.Errorf("IPv4 route %s missing range values", route.Prefix)
|
|
||||||
}
|
|
||||||
|
|
||||||
_, err = stmtV4.Exec(
|
|
||||||
route.ID.String(),
|
|
||||||
route.Prefix,
|
|
||||||
route.MaskLength,
|
|
||||||
route.OriginASN,
|
|
||||||
route.PeerIP,
|
|
||||||
string(pathJSON),
|
|
||||||
route.NextHop,
|
|
||||||
route.LastUpdated,
|
|
||||||
*route.V4IPStart,
|
|
||||||
*route.V4IPEnd,
|
|
||||||
)
|
|
||||||
} else {
|
|
||||||
// IPv6 routes
|
|
||||||
_, err = stmtV6.Exec(
|
|
||||||
route.ID.String(),
|
|
||||||
route.Prefix,
|
|
||||||
route.MaskLength,
|
|
||||||
route.OriginASN,
|
|
||||||
route.PeerIP,
|
|
||||||
string(pathJSON),
|
|
||||||
route.NextHop,
|
|
||||||
route.LastUpdated,
|
|
||||||
)
|
|
||||||
}
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return fmt.Errorf("failed to upsert route %s: %w", route.Prefix, err)
|
return fmt.Errorf("failed to upsert route %s: %w", route.Prefix, err)
|
||||||
}
|
}
|
||||||
|
if inserted {
|
||||||
|
newV4++
|
||||||
|
}
|
||||||
|
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
|
||||||
|
inserted, err := upsertRouteRowV6(updV6, insV6, route, string(pathJSON))
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("failed to upsert route %s: %w", route.Prefix, err)
|
||||||
|
}
|
||||||
|
if inserted {
|
||||||
|
newV6++
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
if err = tx.Commit(); err != nil {
|
if err = tx.Commit(); err != nil {
|
||||||
return fmt.Errorf("failed to commit transaction: %w", err)
|
return fmt.Errorf("failed to commit transaction: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
d.counts.addRoutes(newV4, newV6)
|
||||||
|
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -362,6 +419,7 @@ func (d *Database) DeleteLiveRouteBatch(deletions []LiveRouteDeletion) error {
|
|||||||
defer func() { _ = stmtV6WithoutOrigin.Close() }()
|
defer func() { _ = stmtV6WithoutOrigin.Close() }()
|
||||||
|
|
||||||
// Process deletions
|
// Process deletions
|
||||||
|
var deletedV4, deletedV6 int64
|
||||||
for _, del := range deletions {
|
for _, del := range deletions {
|
||||||
var stmt *sql.Stmt
|
var stmt *sql.Stmt
|
||||||
|
|
||||||
@@ -382,21 +440,36 @@ func (d *Database) DeleteLiveRouteBatch(deletions []LiveRouteDeletion) error {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Execute deletion
|
// Execute deletion
|
||||||
|
var res sql.Result
|
||||||
if del.OriginASN == 0 {
|
if del.OriginASN == 0 {
|
||||||
_, err = stmt.Exec(del.Prefix, del.PeerIP)
|
res, err = stmt.Exec(del.Prefix, del.PeerIP)
|
||||||
} else {
|
} else {
|
||||||
_, err = stmt.Exec(del.Prefix, del.OriginASN, del.PeerIP)
|
res, err = stmt.Exec(del.Prefix, del.OriginASN, del.PeerIP)
|
||||||
}
|
}
|
||||||
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return fmt.Errorf("failed to delete route %s: %w", del.Prefix, err)
|
return fmt.Errorf("failed to delete route %s: %w", del.Prefix, err)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// A deletion with no origin ASN can remove several rows, so use the
|
||||||
|
// exact rows-affected count to keep the in-memory route counters right.
|
||||||
|
affected, err := res.RowsAffected()
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("failed to count deleted route %s: %w", del.Prefix, err)
|
||||||
|
}
|
||||||
|
if del.IPVersion == ipVersionV4 {
|
||||||
|
deletedV4 += affected
|
||||||
|
} else {
|
||||||
|
deletedV6 += affected
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
if err = tx.Commit(); err != nil {
|
if err = tx.Commit(); err != nil {
|
||||||
return fmt.Errorf("failed to commit transaction: %w", err)
|
return fmt.Errorf("failed to commit transaction: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
d.counts.addRoutes(-int(deletedV4), -int(deletedV6))
|
||||||
|
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -456,6 +529,7 @@ func (d *Database) UpdatePrefixesBatch(prefixes map[string]time.Time) error {
|
|||||||
}
|
}
|
||||||
defer func() { _ = insertV6Stmt.Close() }()
|
defer func() { _ = insertV6Stmt.Close() }()
|
||||||
|
|
||||||
|
var newV4, newV6 int
|
||||||
for prefix, timestamp := range prefixes {
|
for prefix, timestamp := range prefixes {
|
||||||
ipVersion := detectIPVersion(prefix)
|
ipVersion := detectIPVersion(prefix)
|
||||||
|
|
||||||
@@ -482,6 +556,11 @@ func (d *Database) UpdatePrefixesBatch(prefixes map[string]time.Time) error {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
return fmt.Errorf("failed to insert prefix %s: %w", prefix, err)
|
return fmt.Errorf("failed to insert prefix %s: %w", prefix, err)
|
||||||
}
|
}
|
||||||
|
if ipVersion == ipVersionV4 {
|
||||||
|
newV4++
|
||||||
|
} else {
|
||||||
|
newV6++
|
||||||
|
}
|
||||||
default:
|
default:
|
||||||
return fmt.Errorf("failed to query prefix %s: %w", prefix, err)
|
return fmt.Errorf("failed to query prefix %s: %w", prefix, err)
|
||||||
}
|
}
|
||||||
@@ -491,6 +570,8 @@ func (d *Database) UpdatePrefixesBatch(prefixes map[string]time.Time) error {
|
|||||||
return fmt.Errorf("failed to commit transaction: %w", err)
|
return fmt.Errorf("failed to commit transaction: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
d.counts.addPrefixes(newV4, newV6)
|
||||||
|
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -534,6 +615,7 @@ func (d *Database) GetOrCreateASNBatch(asns map[int]time.Time) error {
|
|||||||
}
|
}
|
||||||
defer func() { _ = insertStmt.Close() }()
|
defer func() { _ = insertStmt.Close() }()
|
||||||
|
|
||||||
|
var newASNs int
|
||||||
for number, timestamp := range asns {
|
for number, timestamp := range asns {
|
||||||
var asn ASN
|
var asn ASN
|
||||||
var handle, description sql.NullString
|
var handle, description sql.NullString
|
||||||
@@ -568,6 +650,7 @@ func (d *Database) GetOrCreateASNBatch(asns map[int]time.Time) error {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
return fmt.Errorf("failed to insert ASN %d: %w", number, err)
|
return fmt.Errorf("failed to insert ASN %d: %w", number, err)
|
||||||
}
|
}
|
||||||
|
newASNs++
|
||||||
|
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
@@ -581,6 +664,8 @@ func (d *Database) GetOrCreateASNBatch(asns map[int]time.Time) error {
|
|||||||
return fmt.Errorf("failed to commit transaction: %w", err)
|
return fmt.Errorf("failed to commit transaction: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
d.counts.addASNs(newASNs)
|
||||||
|
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -652,6 +737,8 @@ func (d *Database) GetOrCreateASN(number int, timestamp time.Time) (*ASN, error)
|
|||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
|
|
||||||
|
d.counts.addASNs(1)
|
||||||
|
|
||||||
return &asn, nil
|
return &asn, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -727,6 +814,12 @@ func (d *Database) GetOrCreatePrefix(prefix string, timestamp time.Time) (*Prefi
|
|||||||
return nil, err
|
return nil, err
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if ipVersion == ipVersionV4 {
|
||||||
|
d.counts.addPrefixes(1, 0)
|
||||||
|
} else {
|
||||||
|
d.counts.addPrefixes(0, 1)
|
||||||
|
}
|
||||||
|
|
||||||
return &p, nil
|
return &p, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -803,6 +896,10 @@ func (d *Database) RecordPeering(asA, asB int, timestamp time.Time) error {
|
|||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if !exists {
|
||||||
|
d.counts.addPeerings(1)
|
||||||
|
}
|
||||||
|
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -846,6 +943,7 @@ func (d *Database) UpdatePeerBatch(peers map[string]PeerUpdate) error {
|
|||||||
}
|
}
|
||||||
defer func() { _ = insertStmt.Close() }()
|
defer func() { _ = insertStmt.Close() }()
|
||||||
|
|
||||||
|
var newPeers int
|
||||||
for _, update := range peers {
|
for _, update := range peers {
|
||||||
var exists bool
|
var exists bool
|
||||||
err = checkStmt.QueryRow(update.PeerIP).Scan(&exists)
|
err = checkStmt.QueryRow(update.PeerIP).Scan(&exists)
|
||||||
@@ -863,12 +961,17 @@ func (d *Database) UpdatePeerBatch(peers map[string]PeerUpdate) error {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
return fmt.Errorf("failed to update peer %s: %w", update.PeerIP, err)
|
return fmt.Errorf("failed to update peer %s: %w", update.PeerIP, err)
|
||||||
}
|
}
|
||||||
|
if !exists {
|
||||||
|
newPeers++
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
if err = tx.Commit(); err != nil {
|
if err = tx.Commit(); err != nil {
|
||||||
return fmt.Errorf("failed to commit transaction: %w", err)
|
return fmt.Errorf("failed to commit transaction: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
d.counts.addPeers(newPeers)
|
||||||
|
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -918,6 +1021,10 @@ func (d *Database) UpdatePeer(peerIP string, peerASN int, messageType string, ti
|
|||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if !exists {
|
||||||
|
d.counts.addPeers(1)
|
||||||
|
}
|
||||||
|
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -926,169 +1033,161 @@ func (d *Database) GetStats() (Stats, error) {
|
|||||||
return d.GetStatsContext(context.Background())
|
return d.GetStatsContext(context.Background())
|
||||||
}
|
}
|
||||||
|
|
||||||
// GetStatsContext returns database statistics with context support
|
// GetStatsContext returns database statistics with context support.
|
||||||
|
//
|
||||||
|
// The row counts (ASNs, prefixes, peerings, peers, live routes) come from the
|
||||||
|
// in-memory counters, seeded at startup and kept current on every write, so a
|
||||||
|
// read runs no COUNT(*) over the tables. The oldest/newest route timestamps are
|
||||||
|
// read from the ends of the last_updated index, and the file size from a
|
||||||
|
// stat(); neither is a table scan. The only remaining query is the prefix
|
||||||
|
// distribution.
|
||||||
func (d *Database) GetStatsContext(ctx context.Context) (Stats, error) {
|
func (d *Database) GetStatsContext(ctx context.Context) (Stats, error) {
|
||||||
var stats Stats
|
var stats Stats
|
||||||
|
|
||||||
// Count ASNs
|
// Row counts from memory, as a single consistent snapshot.
|
||||||
err := d.db.QueryRowContext(ctx, "SELECT COUNT(*) FROM asns").Scan(&stats.ASNs)
|
d.counts.fill(&stats)
|
||||||
if err != nil {
|
|
||||||
return stats, err
|
|
||||||
}
|
|
||||||
|
|
||||||
// Count prefixes from both tables
|
// Database file size is a cheap stat() on the file.
|
||||||
err = d.db.QueryRowContext(ctx, "SELECT COUNT(*) FROM prefixes_v4").Scan(&stats.IPv4Prefixes)
|
if fileInfo, err := os.Stat(d.path); err != nil {
|
||||||
if err != nil {
|
|
||||||
return stats, err
|
|
||||||
}
|
|
||||||
|
|
||||||
err = d.db.QueryRowContext(ctx, "SELECT COUNT(*) FROM prefixes_v6").Scan(&stats.IPv6Prefixes)
|
|
||||||
if err != nil {
|
|
||||||
return stats, err
|
|
||||||
}
|
|
||||||
|
|
||||||
stats.Prefixes = stats.IPv4Prefixes + stats.IPv6Prefixes
|
|
||||||
|
|
||||||
// Count peerings
|
|
||||||
err = d.db.QueryRowContext(ctx, "SELECT COUNT(*) FROM peerings").Scan(&stats.Peerings)
|
|
||||||
if err != nil {
|
|
||||||
return stats, err
|
|
||||||
}
|
|
||||||
|
|
||||||
// Count peers
|
|
||||||
err = d.db.QueryRowContext(ctx, "SELECT COUNT(*) FROM bgp_peers").Scan(&stats.Peers)
|
|
||||||
if err != nil {
|
|
||||||
return stats, err
|
|
||||||
}
|
|
||||||
|
|
||||||
// Get database file size
|
|
||||||
fileInfo, err := os.Stat(d.path)
|
|
||||||
if err != nil {
|
|
||||||
d.logger.Warn("Failed to get database file size", "error", err)
|
d.logger.Warn("Failed to get database file size", "error", err)
|
||||||
stats.FileSizeBytes = 0
|
|
||||||
} else {
|
} else {
|
||||||
stats.FileSizeBytes = fileInfo.Size()
|
stats.FileSizeBytes = fileInfo.Size()
|
||||||
}
|
}
|
||||||
|
|
||||||
// Get live routes count from both tables
|
// Oldest and newest route timestamps read one row from each end of the
|
||||||
var v4Count, v6Count int
|
// last_updated index (a log-time lookup, not a scan). Selecting the column
|
||||||
err = d.db.QueryRowContext(ctx, "SELECT COUNT(*) FROM live_routes_v4").Scan(&v4Count)
|
// directly lets the driver parse the DATETIME into time.Time; the old
|
||||||
if err != nil {
|
// MIN/MAX union scan returned an untyped string that failed to scan and
|
||||||
return stats, fmt.Errorf("failed to count IPv4 routes: %w", err)
|
// logged a warning on every call.
|
||||||
}
|
oldest, newest, err := d.routeTimestampRange(ctx)
|
||||||
err = d.db.QueryRowContext(ctx, "SELECT COUNT(*) FROM live_routes_v6").Scan(&v6Count)
|
|
||||||
if err != nil {
|
|
||||||
return stats, fmt.Errorf("failed to count IPv6 routes: %w", err)
|
|
||||||
}
|
|
||||||
stats.LiveRoutes = v4Count + v6Count
|
|
||||||
|
|
||||||
// Get oldest and newest route timestamps
|
|
||||||
routeTimestampQuery := `
|
|
||||||
SELECT MIN(last_updated), MAX(last_updated) FROM (
|
|
||||||
SELECT last_updated FROM live_routes_v4
|
|
||||||
UNION ALL
|
|
||||||
SELECT last_updated FROM live_routes_v6
|
|
||||||
)
|
|
||||||
`
|
|
||||||
var oldestRoute, newestRoute *time.Time
|
|
||||||
err = d.db.QueryRowContext(ctx, routeTimestampQuery).Scan(&oldestRoute, &newestRoute)
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
// Display-only fields; log but keep the rest of the stats.
|
||||||
d.logger.Warn("Failed to get route timestamps", "error", err)
|
d.logger.Warn("Failed to get route timestamps", "error", err)
|
||||||
} else {
|
} else {
|
||||||
stats.OldestRoute = oldestRoute
|
stats.OldestRoute = oldest
|
||||||
stats.NewestRoute = newestRoute
|
stats.NewestRoute = newest
|
||||||
}
|
}
|
||||||
|
|
||||||
// Get prefix distribution
|
// Prefix distribution counts distinct prefixes per mask length. It stays a
|
||||||
|
// query over the covering (mask_length, prefix) index rather than an
|
||||||
|
// in-memory counter: maintaining distinct-prefix-per-mask in memory would
|
||||||
|
// need a per-prefix table of roughly a million entries, memory this service
|
||||||
|
// is tuned to avoid.
|
||||||
stats.IPv4PrefixDistribution, stats.IPv6PrefixDistribution, err = d.GetPrefixDistributionContext(ctx)
|
stats.IPv4PrefixDistribution, stats.IPv6PrefixDistribution, err = d.GetPrefixDistributionContext(ctx)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
// Log but don't fail
|
// Log but don't fail.
|
||||||
d.logger.Warn("Failed to get prefix distribution", "error", err)
|
d.logger.Warn("Failed to get prefix distribution", "error", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
return stats, nil
|
return stats, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// routeTimestampRange returns the earliest and latest last_updated across both
|
||||||
|
// live route tables, or nil values when both tables are empty. Each query reads
|
||||||
|
// one row from an end of the last_updated index rather than scanning the tables.
|
||||||
|
func (d *Database) routeTimestampRange(ctx context.Context) (oldest, newest *time.Time, err error) {
|
||||||
|
oldestV4, ok, err := d.scanRouteTimestamp(ctx,
|
||||||
|
"SELECT last_updated FROM live_routes_v4 ORDER BY last_updated ASC LIMIT 1")
|
||||||
|
if err != nil {
|
||||||
|
return nil, nil, err
|
||||||
|
}
|
||||||
|
if ok {
|
||||||
|
oldest = &oldestV4
|
||||||
|
}
|
||||||
|
|
||||||
|
oldestV6, ok, err := d.scanRouteTimestamp(ctx,
|
||||||
|
"SELECT last_updated FROM live_routes_v6 ORDER BY last_updated ASC LIMIT 1")
|
||||||
|
if err != nil {
|
||||||
|
return nil, nil, err
|
||||||
|
}
|
||||||
|
if ok && (oldest == nil || oldestV6.Before(*oldest)) {
|
||||||
|
oldest = &oldestV6
|
||||||
|
}
|
||||||
|
|
||||||
|
newestV4, ok, err := d.scanRouteTimestamp(ctx,
|
||||||
|
"SELECT last_updated FROM live_routes_v4 ORDER BY last_updated DESC LIMIT 1")
|
||||||
|
if err != nil {
|
||||||
|
return nil, nil, err
|
||||||
|
}
|
||||||
|
if ok {
|
||||||
|
newest = &newestV4
|
||||||
|
}
|
||||||
|
|
||||||
|
newestV6, ok, err := d.scanRouteTimestamp(ctx,
|
||||||
|
"SELECT last_updated FROM live_routes_v6 ORDER BY last_updated DESC LIMIT 1")
|
||||||
|
if err != nil {
|
||||||
|
return nil, nil, err
|
||||||
|
}
|
||||||
|
if ok && (newest == nil || newestV6.After(*newest)) {
|
||||||
|
newest = &newestV6
|
||||||
|
}
|
||||||
|
|
||||||
|
return oldest, newest, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// scanRouteTimestamp runs a single-row timestamp query. ok is false when the
|
||||||
|
// table is empty. The query selects the last_updated column directly so the
|
||||||
|
// driver parses the DATETIME value into a time.Time.
|
||||||
|
func (d *Database) scanRouteTimestamp(ctx context.Context, query string) (ts time.Time, ok bool, err error) {
|
||||||
|
err = d.db.QueryRowContext(ctx, query).Scan(&ts)
|
||||||
|
switch {
|
||||||
|
case errors.Is(err, sql.ErrNoRows):
|
||||||
|
return time.Time{}, false, nil
|
||||||
|
case err != nil:
|
||||||
|
return time.Time{}, false, err
|
||||||
|
default:
|
||||||
|
return ts, true, nil
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// UpsertLiveRoute inserts or updates a live route
|
// UpsertLiveRoute inserts or updates a live route
|
||||||
func (d *Database) UpsertLiveRoute(route *LiveRoute) error {
|
func (d *Database) UpsertLiveRoute(route *LiveRoute) error {
|
||||||
d.lock("UpsertLiveRoute")
|
d.lock("UpsertLiveRoute")
|
||||||
defer d.unlock()
|
defer d.unlock()
|
||||||
|
|
||||||
// Choose table based on IP version
|
|
||||||
tableName := "live_routes_v4"
|
|
||||||
if route.IPVersion == ipVersionV6 {
|
|
||||||
tableName = "live_routes_v6"
|
|
||||||
}
|
|
||||||
|
|
||||||
var query string
|
|
||||||
if route.IPVersion == ipVersionV4 {
|
|
||||||
query = fmt.Sprintf(`
|
|
||||||
INSERT INTO %s (id, prefix, mask_length, origin_asn, peer_ip, as_path, next_hop,
|
|
||||||
last_updated, ip_start, ip_end)
|
|
||||||
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
|
|
||||||
ON CONFLICT(prefix, origin_asn, peer_ip) DO UPDATE SET
|
|
||||||
mask_length = excluded.mask_length,
|
|
||||||
as_path = excluded.as_path,
|
|
||||||
next_hop = excluded.next_hop,
|
|
||||||
last_updated = excluded.last_updated,
|
|
||||||
ip_start = excluded.ip_start,
|
|
||||||
ip_end = excluded.ip_end
|
|
||||||
`, tableName)
|
|
||||||
} else {
|
|
||||||
query = fmt.Sprintf(`
|
|
||||||
INSERT INTO %s (id, prefix, mask_length, origin_asn, peer_ip, as_path, next_hop,
|
|
||||||
last_updated)
|
|
||||||
VALUES (?, ?, ?, ?, ?, ?, ?, ?)
|
|
||||||
ON CONFLICT(prefix, origin_asn, peer_ip) DO UPDATE SET
|
|
||||||
mask_length = excluded.mask_length,
|
|
||||||
as_path = excluded.as_path,
|
|
||||||
next_hop = excluded.next_hop,
|
|
||||||
last_updated = excluded.last_updated
|
|
||||||
`, tableName)
|
|
||||||
}
|
|
||||||
|
|
||||||
// Encode AS path as JSON
|
|
||||||
pathJSON, err := json.Marshal(route.ASPath)
|
pathJSON, err := json.Marshal(route.ASPath)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return fmt.Errorf("failed to encode AS path: %w", err)
|
return fmt.Errorf("failed to encode AS path: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
updateSQL, insertSQL := updateLiveRouteV4SQL, insertLiveRouteV4SQL
|
||||||
|
if route.IPVersion == ipVersionV6 {
|
||||||
|
updateSQL, insertSQL = updateLiveRouteV6SQL, insertLiveRouteV6SQL
|
||||||
|
}
|
||||||
|
|
||||||
|
// The write lock is held, so no other writer can insert this key between the
|
||||||
|
// update and the insert even though they are separate autocommit statements.
|
||||||
|
upd, err := d.db.Prepare(updateSQL)
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("failed to prepare update statement: %w", err)
|
||||||
|
}
|
||||||
|
defer func() { _ = upd.Close() }()
|
||||||
|
|
||||||
|
ins, err := d.db.Prepare(insertSQL)
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("failed to prepare insert statement: %w", err)
|
||||||
|
}
|
||||||
|
defer func() { _ = ins.Close() }()
|
||||||
|
|
||||||
|
var inserted bool
|
||||||
if route.IPVersion == ipVersionV4 {
|
if route.IPVersion == ipVersionV4 {
|
||||||
// Convert v4_ip_start and v4_ip_end to interface{} for SQL NULL handling
|
inserted, err = upsertRouteRowV4(upd, ins, route, string(pathJSON))
|
||||||
var v4Start, v4End interface{}
|
|
||||||
if route.V4IPStart != nil {
|
|
||||||
v4Start = *route.V4IPStart
|
|
||||||
}
|
|
||||||
if route.V4IPEnd != nil {
|
|
||||||
v4End = *route.V4IPEnd
|
|
||||||
}
|
|
||||||
|
|
||||||
_, err = d.db.Exec(query,
|
|
||||||
route.ID.String(),
|
|
||||||
route.Prefix,
|
|
||||||
route.MaskLength,
|
|
||||||
route.OriginASN,
|
|
||||||
route.PeerIP,
|
|
||||||
string(pathJSON),
|
|
||||||
route.NextHop,
|
|
||||||
route.LastUpdated,
|
|
||||||
v4Start,
|
|
||||||
v4End,
|
|
||||||
)
|
|
||||||
} else {
|
} else {
|
||||||
_, err = d.db.Exec(query,
|
inserted, err = upsertRouteRowV6(upd, ins, route, string(pathJSON))
|
||||||
route.ID.String(),
|
}
|
||||||
route.Prefix,
|
if err != nil {
|
||||||
route.MaskLength,
|
return fmt.Errorf("failed to upsert route %s: %w", route.Prefix, err)
|
||||||
route.OriginASN,
|
|
||||||
route.PeerIP,
|
|
||||||
string(pathJSON),
|
|
||||||
route.NextHop,
|
|
||||||
route.LastUpdated,
|
|
||||||
)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
return err
|
if inserted {
|
||||||
|
if route.IPVersion == ipVersionV4 {
|
||||||
|
d.counts.addRoutes(1, 0)
|
||||||
|
} else {
|
||||||
|
d.counts.addRoutes(0, 1)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// DeleteLiveRoute deletes a live route
|
// DeleteLiveRoute deletes a live route
|
||||||
@@ -1103,23 +1202,41 @@ func (d *Database) DeleteLiveRoute(prefix string, originASN int, peerIP string)
|
|||||||
return fmt.Errorf("invalid prefix format: %w", err)
|
return fmt.Errorf("invalid prefix format: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
tableName := "live_routes_v4"
|
isV4 := ipnet.IP.To4() != nil
|
||||||
if ipnet.IP.To4() == nil {
|
|
||||||
tableName = "live_routes_v6"
|
|
||||||
}
|
|
||||||
|
|
||||||
var query string
|
// Literal per-table queries (rather than one formatted with the table name)
|
||||||
if originASN == 0 {
|
// so the delete carries no dynamically built SQL. A delete with no origin
|
||||||
// Delete all routes for this prefix from this peer
|
// ASN can remove several rows.
|
||||||
query = fmt.Sprintf(`DELETE FROM %s WHERE prefix = ? AND peer_ip = ?`, tableName)
|
var res sql.Result
|
||||||
_, err = d.db.Exec(query, prefix, peerIP)
|
switch {
|
||||||
} else {
|
case isV4 && originASN == 0:
|
||||||
// Delete specific route
|
res, err = d.db.Exec(`DELETE FROM live_routes_v4 WHERE prefix = ? AND peer_ip = ?`, prefix, peerIP)
|
||||||
query = fmt.Sprintf(`DELETE FROM %s WHERE prefix = ? AND origin_asn = ? AND peer_ip = ?`, tableName)
|
case isV4:
|
||||||
_, err = d.db.Exec(query, prefix, originASN, peerIP)
|
res, err = d.db.Exec(
|
||||||
|
`DELETE FROM live_routes_v4 WHERE prefix = ? AND origin_asn = ? AND peer_ip = ?`,
|
||||||
|
prefix, originASN, peerIP)
|
||||||
|
case originASN == 0:
|
||||||
|
res, err = d.db.Exec(`DELETE FROM live_routes_v6 WHERE prefix = ? AND peer_ip = ?`, prefix, peerIP)
|
||||||
|
default:
|
||||||
|
res, err = d.db.Exec(
|
||||||
|
`DELETE FROM live_routes_v6 WHERE prefix = ? AND origin_asn = ? AND peer_ip = ?`,
|
||||||
|
prefix, originASN, peerIP)
|
||||||
}
|
}
|
||||||
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
|
}
|
||||||
|
|
||||||
|
affected, err := res.RowsAffected()
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
if isV4 {
|
||||||
|
d.counts.addRoutes(-int(affected), 0)
|
||||||
|
} else {
|
||||||
|
d.counts.addRoutes(0, -int(affected))
|
||||||
|
}
|
||||||
|
|
||||||
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// GetPrefixDistribution returns the distribution of unique prefixes by mask length
|
// GetPrefixDistribution returns the distribution of unique prefixes by mask length
|
||||||
|
|||||||
@@ -18,6 +18,8 @@ type Stats struct {
|
|||||||
Peers int
|
Peers int
|
||||||
FileSizeBytes int64
|
FileSizeBytes int64
|
||||||
LiveRoutes int
|
LiveRoutes int
|
||||||
|
IPv4Routes int
|
||||||
|
IPv6Routes int
|
||||||
OldestRoute *time.Time
|
OldestRoute *time.Time
|
||||||
NewestRoute *time.Time
|
NewestRoute *time.Time
|
||||||
IPv4PrefixDistribution []PrefixDistribution
|
IPv4PrefixDistribution []PrefixDistribution
|
||||||
|
|||||||
@@ -450,7 +450,7 @@ func TestRouteWatchLiveFeed(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Create server
|
// Create server
|
||||||
srv := server.New(mockDB, s, logger)
|
srv := server.New(mockDB, s, logger, cfg)
|
||||||
|
|
||||||
// Create RouteWatch with 5 second limit
|
// Create RouteWatch with 5 second limit
|
||||||
deps := Dependencies{
|
deps := Dependencies{
|
||||||
|
|||||||
@@ -219,13 +219,6 @@ func (s *Server) handleStatusJSON() http.HandlerFunc {
|
|||||||
|
|
||||||
const bitsPerMegabit = 1000000.0
|
const bitsPerMegabit = 1000000.0
|
||||||
|
|
||||||
// Get route counts from database
|
|
||||||
ipv4Routes, ipv6Routes, err := s.db.GetLiveRouteCountsContext(ctx)
|
|
||||||
if err != nil {
|
|
||||||
s.logger.Warn("Failed to get live route counts", "error", err)
|
|
||||||
// Continue with zero counts
|
|
||||||
}
|
|
||||||
|
|
||||||
// Get route update metrics
|
// Get route update metrics
|
||||||
routeMetrics := s.streamer.GetMetricsTracker().GetRouteMetrics()
|
routeMetrics := s.streamer.GetMetricsTracker().GetRouteMetrics()
|
||||||
|
|
||||||
@@ -259,8 +252,8 @@ func (s *Server) handleStatusJSON() http.HandlerFunc {
|
|||||||
Peers: dbStats.Peers,
|
Peers: dbStats.Peers,
|
||||||
DatabaseSizeBytes: dbStats.FileSizeBytes,
|
DatabaseSizeBytes: dbStats.FileSizeBytes,
|
||||||
LiveRoutes: dbStats.LiveRoutes,
|
LiveRoutes: dbStats.LiveRoutes,
|
||||||
IPv4Routes: ipv4Routes,
|
IPv4Routes: dbStats.IPv4Routes,
|
||||||
IPv6Routes: ipv6Routes,
|
IPv6Routes: dbStats.IPv6Routes,
|
||||||
OldestRoute: dbStats.OldestRoute,
|
OldestRoute: dbStats.OldestRoute,
|
||||||
NewestRoute: dbStats.NewestRoute,
|
NewestRoute: dbStats.NewestRoute,
|
||||||
IPv4UpdatesPerSec: routeMetrics.IPv4UpdatesPerSec,
|
IPv4UpdatesPerSec: routeMetrics.IPv4UpdatesPerSec,
|
||||||
@@ -439,13 +432,6 @@ func (s *Server) handleStats() http.HandlerFunc {
|
|||||||
|
|
||||||
const bitsPerMegabit = 1000000.0
|
const bitsPerMegabit = 1000000.0
|
||||||
|
|
||||||
// Get route counts from database
|
|
||||||
ipv4Routes, ipv6Routes, err := s.db.GetLiveRouteCountsContext(ctx)
|
|
||||||
if err != nil {
|
|
||||||
s.logger.Warn("Failed to get live route counts", "error", err)
|
|
||||||
// Continue with zero counts
|
|
||||||
}
|
|
||||||
|
|
||||||
// Get route update metrics
|
// Get route update metrics
|
||||||
routeMetrics := s.streamer.GetMetricsTracker().GetRouteMetrics()
|
routeMetrics := s.streamer.GetMetricsTracker().GetRouteMetrics()
|
||||||
|
|
||||||
@@ -537,8 +523,8 @@ func (s *Server) handleStats() http.HandlerFunc {
|
|||||||
Peers: dbStats.Peers,
|
Peers: dbStats.Peers,
|
||||||
DatabaseSizeBytes: dbStats.FileSizeBytes,
|
DatabaseSizeBytes: dbStats.FileSizeBytes,
|
||||||
LiveRoutes: dbStats.LiveRoutes,
|
LiveRoutes: dbStats.LiveRoutes,
|
||||||
IPv4Routes: ipv4Routes,
|
IPv4Routes: dbStats.IPv4Routes,
|
||||||
IPv6Routes: ipv6Routes,
|
IPv6Routes: dbStats.IPv6Routes,
|
||||||
OldestRoute: dbStats.OldestRoute,
|
OldestRoute: dbStats.OldestRoute,
|
||||||
NewestRoute: dbStats.NewestRoute,
|
NewestRoute: dbStats.NewestRoute,
|
||||||
IPv4UpdatesPerSec: routeMetrics.IPv4UpdatesPerSec,
|
IPv4UpdatesPerSec: routeMetrics.IPv4UpdatesPerSec,
|
||||||
|
|||||||
@@ -8,6 +8,7 @@ import (
|
|||||||
"testing"
|
"testing"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
|
"git.eeqj.de/sneak/routewatch/internal/config"
|
||||||
"git.eeqj.de/sneak/routewatch/internal/database"
|
"git.eeqj.de/sneak/routewatch/internal/database"
|
||||||
"git.eeqj.de/sneak/routewatch/internal/logger"
|
"git.eeqj.de/sneak/routewatch/internal/logger"
|
||||||
"git.eeqj.de/sneak/routewatch/internal/metrics"
|
"git.eeqj.de/sneak/routewatch/internal/metrics"
|
||||||
@@ -38,7 +39,7 @@ func (d blockingStatsDB) GetStatsContext(_ context.Context) (database.Stats, err
|
|||||||
func TestStatsHandlersDoNotLeakOnTimeout(t *testing.T) {
|
func TestStatsHandlersDoNotLeakOnTimeout(t *testing.T) {
|
||||||
release := make(chan struct{})
|
release := make(chan struct{})
|
||||||
db := blockingStatsDB{release: release}
|
db := blockingStatsDB{release: release}
|
||||||
s := New(db, streamer.New(logger.New(), metrics.New()), logger.New())
|
s := New(db, streamer.New(logger.New(), metrics.New()), logger.New(), &config.Config{})
|
||||||
|
|
||||||
handlers := map[string]http.HandlerFunc{
|
handlers := map[string]http.HandlerFunc{
|
||||||
"status.json": s.handleStatusJSON(),
|
"status.json": s.handleStatusJSON(),
|
||||||
|
|||||||
@@ -4,9 +4,10 @@ package server
|
|||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
"net/http"
|
"net/http"
|
||||||
"os"
|
"strconv"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
|
"git.eeqj.de/sneak/routewatch/internal/config"
|
||||||
"git.eeqj.de/sneak/routewatch/internal/database"
|
"git.eeqj.de/sneak/routewatch/internal/database"
|
||||||
"git.eeqj.de/sneak/routewatch/internal/logger"
|
"git.eeqj.de/sneak/routewatch/internal/logger"
|
||||||
"git.eeqj.de/sneak/routewatch/internal/streamer"
|
"git.eeqj.de/sneak/routewatch/internal/streamer"
|
||||||
@@ -33,16 +34,18 @@ type Server struct {
|
|||||||
db database.Store
|
db database.Store
|
||||||
streamer *streamer.Streamer
|
streamer *streamer.Streamer
|
||||||
logger *logger.Logger
|
logger *logger.Logger
|
||||||
|
port int
|
||||||
srv *http.Server
|
srv *http.Server
|
||||||
asnFetcher ASNFetcher
|
asnFetcher ASNFetcher
|
||||||
}
|
}
|
||||||
|
|
||||||
// New creates a new HTTP server
|
// New creates a new HTTP server
|
||||||
func New(db database.Store, streamer *streamer.Streamer, logger *logger.Logger) *Server {
|
func New(db database.Store, streamer *streamer.Streamer, logger *logger.Logger, cfg *config.Config) *Server {
|
||||||
s := &Server{
|
s := &Server{
|
||||||
db: db,
|
db: db,
|
||||||
streamer: streamer,
|
streamer: streamer,
|
||||||
logger: logger,
|
logger: logger,
|
||||||
|
port: cfg.Port,
|
||||||
}
|
}
|
||||||
|
|
||||||
s.setupRoutes()
|
s.setupRoutes()
|
||||||
@@ -52,11 +55,6 @@ func New(db database.Store, streamer *streamer.Streamer, logger *logger.Logger)
|
|||||||
|
|
||||||
// Start starts the HTTP server
|
// Start starts the HTTP server
|
||||||
func (s *Server) Start() error {
|
func (s *Server) Start() error {
|
||||||
port := os.Getenv("PORT")
|
|
||||||
if port == "" {
|
|
||||||
port = "8080"
|
|
||||||
}
|
|
||||||
|
|
||||||
const (
|
const (
|
||||||
readHeaderTimeout = 40 * time.Second
|
readHeaderTimeout = 40 * time.Second
|
||||||
readTimeout = 60 * time.Second
|
readTimeout = 60 * time.Second
|
||||||
@@ -65,7 +63,7 @@ func (s *Server) Start() error {
|
|||||||
)
|
)
|
||||||
|
|
||||||
s.srv = &http.Server{
|
s.srv = &http.Server{
|
||||||
Addr: ":" + port,
|
Addr: ":" + strconv.Itoa(s.port),
|
||||||
Handler: s.router,
|
Handler: s.router,
|
||||||
ReadHeaderTimeout: readHeaderTimeout,
|
ReadHeaderTimeout: readHeaderTimeout,
|
||||||
ReadTimeout: readTimeout,
|
ReadTimeout: readTimeout,
|
||||||
@@ -73,7 +71,7 @@ func (s *Server) Start() error {
|
|||||||
IdleTimeout: idleTimeout,
|
IdleTimeout: idleTimeout,
|
||||||
}
|
}
|
||||||
|
|
||||||
s.logger.Info("Starting HTTP server", "port", port, "addr", s.srv.Addr)
|
s.logger.Info("Starting HTTP server", "port", s.port, "addr", s.srv.Addr)
|
||||||
|
|
||||||
// Start in goroutine but log when actually listening
|
// Start in goroutine but log when actually listening
|
||||||
go func() {
|
go func() {
|
||||||
|
|||||||
@@ -210,9 +210,14 @@ func (s *Streamer) Start() error {
|
|||||||
// the connection status in metrics. This method is safe to call multiple times.
|
// the connection status in metrics. This method is safe to call multiple times.
|
||||||
func (s *Streamer) Stop() {
|
func (s *Streamer) Stop() {
|
||||||
s.mu.Lock()
|
s.mu.Lock()
|
||||||
if s.cancel != nil {
|
if s.cancel == nil {
|
||||||
s.cancel()
|
// Not started, or already stopped: closing the queues again would panic.
|
||||||
|
s.mu.Unlock()
|
||||||
|
|
||||||
|
return
|
||||||
}
|
}
|
||||||
|
s.cancel()
|
||||||
|
s.cancel = nil
|
||||||
// Close all handler queues to signal workers to stop
|
// Close all handler queues to signal workers to stop
|
||||||
for _, info := range s.handlers {
|
for _, info := range s.handlers {
|
||||||
close(info.queue)
|
close(info.queue)
|
||||||
@@ -660,8 +665,15 @@ func (s *Streamer) stream(ctx context.Context) error {
|
|||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
|
||||||
// Dispatch to interested handlers
|
// Dispatch to interested handlers. Stop cancels ctx and closes the
|
||||||
|
// queues under the write lock, so if ctx is cancelled here, under the
|
||||||
|
// read lock, the queues are closed and must not be sent to.
|
||||||
s.mu.RLock()
|
s.mu.RLock()
|
||||||
|
if ctx.Err() != nil {
|
||||||
|
s.mu.RUnlock()
|
||||||
|
|
||||||
|
return ctx.Err()
|
||||||
|
}
|
||||||
for _, info := range s.handlers {
|
for _, info := range s.handlers {
|
||||||
if !info.handler.WantsMessage(msg.Type) {
|
if !info.handler.WantsMessage(msg.Type) {
|
||||||
continue
|
continue
|
||||||
|
|||||||
@@ -2,6 +2,8 @@ package streamer
|
|||||||
|
|
||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
|
"errors"
|
||||||
|
"io"
|
||||||
"net/http"
|
"net/http"
|
||||||
"net/http/httptest"
|
"net/http/httptest"
|
||||||
"runtime"
|
"runtime"
|
||||||
@@ -10,6 +12,7 @@ import (
|
|||||||
|
|
||||||
"git.eeqj.de/sneak/routewatch/internal/logger"
|
"git.eeqj.de/sneak/routewatch/internal/logger"
|
||||||
"git.eeqj.de/sneak/routewatch/internal/metrics"
|
"git.eeqj.de/sneak/routewatch/internal/metrics"
|
||||||
|
"git.eeqj.de/sneak/routewatch/internal/ristypes"
|
||||||
)
|
)
|
||||||
|
|
||||||
func TestNewStreamer(t *testing.T) {
|
func TestNewStreamer(t *testing.T) {
|
||||||
@@ -75,6 +78,45 @@ func TestStreamDoesNotLeakTickersAcrossReconnects(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// updateHandler wants UPDATE messages and does nothing with them.
|
||||||
|
type updateHandler struct{}
|
||||||
|
|
||||||
|
func (updateHandler) WantsMessage(messageType string) bool { return messageType == "UPDATE" }
|
||||||
|
func (updateHandler) HandleMessage(*ristypes.RISMessage) {}
|
||||||
|
func (updateHandler) QueueCapacity() int { return 10 }
|
||||||
|
|
||||||
|
// TestStopBeforeMessageReachesQueues stops the streamer after the read loop
|
||||||
|
// has checked for cancellation but before it hands the message to the handler
|
||||||
|
// queues. That is the gap a stop from another goroutine can land in, and it
|
||||||
|
// used to end in "send on closed channel". The raw handler runs in that gap on
|
||||||
|
// the read loop itself, so calling Stop from it hits the gap every time.
|
||||||
|
func TestStopBeforeMessageReachesQueues(t *testing.T) {
|
||||||
|
const line = `{"type":"ris_message","data":{"type":"UPDATE","peer":"192.0.2.1",` +
|
||||||
|
`"peer_asn":"64496","timestamp":1700000000}}` + "\n"
|
||||||
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
|
||||||
|
_, _ = io.WriteString(w, line)
|
||||||
|
}))
|
||||||
|
defer srv.Close()
|
||||||
|
|
||||||
|
s := New(logger.New(), metrics.New())
|
||||||
|
s.url = srv.URL
|
||||||
|
s.RegisterHandler(updateHandler{})
|
||||||
|
s.RegisterRawHandler(func(string) { s.Stop() })
|
||||||
|
|
||||||
|
// Start would run the stream in the background, where the test cannot
|
||||||
|
// wait for it. Setting cancel as Start does lets Stop cancel the stream
|
||||||
|
// run here instead.
|
||||||
|
ctx, cancel := context.WithCancel(context.Background())
|
||||||
|
s.cancel = cancel
|
||||||
|
|
||||||
|
if err := s.stream(ctx); !errors.Is(err, context.Canceled) {
|
||||||
|
t.Fatalf("stream returned %v, want %v", err, context.Canceled)
|
||||||
|
}
|
||||||
|
|
||||||
|
// A second Stop must not close the queues again.
|
||||||
|
s.Stop()
|
||||||
|
}
|
||||||
|
|
||||||
// settledGoroutineCount lets transient goroutines finish, then reports the
|
// settledGoroutineCount lets transient goroutines finish, then reports the
|
||||||
// current count.
|
// current count.
|
||||||
func settledGoroutineCount() int {
|
func settledGoroutineCount() int {
|
||||||
|
|||||||
Reference in New Issue
Block a user