sneak
ce06170604
All checks were successful
check / check (push) Successful in 1m44s
The stricter canonical .golangci.yml surfaced 81 findings in the config validation code merged from main (#53). Fix them all with no behavior change: static sentinel errors wrapped with %w preserving the existing messages (err113), config key name constants (goconst), t.Parallel() throughout except the Setenv/Chdir test (paralleltest), white-box test renamed to config_validation_internal_test.go (testpackage), case tables extracted into builder functions plus a shared runAbortCases helper (funlen/dupl/gochecknoglobals), plain error assignments (noinlineerr), any instead of interface{} and strings.SplitSeq (modernize), slog.DiscardHandler (sloglint), 88-col wrapping (lll), and removal of two stale nolint:gosec directives (nolintlint).
99 lines
2.2 KiB
Go
99 lines
2.2 KiB
Go
package config
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"git.eeqj.de/sneak/smartconfig"
|
|
)
|
|
|
|
// writeTestConfig writes yamlContent to a temp config file and returns
|
|
// the file path.
|
|
func writeTestConfig(t *testing.T, yamlContent string) string {
|
|
t.Helper()
|
|
|
|
tmpDir := t.TempDir()
|
|
configPath := filepath.Join(tmpDir, "config.yml")
|
|
|
|
err := os.WriteFile(configPath, []byte(yamlContent), 0o600)
|
|
if err != nil {
|
|
t.Fatalf("failed to write test config: %v", err)
|
|
}
|
|
|
|
return configPath
|
|
}
|
|
|
|
// checkAllowlistHosts loads the config at configPath and asserts that
|
|
// getStringSlice returns the three expected hosts.
|
|
func checkAllowlistHosts(t *testing.T, configPath string) {
|
|
t.Helper()
|
|
|
|
sc, err := loadTestConfig(configPath)
|
|
if err != nil {
|
|
t.Fatalf("failed to load config: %v", err)
|
|
}
|
|
|
|
hosts := getStringSlice(sc)
|
|
|
|
if len(hosts) != 3 {
|
|
t.Errorf("expected 3 hosts, got %d: %v", len(hosts), hosts)
|
|
}
|
|
|
|
expected := []string{"static.sneak.cloud", "sneak.berlin", testHostS3}
|
|
for i, want := range expected {
|
|
if i >= len(hosts) {
|
|
t.Errorf("missing host at index %d: want %q", i, want)
|
|
|
|
continue
|
|
}
|
|
|
|
if hosts[i] != want {
|
|
t.Errorf("host[%d] = %q, want %q", i, hosts[i], want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestGetStringSlice_YAMLList(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
yamlContent := `
|
|
allowlist_hosts:
|
|
- static.sneak.cloud
|
|
- sneak.berlin
|
|
- s3.sneak.cloud
|
|
`
|
|
|
|
checkAllowlistHosts(t, writeTestConfig(t, yamlContent))
|
|
}
|
|
|
|
func TestGetStringSlice_CommaSeparated(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// Backwards compatibility with comma-separated string values.
|
|
yamlContent := `allowlist_hosts: "static.sneak.cloud, sneak.berlin, s3.sneak.cloud"`
|
|
|
|
checkAllowlistHosts(t, writeTestConfig(t, yamlContent))
|
|
}
|
|
|
|
func TestGetStringSlice_Empty(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
configPath := writeTestConfig(t, `port: 8080`)
|
|
|
|
sc, err := loadTestConfig(configPath)
|
|
if err != nil {
|
|
t.Fatalf("failed to load config: %v", err)
|
|
}
|
|
|
|
hosts := getStringSlice(sc)
|
|
if len(hosts) != 0 {
|
|
t.Errorf("expected nil or empty slice, got %v", hosts)
|
|
}
|
|
}
|
|
|
|
// loadTestConfig is a helper to load a config file for testing.
|
|
func loadTestConfig(path string) (*smartconfig.Config, error) {
|
|
return smartconfig.NewFromConfigPath(path)
|
|
}
|