clawbot
37d49ade11
check / check (push) Failing after 1s
The http.Server now sets ReadHeaderTimeout (10s), which bounds the slow header dribble that ReadTimeout alone does not, and IdleTimeout (120s), which bounds keep-alive reuse. Server construction moved into a small helper so a test can assert the timeouts without binding a listener. POST / and POST /generate bodies are capped at 1 MiB and an oversized body returns 413. What a reader would trip over: the CSRF library reads its token from the form and swallows a parse error, so a cap applied only inside it would surface as 403. The body limit therefore parses the form under the cap before the CSRF check; the parsed form is reused afterwards. A test covers an oversized body that carries a valid token. Judgement call: WriteTimeout stays at 60s; it also bounds how long a large image may take to send over a slow link. Model: opus-4-8 (implementation, review); fable-5-1 (landing message)
61 lines
1.7 KiB
Go
61 lines
1.7 KiB
Go
package server
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
"time"
|
|
)
|
|
|
|
// HTTP server configuration constants.
|
|
const (
|
|
HTTPReadTimeout = 30 * time.Second
|
|
// HTTPReadHeaderTimeout bounds the request-header read on its own,
|
|
// short, so a slowloris client dribbling headers is dropped well
|
|
// before it ties up a connection for the whole ReadTimeout window.
|
|
HTTPReadHeaderTimeout = 10 * time.Second
|
|
HTTPWriteTimeout = 60 * time.Second
|
|
// HTTPIdleTimeout bounds how long an idle keep-alive connection is
|
|
// held open, so idle connections cannot accumulate without limit on a
|
|
// service targeting high concurrency.
|
|
HTTPIdleTimeout = 120 * time.Second
|
|
HTTPMaxHeaderBytes = 8 << 10 // 8KB
|
|
)
|
|
|
|
// newHTTPServer builds the http.Server with the hardening timeouts and
|
|
// limits applied. It is separate from serveUntilShutdown so the
|
|
// configuration can be asserted in a test without binding a listener.
|
|
func (s *Server) newHTTPServer() *http.Server {
|
|
return &http.Server{
|
|
Addr: fmt.Sprintf(":%d", s.config.Port),
|
|
ReadTimeout: HTTPReadTimeout,
|
|
ReadHeaderTimeout: HTTPReadHeaderTimeout,
|
|
WriteTimeout: HTTPWriteTimeout,
|
|
IdleTimeout: HTTPIdleTimeout,
|
|
MaxHeaderBytes: HTTPMaxHeaderBytes,
|
|
Handler: s,
|
|
}
|
|
}
|
|
|
|
func (s *Server) serveUntilShutdown() {
|
|
s.httpServer = s.newHTTPServer()
|
|
|
|
s.SetupRoutes()
|
|
|
|
s.log.Info("http begin listen", "listenaddr", s.httpServer.Addr)
|
|
|
|
err := s.httpServer.ListenAndServe()
|
|
if err != nil && !errors.Is(err, http.ErrServerClosed) {
|
|
s.log.Error("listen error", "error", err)
|
|
|
|
if s.cancelFunc != nil {
|
|
s.cancelFunc()
|
|
}
|
|
}
|
|
}
|
|
|
|
// ServeHTTP implements http.Handler.
|
|
func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
|
|
s.router.ServeHTTP(w, r)
|
|
}
|