check / check (push) Canceled after 0s
The image request now holds only its source and its transform, exactly what the variant key covers. The /v1/image/ handler checks the allowlist and verifies the signature itself with Signer.Verify(req, sig, expires). Both image handlers keep the URL's expiry as a local value for Cache-Control. The image service holds no signer, allowlist or AllowHTTP, and ValidateRequest is gone. The fetcher takes the source and builds its URL with Source.URL from its own AllowHTTP, so no URL string is built and parsed again. chooseAutoFormat returns the format it chooses instead of writing into the request. The signed URL format and every route's answers are unchanged. Model: opus-5-5
192 lines
5.7 KiB
Go
192 lines
5.7 KiB
Go
package handlers
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"strconv"
|
|
"time"
|
|
|
|
"github.com/go-chi/chi/v5"
|
|
"github.com/go-chi/chi/v5/middleware"
|
|
|
|
"sneak.berlin/go/pixa/internal/encurl"
|
|
"sneak.berlin/go/pixa/internal/httpfetcher"
|
|
"sneak.berlin/go/pixa/internal/imageprocessor"
|
|
"sneak.berlin/go/pixa/internal/imagerequest"
|
|
"sneak.berlin/go/pixa/internal/imgcache"
|
|
"sneak.berlin/go/pixa/internal/magic"
|
|
)
|
|
|
|
// HandleImageEnc handles requests to /v1/e/{token}/* for encrypted
|
|
// image URLs. The trailing path (e.g., /img.jpg) is ignored but helps
|
|
// browsers identify the content type.
|
|
func (s *Handlers) HandleImageEnc() http.HandlerFunc {
|
|
return func(w http.ResponseWriter, r *http.Request) {
|
|
if s.refuseBlockedReferer(w, r) {
|
|
return
|
|
}
|
|
|
|
ctx := r.Context()
|
|
start := time.Now()
|
|
|
|
req, expires, ok := s.parseImageEncRequest(w, r)
|
|
if !ok {
|
|
return
|
|
}
|
|
|
|
format, ok := s.chooseAutoFormat(w, r, req.Transform.Format)
|
|
if !ok {
|
|
return
|
|
}
|
|
|
|
req.Transform.Format = format
|
|
|
|
// Log the request
|
|
s.log.Debug("encrypted image request",
|
|
"host", req.Source.Host,
|
|
"path", req.Source.Path,
|
|
"dimensions", fmt.Sprintf("%dx%d",
|
|
req.Transform.Size.Width, req.Transform.Size.Height),
|
|
"format", req.Transform.Format,
|
|
)
|
|
|
|
// Fetch and process the image (no signature validation
|
|
// needed - encrypted URL is trusted)
|
|
resp, err := s.imgSvc.Get(ctx, req)
|
|
if err != nil {
|
|
s.handleImageError(w, err)
|
|
|
|
return
|
|
}
|
|
|
|
defer func() { _ = resp.Content.Close() }()
|
|
|
|
// Set response headers
|
|
w.Header().Set("Content-Type", resp.ContentType)
|
|
|
|
if resp.ContentLength > 0 {
|
|
w.Header().Set("Content-Length", strconv.FormatInt(resp.ContentLength, 10))
|
|
}
|
|
|
|
// Cache headers: max-age ends at the URL's expiry
|
|
w.Header().Set("Cache-Control", cacheControl(expires))
|
|
w.Header().Set("X-Pixa-Cache", string(resp.CacheStatus))
|
|
|
|
if notModified(w, r, resp.ETag) {
|
|
return
|
|
}
|
|
|
|
// A HEAD request gets the headers only
|
|
if r.Method == http.MethodHead {
|
|
w.WriteHeader(http.StatusOK)
|
|
|
|
return
|
|
}
|
|
|
|
// Stream the response
|
|
written, err := io.Copy(w, resp.Content)
|
|
if err != nil {
|
|
s.log.Error("failed to write response", "error", err)
|
|
|
|
return
|
|
}
|
|
|
|
// Log completion
|
|
duration := time.Since(start)
|
|
s.log.Info("image served",
|
|
"request_id", middleware.GetReqID(ctx),
|
|
"cache_key", imagerequest.CacheKey(req),
|
|
"host", req.Source.Host,
|
|
"path", req.Source.Path,
|
|
"format", req.Transform.Format,
|
|
"cache_status", resp.CacheStatus,
|
|
"served_bytes", written,
|
|
"duration_ms", duration.Milliseconds(),
|
|
)
|
|
}
|
|
}
|
|
|
|
// parseImageEncRequest decrypts the token of an encrypted image URL into an
|
|
// image request and checks it, and returns it with the token's expiry. On a
|
|
// token that is missing, does not decrypt, has expired or asks for something
|
|
// not valid, it writes an error response and returns false.
|
|
func (s *Handlers) parseImageEncRequest(
|
|
w http.ResponseWriter, r *http.Request,
|
|
) (*imagerequest.Request, time.Time, bool) {
|
|
// Extract token from URL
|
|
token := chi.URLParam(r, "token")
|
|
if token == "" {
|
|
s.respondError(w, "missing token", http.StatusBadRequest)
|
|
|
|
return nil, time.Time{}, false
|
|
}
|
|
|
|
// Decrypt and validate the payload
|
|
req, expires, err := s.encGen.Parse(token)
|
|
if err != nil {
|
|
if errors.Is(err, encurl.ErrExpired) {
|
|
s.log.Debug("encrypted URL expired", "error", err)
|
|
s.respondError(w, "URL has expired", http.StatusGone)
|
|
|
|
return nil, time.Time{}, false
|
|
}
|
|
|
|
s.log.Debug("failed to decrypt URL", "error", err)
|
|
s.respondError(w, "invalid encrypted URL", http.StatusBadRequest)
|
|
|
|
return nil, time.Time{}, false
|
|
}
|
|
|
|
// Apply the same dimension and fit-mode bounds as the plain image
|
|
// route: a sealed payload is trusted for its origin, not for staying
|
|
// within limits, so an over-limit size or unknown fit mode is a 400
|
|
// here rather than an out-of-memory or a 500 from the processor.
|
|
err = imagerequest.ValidateImageRequest(req)
|
|
if err != nil {
|
|
s.log.Debug("encrypted URL failed validation", "error", err)
|
|
s.respondError(w, "invalid encrypted URL: "+err.Error(),
|
|
http.StatusBadRequest)
|
|
|
|
return nil, time.Time{}, false
|
|
}
|
|
|
|
return req, expires, true
|
|
}
|
|
|
|
// handleImageError converts image service errors to HTTP responses.
|
|
func (s *Handlers) handleImageError(w http.ResponseWriter, err error) {
|
|
switch {
|
|
case errors.Is(err, httpfetcher.ErrSSRFBlocked):
|
|
s.respondError(w, "forbidden", http.StatusForbidden)
|
|
case errors.Is(err, httpfetcher.ErrUpstreamError):
|
|
s.respondError(w, "upstream error", http.StatusBadGateway)
|
|
case errors.Is(err, httpfetcher.ErrUpstreamTimeout):
|
|
s.respondError(w, "upstream timeout", http.StatusGatewayTimeout)
|
|
case errors.Is(err, httpfetcher.ErrTooManyConnections),
|
|
errors.Is(err, imageprocessor.ErrTooManyImages),
|
|
errors.Is(err, imgcache.ErrProcessingTimedOut):
|
|
s.respondError(w, "server busy, try again later",
|
|
http.StatusServiceUnavailable)
|
|
case errors.Is(err, httpfetcher.ErrInvalidContentType),
|
|
errors.Is(err, imageprocessor.ErrUnsupportedInputFormat),
|
|
errors.Is(err, magic.ErrMagicByteMismatch),
|
|
errors.Is(err, magic.ErrUnknownFormat),
|
|
errors.Is(err, magic.ErrNotEnoughData):
|
|
s.respondError(w, "unsupported source format",
|
|
http.StatusUnsupportedMediaType)
|
|
case errors.Is(err, imageprocessor.ErrOutputTooLarge):
|
|
s.respondError(w, fmt.Sprintf("size too large for the source: the side "+
|
|
"computed from its proportions is above %d",
|
|
imageprocessor.MaxOutputDimension), http.StatusBadRequest)
|
|
case errors.Is(err, imageprocessor.ErrAVIFOutputTooLarge):
|
|
s.respondError(w, fmt.Sprintf("size too large for AVIF: the output "+
|
|
"would be above %d pixels", imageprocessor.MaxAVIFOutputPixels),
|
|
http.StatusBadRequest)
|
|
default:
|
|
s.log.Error("image request failed", "error", err)
|
|
s.respondError(w, "internal error", http.StatusInternalServerError)
|
|
}
|
|
}
|