sneak
65560f7af8
check / check (push) Canceled after 0s
HandleImage parses the path and verifies the signature, and HandleImageEnc decrypts the token. Each then calls serveImage, which chooses the format for auto, gets the image and serves it: the headers, ETag and 304, HEAD, the copy and the log line. respondImageError answers the image service's errors on both routes, and handleImageError is gone. /v1/image/ now answers 504 when the upstream sends no response headers within upstream_fetch_timeout, as README.md documented for /v1/e/. respondImageError logs a 500 at error level and every other answer at warn. A failed write is logged once, with the request and the bytes served. README.md lists each image route's answers as bullets. Tests send the same errors through both routes. Model: opus-5-5
40 lines
1.2 KiB
Go
40 lines
1.2 KiB
Go
package handlers
|
|
|
|
import (
|
|
"fmt"
|
|
"log/slog"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
|
|
"sneak.berlin/go/pixa/internal/imageprocessor"
|
|
"sneak.berlin/go/pixa/internal/imagerequest"
|
|
)
|
|
|
|
// TestAVIFOutputTooLargeAnswers400 checks that respondImageError, which
|
|
// answers the errors of both image routes, answers 400 naming the AVIF pixel
|
|
// limit when the image processor refuses an AVIF output above it, wrapped as
|
|
// the service wraps it. The request's source only goes into a log line, so it
|
|
// is left empty.
|
|
func TestAVIFOutputTooLargeAnswers400(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
h := &Handlers{log: slog.New(slog.DiscardHandler)}
|
|
err := fmt.Errorf("image processing failed: %w: 4097x4096",
|
|
imageprocessor.ErrAVIFOutputTooLarge)
|
|
wantBody := fmt.Sprintf("above %d pixels", imageprocessor.MaxAVIFOutputPixels)
|
|
|
|
rec := httptest.NewRecorder()
|
|
h.respondImageError(rec, &imagerequest.Request{}, err)
|
|
t.Logf("status = %d, body = %q", rec.Code, rec.Body.String())
|
|
|
|
if rec.Code != http.StatusBadRequest {
|
|
t.Errorf("status = %d, want %d", rec.Code, http.StatusBadRequest)
|
|
}
|
|
|
|
if !strings.Contains(rec.Body.String(), wantBody) {
|
|
t.Errorf("body = %q, want it to say %q", rec.Body.String(), wantBody)
|
|
}
|
|
}
|