sneak
23506df609
All checks were successful
check / check (push) Successful in 2m3s
Replace .golangci.yml with the canonical v2-schema config (default: all minus six disabled linters, lll 88, tests included) and bump every golangci-lint pin to v2.12.2: - Dockerfile: golangci/golangci-lint:v2.12.2-alpine (hash-pinned) - script/bootstrap: GOLANGCI_LINT_VERSION 2.12.2 with new linux-amd64/arm64 release-archive sha256 pins Fix all 747 findings the stricter config surfaces, with no behavior changes: t.Parallel() throughout the test suite, static sentinel errors and errors.Is comparisons, checked error returns, context propagation (contextcheck/noctx), 88-column wrapping, extracted constants and helpers for goconst/dupl/funlen/cyclop, exhaustive switch cases replicating existing defaults, and white-box test files renamed to *_internal_test.go for testpackage. Three nolint:tagliatelle directives preserve the existing snake_case JSON wire and on-disk metadata formats.
99 lines
2.2 KiB
Go
99 lines
2.2 KiB
Go
package config
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"git.eeqj.de/sneak/smartconfig"
|
|
)
|
|
|
|
// writeTestConfig writes yamlContent to a temp config file and returns
|
|
// the file path.
|
|
func writeTestConfig(t *testing.T, yamlContent string) string {
|
|
t.Helper()
|
|
|
|
tmpDir := t.TempDir()
|
|
configPath := filepath.Join(tmpDir, "config.yml")
|
|
|
|
err := os.WriteFile(configPath, []byte(yamlContent), 0o600)
|
|
if err != nil {
|
|
t.Fatalf("failed to write test config: %v", err)
|
|
}
|
|
|
|
return configPath
|
|
}
|
|
|
|
// checkAllowlistHosts loads the config at configPath and asserts that
|
|
// getStringSlice returns the three expected hosts.
|
|
func checkAllowlistHosts(t *testing.T, configPath string) {
|
|
t.Helper()
|
|
|
|
sc, err := loadTestConfig(configPath)
|
|
if err != nil {
|
|
t.Fatalf("failed to load config: %v", err)
|
|
}
|
|
|
|
hosts := getStringSlice(sc)
|
|
|
|
if len(hosts) != 3 {
|
|
t.Errorf("expected 3 hosts, got %d: %v", len(hosts), hosts)
|
|
}
|
|
|
|
expected := []string{"static.sneak.cloud", "sneak.berlin", "s3.sneak.cloud"}
|
|
for i, want := range expected {
|
|
if i >= len(hosts) {
|
|
t.Errorf("missing host at index %d: want %q", i, want)
|
|
|
|
continue
|
|
}
|
|
|
|
if hosts[i] != want {
|
|
t.Errorf("host[%d] = %q, want %q", i, hosts[i], want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestGetStringSlice_YAMLList(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
yamlContent := `
|
|
allowlist_hosts:
|
|
- static.sneak.cloud
|
|
- sneak.berlin
|
|
- s3.sneak.cloud
|
|
`
|
|
|
|
checkAllowlistHosts(t, writeTestConfig(t, yamlContent))
|
|
}
|
|
|
|
func TestGetStringSlice_CommaSeparated(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// Backwards compatibility with comma-separated string values.
|
|
yamlContent := `allowlist_hosts: "static.sneak.cloud, sneak.berlin, s3.sneak.cloud"`
|
|
|
|
checkAllowlistHosts(t, writeTestConfig(t, yamlContent))
|
|
}
|
|
|
|
func TestGetStringSlice_Empty(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
configPath := writeTestConfig(t, `port: 8080`)
|
|
|
|
sc, err := loadTestConfig(configPath)
|
|
if err != nil {
|
|
t.Fatalf("failed to load config: %v", err)
|
|
}
|
|
|
|
hosts := getStringSlice(sc)
|
|
if len(hosts) != 0 {
|
|
t.Errorf("expected nil or empty slice, got %v", hosts)
|
|
}
|
|
}
|
|
|
|
// loadTestConfig is a helper to load a config file for testing.
|
|
func loadTestConfig(path string) (*smartconfig.Config, error) {
|
|
return smartconfig.NewFromConfigPath(path)
|
|
}
|