clawbot
00d8ba26c5
check / check (push) Canceled after 0s
The new package internal/imagerequest holds the request type, its two parts Source and Transform, the Format and Fit types, the dimension and fit checks, the /v1/image/ path parsing and the variant key; it imports no other package of pixa. imgcache.ParsedURL, imgcache.ImageRequest, signature.Request, imageprocessor.Request, the second Size, format and fit types and the conversions between them are gone. The image processor takes a Transform only. encurl keeps a private struct with the token's short CBOR field names. VariantKey moves with the function that makes it. Tests follow the moved and renamed code; the tests of the removed conversions go with them. Model: opus-5-5
50 lines
1.5 KiB
Go
50 lines
1.5 KiB
Go
package handlers
|
|
|
|
import (
|
|
"fmt"
|
|
"log/slog"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
|
|
"sneak.berlin/go/pixa/internal/imageprocessor"
|
|
"sneak.berlin/go/pixa/internal/imagerequest"
|
|
)
|
|
|
|
// TestAVIFOutputTooLargeAnswers400 checks that respondImageError and
|
|
// handleImageError, which answer the errors of the two image routes, answer
|
|
// 400 naming the AVIF pixel limit when the image processor refuses an AVIF
|
|
// output above it, wrapped as the service wraps it. The request's source only
|
|
// goes into a log line, so it is left empty.
|
|
func TestAVIFOutputTooLargeAnswers400(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
h := &Handlers{log: slog.New(slog.DiscardHandler)}
|
|
err := fmt.Errorf("image processing failed: %w: 4097x4096",
|
|
imageprocessor.ErrAVIFOutputTooLarge)
|
|
wantBody := fmt.Sprintf("above %d pixels", imageprocessor.MaxAVIFOutputPixels)
|
|
|
|
plain := httptest.NewRecorder()
|
|
h.respondImageError(plain, &imagerequest.Request{}, err)
|
|
|
|
encrypted := httptest.NewRecorder()
|
|
h.handleImageError(encrypted, err)
|
|
|
|
for name, rec := range map[string]*httptest.ResponseRecorder{
|
|
"respondImageError": plain, "handleImageError": encrypted,
|
|
} {
|
|
t.Logf("%s: status = %d, body = %q", name, rec.Code, rec.Body.String())
|
|
|
|
if rec.Code != http.StatusBadRequest {
|
|
t.Errorf("%s: status = %d, want %d",
|
|
name, rec.Code, http.StatusBadRequest)
|
|
}
|
|
|
|
if !strings.Contains(rec.Body.String(), wantBody) {
|
|
t.Errorf("%s: body = %q, want it to say %q",
|
|
name, rec.Body.String(), wantBody)
|
|
}
|
|
}
|
|
}
|