refactor: extract signature package from imgcache #46

Merged

sneak merged 5 commits from refactor/extract-signature into main 2026-08-07 17:44:00 +02:00

Conversation 7 Commits 5 Files Changed 15

+380 -220

5 Commits

Author	SHA1	Message	Date
sneak	8ebbe4d437	Merge branch 'main' into refactor/extract-signature	2026-08-07 17:41:12 +02:00
sneak	3dc1999543	refactor: rename whitelist_hosts config key to allowlist_hosts	2026-08-07 22:24:18 +07:00
sneak	43b9f1cb59	refactor: finish whitelist-to-allowlist rename in imgcache	2026-08-07 21:24:31 +07:00
sneak	d69019b9d1	test: pin signature format with golden known-answer vectors	2026-08-07 21:03:24 +07:00
sneak	6526b717dd	refactor: extract signature package from imgcache ... Move HMAC-SHA256 request signing out of internal/imgcache/ into its own internal/signature/ package, per the plan in issue #39. This is one of the remaining "easily separable" extractions; only the signer is moved here so the diff stays reviewable. What moved (from internal/imgcache/signature.go): - Signer type, its New constructor, Sign, Verify, GenerateSignedURL - ParseParams (query-string signature/expiration parsing) - Signature error sentinels To keep the import edge one-way (imgcache depends on signature, never the reverse), the package defines a standalone Request type carrying just the fields the signature covers, instead of importing imgcache.ImageRequest. imgcache projects its ImageRequest onto signature.Request via a small unexported helper. Renames (no stuttering): - NewSigner -> signature.New - ParseSignatureParams -> signature.ParseParams - ErrSignatureRequired/Invalid/Expired -> signature.ErrRequired/Invalid/Expired The "non-whitelisted host" error message is updated to "non-allowlisted" for inclusive terminology, consistent with the allowlist rename. Pure refactor. The bytes fed to the HMAC are unchanged, so signatures remain compatible. All existing tests move with the package; docker build passes (fmt-check, lint, test, build). refs #39	2026-07-25 17:51:30 +07:00