sneak/pixa

Stop a transcode whose request has ended before it encodes (closes #243) #271

Merged

clawbot merged 6 commits from issue-243-stop-transcode-past-deadline into next

2026-10-15 18:44:12 +02:00

Author	SHA1	Message	Date
clawbot	4c3bc19ca0	Put this PR's TODO.md entry back at the top of Completed Steps check / check (push) Waiting to run Details The rebase onto next placed it under the entry for the negative cache cleanup, as union merge keeps next's lines first. Model: opus-5-5	2026-10-15 16:17:11 +00:00
clawbot	754728bb79	Say govips gives pixa no way to stop an encode; give AVIF's worst case libvips can stop a running encode, but govips gives pixa no way to ask it to, which README.md "Routes" and the Process and encode comments now say in place of "libvips cannot stop an encode". The avifEffort comment gives its 51 seconds as the RGB time and 110 seconds with an alpha channel as the worst case, as README.md does. Model: opus-5-5	2026-10-15 16:16:45 +00:00
clawbot	6352b557ec	Answer 503 to a request waiting on a transcode stopped at a deadline A request that waited for another request's transcode got that request's deadline error when the transcode stopped at its deadline, and both image routes answered it 500, though the waiting request's own downstream_timeout had time left. The image service now returns ErrProcessingTimedOut for it, which both routes answer 503 "server busy, try again later", as when pixa is busy. README.md "Routes" says so. Model: opus-5-5	2026-10-15 16:16:45 +00:00
clawbot	1b0fa8981e	Test the 503 for a request waiting on a transcode stopped at a deadline A request that waited for another request's transcode, stopped at that request's deadline, must get ErrProcessingTimedOut, which both image routes answer 503. Declares that error so the tests build. Also tests that Process, past its deadline before it starts, never reads its input. Model: opus-5-5	2026-10-15 16:16:45 +00:00
clawbot	0e0b4ba654	Stop a transcode whose request has ended before it encodes (closes #243 ) Process looked at its context only while it waited for a processing slot, so a transcode went on decoding and encoding, holding its slot, however long after its request's downstream_timeout that took. acquireSlot now gives the slot back and returns the context's error when the context has ended by the time it has a slot, and encode returns that error without beginning. libvips cannot stop an encode once it has begun, so that encode keeps its slot until it finishes. README.md gives how long that can take per output format at the 8192 limits and no longer says the work stops when downstream_timeout ends; TODO.md is corrected the same way. Model: opus-5-5	2026-10-15 16:16:45 +00:00
clawbot	dcb32ab697	Test that Process stops once its deadline has passed Process looks at its context only while it waits for a processing slot, so a request whose deadline has passed, before Process starts or while it reads its input, still has its image decoded and encoded while it holds the slot. The new test fails until Process returns context.DeadlineExceeded in both cases and gives the slot back (#243). Model: opus-5-5	2026-10-15 16:16:45 +00:00