sneak/pixa
1
0
Fork 0
Code Issues 32 Pull Requests 4 Actions 3 Packages Projects Releases Wiki Activity

Make the cache stats count what is cached, fetched and transcoded (closes #56) #144

Merged
clawbot merged 6 commits from issue-56-stats-counters into next 2026-09-29 05:25:11 +02:00
Conversation 5 Commits 6 Files Changed 5
+390 -41
6 Commits
Author SHA1 Message Date
clawbot 31ed20ec9e Count a late hit, and report no totals on a disabled cache (closes #56)
check / check (push) Successful in 3m12s
Details 
A hit is now counted with the request context detached from its
cancellation, as the miss already is, so a hit served after the client
left or the request timed out still moves the hit count. On a disabled
disk cache, Stats reports no items and no size, whatever rows an earlier
run left in the database; the size already followed that rule.

Model: opus-5-5
 2026-09-29 02:46:31 +00:00
clawbot 3daa416f4b Test that a late hit and a disabled cache are counted right (closes #56) 
A hit served after the request context has ended must still move the hit
count, and a disabled disk cache must report no items and no size even
when its database holds rows from an earlier run.

Model: opus-5-5
 2026-09-29 02:46:31 +00:00
clawbot 614bcd9eb6 Count interrupted misses and the upstream bytes they read (closes #56) 
The miss and transform counters are written with context.WithoutCancel,
so a client disconnect or the request timeout during or after the work
no longer loses them. A failed read of the upstream body now returns
the bytes read before the error, so an over-size or cut-off body still
moves the upstream fetch counters. processFromSourceOrFetch passes the
cached source's length directly instead of through a local named
fetchBytes.

Model: opus-5-5
 2026-09-29 02:46:30 +00:00
clawbot 64108c05bb Test that cache stats count interrupted misses (closes #56) 
Checks every cache_stats counter after a miss whose request context
ends during or after the upstream fetch, and after one whose upstream
body is over the size limit.

Model: opus-5-5
 2026-09-29 02:46:30 +00:00
clawbot ae8b45e93f Make the cache stats count what is cached, fetched and transcoded (closes #56) 
Stats read request_cache and output_content, which nothing writes, so
TotalItems and TotalSizeBytes were always 0. They now count
source_content plus variant_content, the size through UsageBytes; a
failed query is still logged at warn. Get counts a miss after the work,
passing the bytes fetched from upstream (0 for a cached source; still
counted when the fetched source then fails), so upstream_fetch_count and
upstream_fetch_bytes move. transform_count is incremented after each
successful image processor call. request_cache and output_content stay
in the schema; dropping them is a separate decision.

Model: opus-5-5
 2026-09-29 02:46:30 +00:00
clawbot 19e018b037 Test that the cache stats counters and totals move (closes #56) 
Failing tests, committed ahead of the fix. Stats totals are checked
after storing a source image and two processed variants. A walk through
Service.Get (a miss that fetches, a hit, a miss that reuses the cached
source, a source failing the magic byte check, a source not found)
checks every cache_stats counter after each step. The warn-log test for
the Stats queries now drops source_content and variant_content, the
tables Stats will read.

Model: opus-5-5
 2026-09-29 02:46:30 +00:00