internal/server/http.go

@@ -9,24 +9,40 @@ import (
 
 // HTTP server configuration constants.
 const (
-	HTTPReadTimeout    = 30 * time.Second
+	HTTPReadTimeout = 30 * time.Second
-	HTTPWriteTimeout   = 60 * time.Second
+	// HTTPReadHeaderTimeout bounds the request-header read on its own,
+	// short, so a slowloris client dribbling headers is dropped well
+	// before it ties up a connection for the whole ReadTimeout window.
+	HTTPReadHeaderTimeout = 10 * time.Second
+	HTTPWriteTimeout      = 60 * time.Second
+	// HTTPIdleTimeout bounds how long an idle keep-alive connection is
+	// held open, so idle connections cannot accumulate without limit on a
+	// service targeting high concurrency.
+	HTTPIdleTimeout    = 120 * time.Second
 	HTTPMaxHeaderBytes = 8 << 10 // 8KB
 )
 
-func (s *Server) serveUntilShutdown() {
+// newHTTPServer builds the http.Server with the hardening timeouts and
-	listenAddr := fmt.Sprintf(":%d", s.config.Port)
+// limits applied. It is separate from serveUntilShutdown so the
-	s.httpServer = &http.Server{
+// configuration can be asserted in a test without binding a listener.
-		Addr:           listenAddr,
+func (s *Server) newHTTPServer() *http.Server {
-		ReadTimeout:    HTTPReadTimeout,
+	return &http.Server{
-		WriteTimeout:   HTTPWriteTimeout,
+		Addr:              fmt.Sprintf(":%d", s.config.Port),
-		MaxHeaderBytes: HTTPMaxHeaderBytes,
+		ReadTimeout:       HTTPReadTimeout,
-		Handler:        s,
+		ReadHeaderTimeout: HTTPReadHeaderTimeout,
+		WriteTimeout:      HTTPWriteTimeout,
+		IdleTimeout:       HTTPIdleTimeout,
+		MaxHeaderBytes:    HTTPMaxHeaderBytes,
+		Handler:           s,
 	}
+}
+
+func (s *Server) serveUntilShutdown() {
+	s.httpServer = s.newHTTPServer()
 
 	s.SetupRoutes()
 
-	s.log.Info("http begin listen", "listenaddr", listenAddr)
+	s.log.Info("http begin listen", "listenaddr", s.httpServer.Addr)
 
 	err := s.httpServer.ListenAndServe()
 	if err != nil && !errors.Is(err, http.ErrServerClosed) {