Refuse an image URL whose source path or query holds a # (closes #286)
check / check (push) Canceled after 0s
check / check (push) Canceled after 0s
A # written as %23 reached the parser decoded and stayed in the source path or query. The source URL built from it ended at the # when it was fetched, so each text after it fetched the same upstream image, without a signature for an allowlisted host, and cached it under keys of its own. Such a URL is now refused with 400, and README.md says neither the source path nor the source query may hold a #. Model: opus-5-5
This commit is contained in:
@@ -171,6 +171,14 @@ func parseImageComponents(remainder string) (*ParsedURL, error) {
|
||||
// host
|
||||
host = strings.ToLower(host)
|
||||
|
||||
// Go's URL parser, which the fetcher uses, reads a "#" as the start of a
|
||||
// fragment and drops the rest, so each text after it would be another
|
||||
// spelling, cached under its own keys, of one upstream request
|
||||
if strings.Contains(path, "#") {
|
||||
return nil, fmt.Errorf(
|
||||
`%w: the source path or query holds a "#"`, ErrInvalidPath)
|
||||
}
|
||||
|
||||
// Extract query string if present in path
|
||||
if qIndex := strings.Index(path, "?"); qIndex != -1 {
|
||||
query = path[qIndex+1:]
|
||||
|
||||
Reference in New Issue
Block a user