Refuse an image URL whose source path or query holds a # (closes #286)
check / check (push) Canceled after 0s
check / check (push) Canceled after 0s
A # written as %23 reached the parser decoded and stayed in the source path or query. The source URL built from it ended at the # when it was fetched, so each text after it fetched the same upstream image, without a signature for an allowlisted host, and cached it under keys of its own. Such a URL is now refused with 400, and README.md says neither the source path nor the source query may hold a #. Model: opus-5-5
This commit is contained in:
@@ -323,8 +323,9 @@ first `/`, the size and format after the last `/`, and between them the source
|
||||
path up to the first `?` and the source query after it. So the `?` before the
|
||||
query, any `?` in the query, and every `%` in the source path or query must be
|
||||
percent-encoded, as `%3F` and `%25`. Any other character may be written as
|
||||
itself or percent-encoded: `/`, `;`, `,`, `=` and `&` work either way. For
|
||||
example,
|
||||
itself or percent-encoded: `/`, `;`, `,`, `=` and `&` work either way. Neither
|
||||
the source path nor the source query may hold a `#`, and an image URL that
|
||||
writes one as `%23` is refused with 400. For example,
|
||||
`https://cdn.example.com/img?url=https://origin.example.com/my%20cat.jpg` at
|
||||
800x600 WebP is
|
||||
`/v1/image/cdn.example.com/img%3Furl=https://origin.example.com/my%2520cat.jpg/800x600.webp`,
|
||||
|
||||
Reference in New Issue
Block a user