Refuse an IPv6 address that holds an internal IPv4 address (closes #297)
check / check (push) Canceled after 0s
check / check (push) Canceled after 0s
The check that keeps pixa from fetching internal addresses read an IPv6 address as IPv4 only in the mapped form (::ffff:a.b.c.d), so the IPv4-compatible form, such as ::127.0.0.1, was judged as IPv6 and passed. An address in ::/96 is now judged by the IPv4 address it holds, so one holding a private, loopback or link-local address is refused on both image routes before any upstream request. The NAT64 range 64:ff9b::/96 stays blocked whole, as it was on next. Model: opus-5-5
This commit was merged in pull request #298.
This commit is contained in:
@@ -543,3 +543,46 @@ func encryptedImageURL(t *testing.T, sourceHost string) string {
|
||||
|
||||
return "/v1/e/" + token + "/img.png"
|
||||
}
|
||||
|
||||
// TestImageRoutesRefuseIPv6SourceHostHoldingInternalIPv4Address requests
|
||||
// ipv6SourcePath on IPv6 source hosts that hold a loopback or private IPv4
|
||||
// address in their last four bytes, in the IPv4-compatible form (::/96) or the
|
||||
// NAT64 form (64:ff9b::/96), through a /v1/image/ URL with a signature and
|
||||
// through an encrypted URL. Each answers 403, and the upstream receives no
|
||||
// request: the test's fetcher connects every address to the test upstream, so
|
||||
// only the fetcher's check of the source URL can refuse it.
|
||||
func TestImageRoutesRefuseIPv6SourceHostHoldingInternalIPv4Address(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
upstream := startRecordingUpstream(t)
|
||||
s, _, _ := startImageProxy(t, upstream.Server)
|
||||
|
||||
sourceHosts := []string{
|
||||
"[::127.0.0.1]", // IPv4-compatible form of a loopback address
|
||||
"[::10.0.0.1]", // IPv4-compatible form of a private address
|
||||
"[64:ff9b::7f00:1]", // NAT64 form of 127.0.0.1
|
||||
}
|
||||
|
||||
for _, sourceHost := range sourceHosts {
|
||||
imageURLs := []string{
|
||||
signedImageURL(t, sourceHost),
|
||||
encryptedImageURL(t, sourceHost),
|
||||
}
|
||||
|
||||
for _, imageURL := range imageURLs {
|
||||
rec := httptest.NewRecorder()
|
||||
s.ServeHTTP(rec, httptest.NewRequestWithContext(
|
||||
t.Context(), http.MethodGet, imageURL, nil))
|
||||
t.Logf("GET %s (source host %s): %d", imageURL, sourceHost, rec.Code)
|
||||
|
||||
if rec.Code != http.StatusForbidden {
|
||||
t.Errorf("source host %s: status = %d, want %d; body %s",
|
||||
sourceHost, rec.Code, http.StatusForbidden, rec.Body.String())
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if got := upstream.requestTargets(); len(got) != 0 {
|
||||
t.Errorf("upstream received %q, want no request", got)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user